| Summary: | Task context menu disappears when Task's tooltip disappears | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Patrick Silva <bugseforuns> |
| Component: | general | Assignee: | David Edmundson <kde> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | a.geno, alex765, anditosan1000, arojas, aspotashev, brianaberts, bugsKde, butirsky, fastos2016, goeran, katyaberezyaka, kde, lukas, m.stockhammer, marco.ambu, matejm98mthw, maugrerain, meven29, mvourlakos, nate, plasma-bugs, postix, r.kunschke, rdieter, s1994928, theivorytower, tromzy, twinshadows404, yuno-gasai |
| Priority: | VHI | Keywords: | wayland |
| Version: | 5.18.1 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| URL: | https://codereview.qt-project.org/c/qt/qtwayland/+/347783 | ||
| See Also: |
https://bugs.kde.org/show_bug.cgi?id=416869 https://bugs.kde.org/show_bug.cgi?id=427542 |
||
| Latest Commit: | https://invent.kde.org/plasma/plasma-desktop/commit/498645ae60da4304512e72884fe2d0401073a628 | Version Fixed In: | 5.23 |
| Sentry Crash Report: | |||
|
Description
Patrick Silva
2020-02-20 16:04:30 UTC
*** Bug 421635 has been marked as a duplicate of this bug. *** Bug is reported upstream to Qt https://bugreports.qt.io/browse/QTBUG-83972 So is this 100% an upstream issue? Should we close the bug report? *** Bug 423357 has been marked as a duplicate of this bug. *** *** Bug 426545 has been marked as a duplicate of this bug. *** *** Bug 426994 has been marked as a duplicate of this bug. *** Oh, this is the issue where the tooltip closes along with the context menu. We have a bunch of bugs on that somewhere else, Let me mark them as duped of the same master bug. Oh wait, this was it lol *** Bug 416869 has been marked as a duplicate of this bug. *** *** Bug 421602 has been marked as a duplicate of this bug. *** *** Bug 431932 has been marked as a duplicate of this bug. *** *** Bug 432024 has been marked as a duplicate of this bug. *** *** Bug 432079 has been marked as a duplicate of this bug. *** *** Bug 427542 has been marked as a duplicate of this bug. *** Wow, this is really annoying. No wonder we have so many duplicate bug reports. Raising the priority accordingly. *** Bug 433861 has been marked as a duplicate of this bug. *** *** Bug 431147 has been marked as a duplicate of this bug. *** *** Bug 429750 has been marked as a duplicate of this bug. *** plasma is the one who dismisses the context menu. moving the bug report to plasmashell as my knowledge of plasma's internals is limited and we can't fix this bug in kwin. https://invent.kde.org/qt/qt/qtwayland/-/blob/00b9c558886945bd9b37671732d14e3982fe3da5/src/client/qwaylandwindow.cpp#L459 It looks like QtWaylandClient is at fault! (In reply to Vlad Zahorodnii from comment #20) > https://invent.kde.org/qt/qt/qtwayland/-/blob/ > 00b9c558886945bd9b37671732d14e3982fe3da5/src/client/qwaylandwindow.cpp#L459 > > It looks like QtWaylandClient is at fault! Do you think you could try fixing it? This bug is basically a showstopper for Wayland. A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/903 Can confirm this with Plasma 5.21.4 on Wayland A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/451 Potential upstream fix: https://codereview.qt-project.org/c/qt/qtwayland/+/347783 *** Bug 431409 has been marked as a duplicate of this bug. *** The situation is better on Plasma 5.22 beta, but still not perfect : when I right click an entry in the Task Manager : - if the right click menu pops in front of the window thumbnail, then the right click menu does not vanish before I can click anything on it (good behaviour) - if the window thumbnail pops in front of the right click menu, then the right click menu vanishes at the same time than the thumbnail, making it impossible to click anything on it. Git commit d24ab7b5a7fc127f7278be79ef49f9a028358d01 by David Redondo. Committed on 17/05/2021 at 10:34. Pushed by davidre into branch 'master'. Hide tooltip window immediately before opening context menu Tooltip internally uses TooltipDialog (a QWindow subclass) which runs a timer before it hides itself. This is done so it can be reused and to prevent flickering when switching between Tooltips quickly. However here it causes an issue, when closing a popup on Wayland, Qt closes all popups that were opened after it. This means when openening a ContextMenu while a Tooltip is shown, the TooltipDialog will hide itself *after* the window of the context menu has been created and close it in the process. As a workaround we can hide the window manually before creating the context menu. FIXED-IN:5.22 M +3 -0 applets/taskmanager/package/contents/ui/Task.qml https://invent.kde.org/plasma/plasma-desktop/commit/d24ab7b5a7fc127f7278be79ef49f9a028358d01 Git commit db44453430f6684df06cc1f9c42b3a7eb4b16b86 by David Redondo. Committed on 17/05/2021 at 13:07. Pushed by davidre into branch 'Plasma/5.22'. Hide tooltip window immediately before opening context menu Tooltip internally uses TooltipDialog (a QWindow subclass) which runs a timer before it hides itself. This is done so it can be reused and to prevent flickering when switching between Tooltips quickly. However here it causes an issue, when closing a popup on Wayland, Qt closes all popups that were opened after it. This means when openening a ContextMenu while a Tooltip is shown, the TooltipDialog will hide itself *after* the window of the context menu has been created and close it in the process. As a workaround we can hide the window manually before creating the context menu. FIXED-IN:5.22 (cherry picked from commit d24ab7b5a7fc127f7278be79ef49f9a028358d01) M +3 -0 applets/taskmanager/package/contents/ui/Task.qml https://invent.kde.org/plasma/plasma-desktop/commit/db44453430f6684df06cc1f9c42b3a7eb4b16b86 We've done everything we can on our side; the remaining pieces for fixing this have to be done in Qt. Vlad has helpfully submitted a fix already: https://codereview.qt-project.org/c/qt/qtwayland/+/347783 If and when that is merged into Qt6, we can cherry-pick it into our Qt5 patch collection. Reopening since I had to revert our workaround Git commit 498645ae60da4304512e72884fe2d0401073a628 by David Redondo. Committed on 28/06/2021 at 12:04. Pushed by davidre into branch 'master'. Hide tooltip before opening contextMenu The tooltip hiding after the context menu is opened, will hide the context menu. See d24ab7b5a7fc127f7278be79ef49f9a028358d01 for detailed explanation. FIXED-IN:5.23 M +1 -0 applets/taskmanager/package/contents/ui/Task.qml https://invent.kde.org/plasma/plasma-desktop/commit/498645ae60da4304512e72884fe2d0401073a628 Is there anything left to do here? We have now a workaround for the underlying issue Does that mean that no user will ever see the problem again? For this specific instance I hope so but there could be other places in plasma where we have this interaction between a tooltip and contextmenu but that would be another bug This bug persists with systray icons on neon unstable (duplicate bug 416869). *** Bug 441941 has been marked as a duplicate of this bug. *** |