| Summary: | Context view is not fully formed when starting Amarok | ||
|---|---|---|---|
| Product: | [Applications] amarok | Reporter: | bill p. (aka google01103) <dweeble01103> |
| Component: | Context View | Assignee: | Amarok Developers <amarok-bugs-dist> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | asturm, axel.braun, b3nmore, bwyazel, fire, gabextreme, hrvoje.senjan, john, kde, kirill.bogdanenko, lafferx, liuerfire, martin.ruessler, matej, mr.erdk, pligdas, proba223, sam, simon.esneault, simon, thoor1, turtlevt, web, xhanka00, XVampireX |
| Priority: | NOR | ||
| Version: | 2.5-git | ||
| Target Milestone: | 2.7 | ||
| Platform: | Unlisted Binaries | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/amarok/a0f4288e0b952830d38151264c0a8b042e32d8a4 | Version Fixed In: | 2.6 |
| Attachments: | how Amarok looks when started | ||
|
Description
bill p. (aka google01103)
2012-01-30 19:01:41 UTC
This is not Qt 4.8 specific - I am now getting the same issue with Amarok Git, KDE 4.8 and Qt 4.7.4. I had not, however, seen the problem with KDE 4.7. This said, I didn't get it the first couple of times I started it on KDE 4.8 either, but it seems to be happening every time now. http://img824.imageshack.us/img824/7809/amarokcontextweird.png I still can't reproduce this here. I can confirm this with the stable version of Amarok. Distro: Arch linux WM: Awesome Package versions: amarok 2.5.0-2 kdebase-runtime 4.8.0-1 kdelibs 4.8.0-1 qt 4.8.0-2 awesome 3.4.11 cairo-xcb 1.10.2 Apparently it happen here as well, but I can only reproduce it when closing and reopening Amarok shortly one after the other. Myriam define "shortly"? I just waited 10 minutes and it did not display correctly As best as I can recall duration between re-openings does not matter for me Shortly between closing Amarok and restarting it: about a minute or two Also seeing this intermittantly. Plus, on occasions, half the collection list disappears and only scrolls in half the allocated window. openSuse 12.1 KDE 4.8 Amarok 2.50-141-2 qt 4.80-254-1 (In reply to comment #7) > Also seeing this intermittantly. Plus, on occasions, half the collection list > disappears and only scrolls in half the allocated window. > Could you provide screenshots of that? On 09/02/12 20:57, Myriam Schweingruber wrote: > https://bugs.kde.org/show_bug.cgi?id=292895 > > > > > > --- Comment #8 from Myriam Schweingruber<myriam kde org> 2012-02-09 20:57:47 --- > (In reply to comment #7) >> Also seeing this intermittantly. Plus, on occasions, half the collection list >> disappears and only scrolls in half the allocated window. >> > Could you provide screenshots of that? > It is intermittant. Of course, haven't seen it since I posted! Will take screen shot if it happens again. John F. same here with current git, screenshot looks exactly like mine i get some amarok(7995)/libplasma Plasma::ViewPrivate::updateSceneRect: !!!!!!!!!!!!!!!!! setting the scene rect to QRectF(0,0 200x200) associated screen is -1 amarok(7995)/libplasma Plasma::ViewPrivate::updateSceneRect: !!!!!!!!!!!!!!!!! setting the scene rect to QRectF(0,0 200x200) associated screen is -1 amarok: BEGIN: void LyricsApplet::dataUpdat and 200*200px might fit to the size I just upgraded my SuSe 12.1 system from KDE 4.7 to KDE 4.8 today. While amarok worked fine before the upgrade, I am having the same problem as initially described - the context panel does not properly open until the main window is resized. I know, it's not a big problem - just annoying, but I wanted to let you know the problem is not just for one individual. This is related to plasma actually, we are about to refactor the Context View rewriting the engines. Not sure this will happen before Amarok 2.7 though. (In reply to comment #10) > same here with current git, screenshot looks exactly like mine > > i get some > > > amarok(7995)/libplasma Plasma::ViewPrivate::updateSceneRect: > !!!!!!!!!!!!!!!!! setting the scene rect to QRectF(0,0 200x200) associated > screen is -1 > amarok(7995)/libplasma Plasma::ViewPrivate::updateSceneRect: > !!!!!!!!!!!!!!!!! setting the scene rect to QRectF(0,0 200x200) associated > screen is -1 > amarok: BEGIN: void LyricsApplet::dataUpdat > > and 200*200px might fit to the size That's right, amarok ignores the geometry setting in .kde/share/config/amarok-appletsrc and just starts with 200,200. Okay, I ran git bisect, and this bug was introduced by commit 79bd9a7c6777e3f5d4e723bc5d3b00e5d6fe532b, "Fix infinite loop in context view eating CPU until main window is shown", by Matěj Laitl (I've cc'ed him in on this bug). Confirmed by undoing that change on current master, and the applet containment starts the right size. The CPU consumption bug returns, however. (In reply to comment #14) > Okay, I ran git bisect, and this bug was introduced by commit > 79bd9a7c6777e3f5d4e723bc5d3b00e5d6fe532b, "Fix infinite loop in context view > eating CPU until main window is shown", by Matěj Laitl (I've cc'ed him in on > this bug). > Confirmed by undoing that change on current master, and the applet > containment starts the right size. The CPU consumption bug returns, however. OK, thanks for digging this out. I will eat my own dogfood and try to find the root of the problem. (In reply to comment #15) > (In reply to comment #14) > > Okay, I ran git bisect, and this bug was introduced by commit > > 79bd9a7c6777e3f5d4e723bc5d3b00e5d6fe532b, "Fix infinite loop in context view > > eating CPU until main window is shown", by Matěj Laitl (I've cc'ed him in on > > this bug). > > Confirmed by undoing that change on current master, and the applet > > containment starts the right size. The CPU consumption bug returns, however. > > OK, thanks for digging this out. I will eat my own dogfood and try to find > the root of the problem. The CPU drain was definitely a bigger issue. This seems only to have been recorded post KDE4.8, so that might provide some hints as to what exactly is going wrong. My guess is the simplest solution here is just triggering the resize event at the correct point once it actually knows its size. I did have a look at the code, but it's not something I've ever worked with before and I only got as far as confirming that triggering a timer to run the resizing code with a short delay works; I didn't locate the point at which the size actually becomes available, but it's after the MainWindow init finishes. The Plasma stuff is scheduled to be replaced by QML instead at some point, so it's probably not worth fixing the layouts properly at this juncture unless that's easier. *** Bug 296878 has been marked as a duplicate of this bug. *** *** Bug 297444 has been marked as a duplicate of this bug. *** *** Bug 297649 has been marked as a duplicate of this bug. *** *** Bug 300597 has been marked as a duplicate of this bug. *** *** Bug 301094 has been marked as a duplicate of this bug. *** Any progress? It's a minor issue, but hugely annoyingly visible :) KDE SC 4.8.4, Qt-4.8.2, amarok-2.5.90 Plus, I've also seen the garbled collection list mentioned in comment #7 which is a bit more annoying. (In reply to comment #22) > Any progress? It's a minor issue, but hugely annoyingly visible :) No, but we are about to rewrite the Context View, this bug is not solvable otherwise. So you will need some more patience as this is a GSoC project. As you can see from the target already... > Plus, I've also seen the garbled collection list mentioned in comment #7 > which is a bit more annoying. Not related to this bug at all and reported in a different bug. This bug also exists in 2.5.0-2 and 2.5.90 Windows versions. However, I have not encountered it in 2.4.3-4 (still talking about the w32 version). *** Bug 302064 has been marked as a duplicate of this bug. *** Would like to mention that amarok 2.4 on KDE 4.8 and amarok 2.5 on KDE 4.7 looked fine. Th issue started to appear only on KDE 4.8 & amarok 2.5. Bug present with KDE 4.9 and last stable amarok version... Folks, thanks for all that feedback, but there is no need to confirm, this already is on the latest git and we really have already all the information we need. Please read the comments before adding info we already have. So I've returned to amarok master, but it isn't fixed there - probably in some developer's branch? ;) Sorry for the nagging, but if it isn't going to be fixed until 2.7 an otherwise great piece of software will appear to be of beta quality at first sight for a long time - which it certainly isn't. Really no half-ugly workaround possible? (In reply to comment #29) > Really no half-ugly workaround possible? There certainly is, I'll work-around this for 2.6. *** Bug 302327 has been marked as a duplicate of this bug. *** Git commit a0f4288e0b952830d38151264c0a8b042e32d8a4 by Matěj Laitl. Committed on 26/06/2012 at 00:42. Pushed by laitl into branch 'master'. Fix Context view not being fully formed on startup Something from inside Plasma tries to resize context view's sceneRect() to 200x200 px. I don't know why this happens, but let's hope we'll have QML context view soon, so don't investigate and use a work-around. FIXED-IN: 2.6 DIGEST: popular bug fixed in Amarok M +1 -0 ChangeLog M +2 -1 src/context/containments/verticallayout/VerticalToolbarContainment.cpp http://commits.kde.org/amarok/a0f4288e0b952830d38151264c0a8b042e32d8a4 recompiled with Matěj Laitl's Git commit a0f4288e0b952830d38151264c0a8b042e32d8a4 and it appears to be fixed *** Bug 288575 has been marked as a duplicate of this bug. *** Also confirming this is fixed seems to be fixed, yeah :D *** Bug 302874 has been marked as a duplicate of this bug. *** *** Bug 302988 has been marked as a duplicate of this bug. *** *** Bug 304027 has been marked as a duplicate of this bug. *** |
