Summary: | "keditbookmarks" crashed on drag-drop | ||
---|---|---|---|
Product: | [Applications] keditbookmarks | Reporter: | Valdas <zmogas> |
Component: | general | Assignee: | David Faure <faure> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | bkohler, black.beret, cfeck, dave, f.presel, faure, franjo124, hoffmann-clemens, hohenegger, ivan, ivaylo.kabakov, marcus, maxamillion, metalized, moltonel, mprizee, my.computer, peter, r77raphy, richard.llom, sreich, stevenschmidt |
Priority: | NOR | ||
Version: | 4.10.1 | ||
Target Milestone: | --- | ||
Platform: | Ubuntu | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/kde-baseapps/ae76d6f3ff367a152d511581161b87742d6934ab | Version Fixed In: | 4.11.3 |
Sentry Crash Report: | |||
Attachments: |
Bokkmarks exported from Firefox.
Step A mentioned in report. Step B mentioned in report. Output in console. New crash information added by DrKonqi New crash information added by DrKonqi New crash information added by DrKonqi New crash information added by DrKonqi New crash information added by DrKonqi New crash information added by DrKonqi New crash information added by DrKonqi New crash information added by DrKonqi New crash information added by DrKonqi Valgrind Trace of keditbookmarks |
Description
Valdas
2011-11-19 23:30:57 UTC
Created attachment 65857 [details]
Bokkmarks exported from Firefox.
Created attachment 65858 [details]
Step A mentioned in report.
Created attachment 65859 [details]
Step B mentioned in report.
Created attachment 65860 [details]
Output in console.
Created attachment 66968 [details]
New crash information added by DrKonqi
keditbookmarks (4.7.3 (4.7.3)) on KDE Platform 4.7.3 (4.7.3) using Qt 4.8.0
- What I was doing when the application crashed:
Moving a list of bookmarks out of a folder.
-- Backtrace (Reduced):
#4 QDomNode::QDomNode (this=0x7fff896950b0, n=...) at dom/qdom.cpp:2038
[...]
#6 0x0000003349410185 in KBookmarkModel::bookmarkForIndex(QModelIndex const&) const () from /usr/lib64/libkbookmarkmodel_private.so.4
#7 0x00000033494101f0 in KBookmarkModel::parent(QModelIndex const&) const () from /usr/lib64/libkbookmarkmodel_private.so.4
[...]
#12 0x0000003cacbd7654 in QAbstractItemModel::rowsInserted (this=<optimized out>, _t1=<optimized out>, _t2=9, _t3=9) at .moc/release-shared/moc_qabstractitemmodel.cpp:197
#13 0x0000003cacb71dbd in QAbstractItemModel::endInsertRows (this=0x1b2cad0) at kernel/qabstractitemmodel.cpp:2433
Created attachment 68248 [details]
New crash information added by DrKonqi
keditbookmarks (4.7.97 (4.8 RC2 (4.7.97)) on KDE Platform 4.8.00 (4.8.0 using Qt 4.7.4
- What I was doing when the application crashed:
After importing bookmarks from Mozilla SeaMonkey, I selected them all and tried to drag them to the root of the bookmarks tree.
If I only dragged one file or folder at a time, it worked, but dragging 2+ files a/o folders together resulted in a crash
-- Backtrace (Reduced):
#6 QDomNode::QDomNode (this=0x7fffb15c1580, n=...) at dom/qdom.cpp:2038
#7 0x00007f624fc1abdd in KBookmark (this=0x7fffb15c1580) at /usr/include/kbookmark.h:34
#8 TreeItem::bookmark (this=<optimized out>) at ../../../keditbookmarks/kbookmarkmodel/treeitem.cpp:87
#9 0x00007f624fc18d35 in KBookmarkModel::bookmarkForIndex (this=<optimized out>, index=<optimized out>) at ../../../keditbookmarks/kbookmarkmodel/model.cpp:396
#10 0x00007f624fc18da0 in KBookmarkModel::parent (this=0x1b71480, index=...) at ../../../keditbookmarks/kbookmarkmodel/model.cpp:263
Created attachment 69213 [details]
New crash information added by DrKonqi
keditbookmarks (4.7.97 (4.8 RC2 (4.7.97)) on KDE Platform 4.8.00 (4.8.0 using Qt 4.7.4
- What I was doing when the application crashed:
Opened bookmark editor from konqueror menu and imported Internet Explorer bookmarks to new folder. Trying to move multiple Items of this folder to parent directory by drag&drop the bookmark editor crashed.
-- Backtrace (Reduced):
#7 0xb7259c08 in QDomNode::QDomNode (this=0xbfc7a91c, n=...) at dom/qdom.cpp:2038
#8 0xb725bf43 in QDomElement::QDomElement (this=0xbfc7a91c, x=...) at dom/qdom.cpp:4738
#9 0xb758dc7d in KBookmark (this=0xbfc7a91c) at /usr/include/kbookmark.h:34
#10 TreeItem::bookmark (this=0x0) at ../../../keditbookmarks/kbookmarkmodel/treeitem.cpp:87
#11 0xb758b9a1 in KBookmarkModel::bookmarkForIndex (this=0x8b6b2d8, index=...) at ../../../keditbookmarks/kbookmarkmodel/model.cpp:396
Created attachment 70984 [details]
New crash information added by DrKonqi
keditbookmarks (4.8.2 (4.8.2)) on KDE Platform 4.8.2 (4.8.2) using Qt 4.8.1
- What I was doing when the application crashed:
Tried to drag&drop Bookmarks of a Bookmark Sub-Folder to Bookmark symbol tray (bookmark root folder). Bookmanagar crahes repeatably.
-- Backtrace (Reduced):
#6 QDomNode::QDomNode (this=0x7fffad47d5b0, n=...) at dom/qdom.cpp:2038
#7 0x00007f1df4ddfcfd in KBookmark (this=0x7fffad47d5b0) at /usr/include/kbookmark.h:34
#8 TreeItem::bookmark (this=<optimized out>) at ../../../keditbookmarks/kbookmarkmodel/treeitem.cpp:87
#9 0x00007f1df4dddd65 in KBookmarkModel::bookmarkForIndex (this=<optimized out>, index=...) at ../../../keditbookmarks/kbookmarkmodel/model.cpp:396
#10 0x00007f1df4ddddd0 in KBookmarkModel::parent (this=0x84dd00, index=...) at ../../../keditbookmarks/kbookmarkmodel/model.cpp:263
Created attachment 71753 [details]
New crash information added by DrKonqi
keditbookmarks (4.6.5 (4.6.5)) on KDE Platform 4.6.5 (4.6.5) using Qt 4.7.2
I create a new folder and want to move 6 bookmarks into it, when drag them to the new folder, it crash
-- Backtrace (Reduced):
#6 QDomNode::QDomNode (this=0x7fff3f3c7c80, n=...) at dom/qdom.cpp:2038
#7 0x00007f04fcec3ded in KBookmark (this=<value optimized out>) at /usr/include/kbookmark.h:35
#8 TreeItem::bookmark (this=<value optimized out>) at ../../../keditbookmarks/kbookmarkmodel/treeitem.cpp:87
#9 0x00007f04fcec1f56 in KBookmarkModel::bookmarkForIndex (this=<value optimized out>, index=<value optimized out>) at ../../../keditbookmarks/kbookmarkmodel/model.cpp:396
#10 0x00007f04fcec1fc1 in KBookmarkModel::parent (this=0x13fe930, index=...) at ../../../keditbookmarks/kbookmarkmodel/model.cpp:263
Created attachment 71754 [details]
New crash information added by DrKonqi
keditbookmarks (4.6.5 (4.6.5)) on KDE Platform 4.6.5 (4.6.5) using Qt 4.7.2
I try again to move bookmarks into a forlder. When I move only one, that work, but when I try with 2 or more at the same time it crash
-- Backtrace (Reduced):
#6 QDomNode::QDomNode (this=0x7ffff1b20480, n=...) at dom/qdom.cpp:2038
#7 0x00007fece88cbded in KBookmark (this=<value optimized out>) at /usr/include/kbookmark.h:35
#8 TreeItem::bookmark (this=<value optimized out>) at ../../../keditbookmarks/kbookmarkmodel/treeitem.cpp:87
#9 0x00007fece88c9f56 in KBookmarkModel::bookmarkForIndex (this=<value optimized out>, index=<value optimized out>) at ../../../keditbookmarks/kbookmarkmodel/model.cpp:396
#10 0x00007fece88c9fc1 in KBookmarkModel::parent (this=0x10825f0, index=...) at ../../../keditbookmarks/kbookmarkmodel/model.cpp:263
*** Bug 294008 has been marked as a duplicate of this bug. *** *** Bug 302407 has been marked as a duplicate of this bug. *** Created attachment 73639 [details]
New crash information added by DrKonqi
keditbookmarks (4.9.00) on KDE Platform 4.9.00 using Qt 4.8.2
- What I was doing when the application crashed:
-Created a new folder
-Searched using a term that returned multiple bookmarks
-Selected all the resulting bookmarks
-Clicked-and-dragged them into a folder on the left-hand-side pane.
-- Backtrace (Reduced):
#6 QDomNode::QDomNode (this=0x7fffd47d9060, n=...) at dom/qdom.cpp:2038
#7 0x00007fa8f4d04cfd in KBookmark (this=0x7fffd47d9060) at /usr/include/kbookmark.h:34
#8 TreeItem::bookmark (this=<optimized out>) at ../../../keditbookmarks/kbookmarkmodel/treeitem.cpp:87
#9 0x00007fa8f4d02d65 in KBookmarkModel::bookmarkForIndex (this=<optimized out>, index=...) at ../../../keditbookmarks/kbookmarkmodel/model.cpp:396
#10 0x00007fa8f4d02dd0 in KBookmarkModel::parent (this=0x1e10190, index=...) at ../../../keditbookmarks/kbookmarkmodel/model.cpp:263
Created attachment 75745 [details]
New crash information added by DrKonqi
keditbookmarks (4.9.3 "release 520") on KDE Platform 4.9.3 "release 520" using Qt 4.8.3
- What I was doing when the application crashed:
I was dragging some Firefox exported bookmarks to a new folder.
It works if you drag only a few (up to four I think), but crashes everytime you try to drag more bookmarks to a folder (newly created, or not)
- Custom settings of the application:
No special settings, I just want to replace firefox with rekonq :)
-- Backtrace (Reduced):
#5 0x00007f842bd4f070 in QDomNode::QDomNode(QDomNode const&) () from /usr/lib64/libQtXml.so.4
[...]
#7 0x00007f842c688515 in KBookmarkModel::bookmarkForIndex(QModelIndex const&) const () from /usr/lib64/libkbookmarkmodel_private.so.4
#8 0x00007f842c68857d in KBookmarkModel::parent(QModelIndex const&) const () from /usr/lib64/libkbookmarkmodel_private.so.4
[...]
#12 0x00007f842af1e204 in QAbstractItemModel::rowsAboutToBeInserted(QModelIndex const&, int, int) () from /usr/lib64/libQtCore.so.4
#13 0x00007f842aeb6446 in QAbstractItemModel::beginInsertRows(QModelIndex const&, int, int) () from /usr/lib64/libQtCore.so.4
*** Bug 313740 has been marked as a duplicate of this bug. *** Created attachment 78292 [details]
New crash information added by DrKonqi
keditbookmarks (4.10.1) on KDE Platform 4.10.1 using Qt 4.8.4
- What I was doing when the application crashed:
Dragging 9 Bookmarks from a subfolder to a parent folder.
Attached is a "3-star" backtrace.
Running on Chakra and KDE 4.10.1
-- Backtrace (Reduced):
#6 QDomNode::QDomNode (this=0x7fff654ded90, n=...) at dom/qdom.cpp:2038
#7 0x00007f7cf32dbcfd in KBookmark (this=0x7fff654ded90) at /usr/include/kbookmark.h:34
#8 TreeItem::bookmark (this=<optimized out>) at /chakra/desktop-testing/kde-baseapps/src/kde-baseapps-4.10.1/keditbookmarks/kbookmarkmodel/treeitem.cpp:87
#9 0x00007f7cf32d9ef5 in KBookmarkModel::bookmarkForIndex (this=this@entry=0x26cb470, index=...) at /chakra/desktop-testing/kde-baseapps/src/kde-baseapps-4.10.1/keditbookmarks/kbookmarkmodel/model.cpp:396
#10 0x00007f7cf32d9f5d in KBookmarkModel::parent (this=0x26cb470, index=...) at /chakra/desktop-testing/kde-baseapps/src/kde-baseapps-4.10.1/keditbookmarks/kbookmarkmodel/model.cpp:263
Created attachment 78294 [details]
Valgrind Trace of keditbookmarks
Attached is a valgrind trace of keditbookmarks
keditbookmarks crashed here by dragging bookmarks (as before).
Hope this helps, fixing this issues. Any devs here?
(In reply to comment #17) > Created attachment 78294 [details] > Valgrind Trace of keditbookmarks > > Attached is a valgrind trace of keditbookmarks > keditbookmarks crashed here by dragging bookmarks (as before). > Changing version and setting to confirmed. > Hope this helps, fixing this issues. Any devs here? Yes there, are developers here, the bug is assigned to them actually, see the "Assigned to:" field. The Cc list only lists the reporter, duplicate reporters and other interested people. Git commit e0c4b4478b6ef54772f4217ec8642d2beb6309c4 by David Faure. Committed on 05/05/2013 at 01:05. Pushed by dfaure into branch 'KDE/4.10'. Add unittest for DnD of multiple bookmarks When the bookmarks are selected from bottom to top, it works. When they are selected from top to bottom, it makes addresses invalid, and breaks. More debugging tomorrow. M +17 -1 keditbookmarks/kbookmarkmodel/tests/kbookmarkmodeltest.cpp http://commits.kde.org/kde-baseapps/e0c4b4478b6ef54772f4217ec8642d2beb6309c4 Git commit 712d12c143cbd4756cd55289ac086305b64743c8 by David Faure. Committed on 05/05/2013 at 09:59. Pushed by dfaure into branch 'KDE/4.10'. Move bookmarks in reverse order so that their address remains valid. FIXED-IN: 4.10.4 M +2 -1 keditbookmarks/kbookmarkmodel/model.cpp M +1 -1 keditbookmarks/kbookmarkmodel/tests/kbookmarkmodeltest.cpp http://commits.kde.org/kde-baseapps/712d12c143cbd4756cd55289ac086305b64743c8 *** Bug 226187 has been marked as a duplicate of this bug. *** *** Bug 318192 has been marked as a duplicate of this bug. *** *** Bug 317919 has been marked as a duplicate of this bug. *** *** Bug 263125 has been marked as a duplicate of this bug. *** *** Bug 256408 has been marked as a duplicate of this bug. *** *** Bug 245349 has been marked as a duplicate of this bug. *** *** Bug 187892 has been marked as a duplicate of this bug. *** *** Bug 221866 has been marked as a duplicate of this bug. *** It still crashes when dropping into the parent folder, or any other operation that invalidates the source or dest addresses during the copying. Solution: copy all selected bookmarks first, then delete them all (at their possibly updated address). I'm working on a fix. Git commit ae76d6f3ff367a152d511581161b87742d6934ab by David Faure. Committed on 15/10/2013 at 07:01. Pushed by dfaure into branch 'KDE/4.11'. Fix DnD crash for more cases (moving N bookmarks into subfolder or parent folder) Solution: copy all selected bookmarks first, then delete them all (at their possibly updated address). FIXED-IN: 4.11.3 M +15 -26 keditbookmarks/kbookmarkmodel/commands.cpp M +21 -7 keditbookmarks/kbookmarkmodel/tests/kbookmarkmodeltest.cpp http://commits.kde.org/kde-baseapps/ae76d6f3ff367a152d511581161b87742d6934ab *** Bug 255611 has been marked as a duplicate of this bug. *** *** Bug 323934 has been marked as a duplicate of this bug. *** |