| Summary: | URL parsing broken if URL includes port number or comma (or address is IPv6) | ||
|---|---|---|---|
| Product: | [Applications] konsole | Reporter: | bastimeyer123 |
| Component: | general | Assignee: | Konsole Developer <konsole-devel> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | a.samirh78, bugs, christian, nate, ninjalj, piotr.mierzwinski, post, sudden6, suienzan, tiposchi, tomasz.kane |
| Priority: | NOR | ||
| Version: | 22.04.0 | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/utilities/konsole/commit/c8d8abd1b2b8e93cc38b3bedb1b63f69791e5882 | Version Fixed In: | 22.08 |
| Sentry Crash Report: | |||
|
Description
bastimeyer123
2022-04-25 08:29:28 UTC
URLs with username:password fail too, btw: http://username:password@localhost/ The offending commit would be https://invent.kde.org/utilities/konsole/-/commit/1ee8c64b5189d9e32ae9660308b2edc0f35ea6f0 As to what the proper regex should be, the syntax for URIs is specified at https://datatracker.ietf.org/doc/html/rfc3986#appendix-A, with augmented BNF rules as defined in https://datatracker.ietf.org/doc/html/rfc2234 I think 7 and 8 aren't that common (and it would complicate the regular expression used even more), so we can hopefully skip those ones. I've tried my hand at implementing rfc3986 (thanks for the link :)) at https://invent.kde.org/utilities/konsole/-/merge_requests/646 not 100% compliant, but close enough. *** Bug 453364 has been marked as a duplicate of this bug. *** *** Bug 453364 has been marked as a duplicate of this bug. *** In Bug 453364 I reported issue where in url is present comma. And this case has not been mentioned here. (In reply to Piotr Mierzwinski from comment #6) > In Bug 453364 I reported issue where in url is present comma. And this case > has not been mentioned here. The change in https://invent.kde.org/utilities/konsole/-/merge_requests/646 fixes the url-with-comma case too. *** Bug 453448 has been marked as a duplicate of this bug. *** *** Bug 454193 has been marked as a duplicate of this bug. *** Git commit 3b7e73f54e2b07e658152ff01964d7ef398616cd by Kurt Hindenburg, on behalf of Ahmad Samir. Committed on 28/05/2022 at 20:37. Pushed by hindenburg into branch 'master'. UrlFilter::FullUrlRegExp matches more valid urls Add unittest. This is based on: https://datatracker.ietf.org/doc/html/rfc3986 FIXED-IN: 22.08 M +5 -0 src/autotests/CMakeLists.txt A +46 -0 src/autotests/HotSpotFilterTest.cpp [License: GPL(v2.0+)] A +21 -0 src/autotests/HotSpotFilterTest.h [License: GPL(v2.0+)] M +45 -3 src/filterHotSpots/UrlFilter.cpp M +4 -1 src/filterHotSpots/UrlFilter.h https://invent.kde.org/utilities/konsole/commit/3b7e73f54e2b07e658152ff01964d7ef398616cd *** Bug 454957 has been marked as a duplicate of this bug. *** *** Bug 455018 has been marked as a duplicate of this bug. *** *** Bug 455806 has been marked as a duplicate of this bug. *** Git commit c8d8abd1b2b8e93cc38b3bedb1b63f69791e5882 by Ahmad Samir. Committed on 01/07/2022 at 15:33. Pushed by ahmadsamir into branch 'release/22.04'. UrlFilter::FullUrlRegExp matches more valid urls Add unittest. This is based on: https://datatracker.ietf.org/doc/html/rfc3986 FIXED-IN: 22.08 M +5 -0 src/autotests/CMakeLists.txt A +46 -0 src/autotests/HotSpotFilterTest.cpp [License: GPL(v2.0+)] A +21 -0 src/autotests/HotSpotFilterTest.h [License: GPL(v2.0+)] M +45 -3 src/filterHotSpots/UrlFilter.cpp M +4 -1 src/filterHotSpots/UrlFilter.h https://invent.kde.org/utilities/konsole/commit/c8d8abd1b2b8e93cc38b3bedb1b63f69791e5882 *** Bug 456253 has been marked as a duplicate of this bug. *** *** Bug 458991 has been marked as a duplicate of this bug. *** |