Bug 408313

Summary: Kickoff switches to "Applications" tab upon opening if "Places" tab was visible last time it was closed
Product: [Plasma] plasmashell Reporter: Alexander Shchadilov <alexander.shchadilov>
Component: Application Launcher (Kickoff) widgetAssignee: David Edmundson <kde>
Status: RESOLVED FIXED    
Severity: normal CC: bugseforuns, kde, kdeu, mikel5764, nate, plasma-bugs
Priority: NOR    
Version: 5.20.90   
Target Milestone: 1.0   
Platform: Arch Linux   
OS: Linux   
Latest Commit: Version Fixed In: 5.23
Sentry Crash Report:
Attachments: Video of described steps

Description Alexander Shchadilov 2019-06-04 19:26:04 UTC
Created attachment 120577 [details]
Video of described steps

SUMMARY
I describe the behaviour of application launcher which has more than one tab configured (i.e. default set of tabs). Closing launcher with any tab other than the first (left) selected makes launcher show animation of switching tabs when it is reopened. After that, the first (left) tab stays opened.

STEPS TO REPRODUCE
1. If needed: configure application launcher so that it has more than one tab.
2. Open application launcher.
3. Choose any tab except the first (left).
4. Close launcher clicking somewhere else on your desktop.
5. Open application launcher.

OBSERVED RESULT
Last used tab is opened, then launcher instantly switches to the first (left) tab.

EXPECTED RESULT
A first (left) tab is opened.

SOFTWARE/OS VERSIONS
Linux: openSUSE Leap 15.1
KDE Plasma Version: 5.12.8
KDE Frameworks Version: 5.55.0
Qt Version: 5.9.7

ADDITIONAL INFORMATION

I assume that this happens in some systems but others open first tab instantly. If it is expected behaviour that just goes unnoticed on fast-performing setups I wish this bug report will become a request (severity "wishlist").
Comment 1 Nate Graham 2019-06-05 14:33:00 UTC
This was fixed in a later version of Plasma. You're using an older version: 5.12.8. For comparison, 5.16.0 is being released in a few days.
Comment 2 Alexander Shchadilov 2019-06-05 15:15:49 UTC
(In reply to Nate Graham from comment #1)
> This was fixed in a later version of Plasma. You're using an older version:
> 5.12.8. For comparison, 5.16.0 is being released in a few days.

Thank you for the reply. This Youtube video of 5.16 beta gave me an impression that this bug might not be addressed yet (animation visible at 6:03):
https://www.youtube.com/watch?v=g6R1d8uCK10&feature=youtu.be&t=363
For now I will assume that it was fixed during 5.16 testing.
Comment 3 Nate Graham 2019-06-05 16:46:14 UTC
Feel free to re-open once you're using 5.16 if you still see it. I am and I don't, FWIW.
Comment 4 Patrick Silva 2019-07-18 14:29:44 UTC
This behavior is still happening at least on Wayland session.

Operating System: Arch Linux 
KDE Plasma Version: 5.16.3
KDE Frameworks Version: 5.60.0
Qt Version: 5.13.0
Comment 5 Alexander Shchadilov 2019-10-23 18:40:11 UTC
Original poster here.. I was able to reproduce it in VM with recent Plasma acquired through openSUSE experimental repository for Leap 15.1.
https://en.opensuse.org/SDB:KDE_repositories#KDE_Frameworks_5.2C_Plasma_5_and_Applications

Linux: openSUSE Leap 15.1
KDE Plasma Version: 5.17.1
KDE Frameworks Version: 5.63.0
Qt Version: 5.13.1
Comment 6 Alexander Shchadilov 2020-07-12 14:43:37 UTC
It's not a big deal, of course, but I will update this as it looks the same with Plasma 5.18.5 LTS installed in my system.

Linux: openSUSE Leap 15.2
KDE Plasma Version: 5.18.5
KDE Frameworks Version: 5.71.0
Qt Version: 5.12.7
Comment 7 Patrick Silva 2020-08-31 16:36:18 UTC
*** Bug 426016 has been marked as a duplicate of this bug. ***
Comment 8 Lukas Ba. 2020-09-01 08:43:59 UTC
(In reply to Nate Graham from comment #1)
> This was fixed in a later version of Plasma. You're using an older version:
> 5.12.8. For comparison, 5.16.0 is being released in a few days.

Still an issue for me with these versions

SOFTWARE/OS VERSIONS
Operating System: Arch Linux
KDE Plasma Version: 5.19.4
KDE Frameworks Version: 5.73.0
Qt Version: 5.15.0
Kernel Version: 5.8.3-arch1-1
OS Type: 64-bit
Comment 9 Nate Graham 2020-09-01 18:53:12 UTC
I can now reproduce too.
Comment 10 Nate Graham 2021-01-07 15:43:18 UTC
Git commit 59985c6ed75ac9d63aa92785f913fb6943671f03 by Nate Graham, on behalf of Mikel Johnson.
Committed on 07/01/2021 at 15:41.
Pushed by ngraham into branch 'master'.

Kickoff redesign

This commit completely overhauls Kickoff's user interface!

Original design (UI/UX) discussion
----------------------------------
- https://phabricator.kde.org/T12192
- https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/186

Features / issues
-----------------
New:
- Double pane UI
- Both keyboard and mouse navigation have been overhauled
- Power/Session actions are available in the footer
- Improved RTL support
- Grid view
- All applications view
- Accessibility

Screenshots / Videos
--------------------
Apps

![image](/uploads/b44c0e36d7687b22f9df563ed19aad19/image.png)

Places

![image](/uploads/93ad74bd8e037dc70d4927eb20a8ec29/image.png)

Search

![image](/uploads/f77da9df55bd1f9e75c0b0de96eebfd8/image.png)

Accessibility

https://youtu.be/Vqah3yL5h_E

Bugs fixed
----------
Related: bug 357379, bug 369159, bug 369405, bug 378815, bug 387510, bug 387797, bug 391383, bug 392005, bug 393401, bug 394924, bug 398234, bug 398279, bug 398349, bug 398350, bug 398352, bug 398353, bug 405674, bug 410018, bug 412090, bug 415392, bug 416423, bug 419169, bug 423160, bug 425970, bug 426329, bug 427846, bug 428297

FIXED-IN: 5.21

@teams/vdg

A  +7    -0    applets/kickoff/ABOUT DESIGN CHANGES
D  +0    -71   applets/kickoff/DESIGN-GOALS
M  +6    -6    applets/kickoff/package/contents/config/config.qml
M  +45   -39   applets/kickoff/package/contents/config/main.xml
M  +9    -16   applets/kickoff/package/contents/ui/ActionMenu.qml
A  +144  -0    applets/kickoff/package/contents/ui/ApplicationsGroupView.qml     [License: GPL (v2+)]
M  +128  -46   applets/kickoff/package/contents/ui/ApplicationsView.qml
M  +12   -12   applets/kickoff/package/contents/ui/BaseView.qml
M  +13   -5    applets/kickoff/package/contents/ui/Breadcrumb.qml
M  +0    -2    applets/kickoff/package/contents/ui/ComputerView.qml
D  +0    -227  applets/kickoff/package/contents/ui/ConfigButtons.qml
M  +72   -18   applets/kickoff/package/contents/ui/ConfigGeneral.qml
C  +29   -43   applets/kickoff/package/contents/ui/FavoritesGridView.qml [from: applets/kickoff/package/contents/ui/FavoritesView.qml - 061% similarity]
M  +14   -24   applets/kickoff/package/contents/ui/FavoritesView.qml
R  +2    -3    applets/kickoff/package/contents/ui/FrequentlyUsedView.qml [from: applets/kickoff/package/contents/ui/OftenUsedView.qml - 089% similarity]
M  +599  -451  applets/kickoff/package/contents/ui/FullRepresentation.qml
M  +117  -64   applets/kickoff/package/contents/ui/Header.qml
M  +8    -9    applets/kickoff/package/contents/ui/Kickoff.qml
D  +0    -67   applets/kickoff/package/contents/ui/KickoffButton.qml
D  +0    -60   applets/kickoff/package/contents/ui/KickoffConfigurationButton.qml
A  +106  -0    applets/kickoff/package/contents/ui/KickoffGridItem.qml     [License: GPL (v2+)]
A  +345  -0    applets/kickoff/package/contents/ui/KickoffGridView.qml     [License: GPL (v2+)]
D  +0    -31   applets/kickoff/package/contents/ui/KickoffHighlight.qml
M  +45   -40   applets/kickoff/package/contents/ui/KickoffItem.qml
M  +184  -26   applets/kickoff/package/contents/ui/KickoffListView.qml
A  +145  -0    applets/kickoff/package/contents/ui/LeaveButtons.qml     [License: GPL (v2+)]
R  +13   -11   applets/kickoff/package/contents/ui/PlacesView.qml [from: applets/kickoff/package/contents/ui/LeaveView.qml - 065% similarity]
M  +0    -1    applets/kickoff/package/contents/ui/RecentlyUsedView.qml
M  +25   -13   applets/kickoff/package/contents/ui/SearchView.qml
M  +4    -2    applets/kickoff/package/contents/ui/SectionDelegate.qml
M  +2    -2    applets/kickoff/package/contents/ui/code/tools.js
M  +3    -3    applets/kickoff/package/metadata.desktop

https://invent.kde.org/plasma/plasma-desktop/commit/59985c6ed75ac9d63aa92785f913fb6943671f03
Comment 11 Patrick Silva 2021-01-24 15:12:38 UTC
This behavior persists with  the new Kickoff.

open Kickoff
click on "Places" on bottom
close Kickoff
re-open Kickoff

We can notice Kickoff switching between Places and Favorites on opening.
Comment 12 Mikel Johnson 2021-01-25 07:26:52 UTC
this is intended behavior (that's how every launcher does this too)
Comment 13 Patrick Silva 2021-01-25 10:11:30 UTC
What is the purpose of this annoying behavior?
Comment 14 Mikel Johnson 2021-01-25 11:02:52 UTC
tbh idk

but this isn't a bug

however you can propose to change the behavior (for all launchers) by creating a task at phabricator.kde.org
Comment 15 Nate Graham 2021-01-25 15:21:25 UTC
> tbh idk
> 
> but this isn't a bug
If users report annoyances that serve no clear purpose, that means it's a bug. :) Re-opening.
Comment 16 Mikel Johnson 2021-01-25 17:13:35 UTC
yeah but needs patches for other launchers as well (that's something to note) otherwise the behavior won't be consistent (tldr if you do a patch do it for all launchers, should be easy since they're all in the same repo)
Comment 17 Nate Graham 2021-01-25 18:26:17 UTC
What other launchers are you talking about? Kicker and Application Dashboard don't have tabs in the same way and are not affected by this issue.
Comment 18 Mikel Johnson 2021-01-25 19:23:27 UTC
Dashboard does though

the set up is really close if you think about (both have two page with category sidebar)

anyway I guess if more people complain it'll be fine to change
Comment 19 Nate Graham 2021-01-25 19:27:01 UTC
I don't see the issue with the dashboard.

Regardless, if it's an issue there, we should fix it there too. But not having already fixed it there shouldn't block fixing it here. :) How do you eat an elephant? One bite at a time.
Comment 20 Mikel Johnson 2021-01-25 19:30:44 UTC
fair

though I'm a bit afraid that more people actually prefer the way it is however that can probably be worked out when there's an actual MR people can look at
Comment 21 Alexander Shchadilov 2021-01-27 11:12:22 UTC
Is it possible that there was some misunderstanding because of the title I made? A better version would be: "Animation of switching tabs is seen when Kickoff is activated". Just to make clear that starting with the first tab is not a problem itself; only waiting for the animation is an unexpected part.
Comment 22 Lukas Ba. 2021-02-16 00:08:32 UTC
(In reply to Alexander Shchadilov from comment #21)
> Is it possible that there was some misunderstanding because of the title I
> made? A better version would be: "Animation of switching tabs is seen when
> Kickoff is activated". Just to make clear that starting with the first tab
> is not a problem itself; only waiting for the animation is an unexpected
> part.

^this
Comment 23 Nate Graham 2021-02-19 16:53:39 UTC
*** Bug 433201 has been marked as a duplicate of this bug. ***
Comment 24 Noah Davis 2021-07-19 06:56:36 UTC
Git commit 9d9c4f169ed424e976636a6d5fa23c7a1e40576b by Noah Davis.
Committed on 19/07/2021 at 06:47.
Pushed by ndavis into branch 'master'.

Kickoff: Refactor and tweak design

Changes:

- Now uses implicit content size to set the size of the plasmoid, which
fixes translated string elision issues.
- Much simpler code. This is a red patch.
- Reduced RAM usage. Pages that are not in use are unloaded. The models
aren't unloaded, so it shouldn't negatively affect performance in other
ways.
- Vertical movement and opacity animation when switching from normal
page to search view.
- Single horizontal movement and opacity animation when switching from
applications page to places page.
- Opacity animation when switching from favorites grid to apps list.
- KickoffListView and KickoffGridView now support PageUp, PageDown,
Home, End, Ctrl+Home and Ctrl+End shortcuts like lists and grids do on
the web. See https://www.w3.org/TR/wai-aria-practices-1.2/#grid
- KickoffListView/KickoffGridView keyboard navigation disables hovering
to change current item for 100ms. It's meant to filter out accidental
mouse movement while using the arrow keys to navigate.
- Add Ctrl+F shortcut to focus search bar
- Focus the next item down when pressing down while the search bar is
focused instead of focusing the 1st item. The old kickoff did this and
made it faster to select and activate items.
- Hovering near the bottom/top of a view no longer rapidly selects a
series of new items lower down/higher up that are not yet visible.
- Single letter section headers are now horizontally center aligned with
icons.
- Scroll to switch tabs.
- Added pin button to keep the launcher open.
- Show tooltips for list/grid items that have elided text.
- Padding and spacing are more uniform.
- List items have better vertical pixel alignment.
- Fixed pixel alignment of arrows in sidebar category items
- Sidebar list items line up with main content area list items and
section headers
- Labels in grid items now have consistent vertical positions.
- Fixed error in tools.js with favoriteModel.enabled
Related: bug 433103, bug 432270, bug 439140, bug 434736, bug 431913, bug 433146, bug 433241

FIXED-IN: 5.23

M  +7    -3    applets/kickoff/package/contents/config/main.xml
M  +55   -97   applets/kickoff/package/contents/ui/ActionMenu.qml
D  +0    -142  applets/kickoff/package/contents/ui/ApplicationsGroupView.qml
A  +140  -0    applets/kickoff/package/contents/ui/ApplicationsPage.qml     [License: LGPL(v2.0+)]
D  +0    -358  applets/kickoff/package/contents/ui/ApplicationsView.qml
A  +88   -0    applets/kickoff/package/contents/ui/BasePage.qml     [License: GPL (v2+)]
D  +0    -55   applets/kickoff/package/contents/ui/BaseView.qml
D  +0    -70   applets/kickoff/package/contents/ui/Breadcrumb.qml
D  +0    -41   applets/kickoff/package/contents/ui/ComputerView.qml
M  +31   -11   applets/kickoff/package/contents/ui/ConfigGeneral.qml
A  +30   -0    applets/kickoff/package/contents/ui/EmptyPage.qml     [License: LGPL(v2.0+)]
D  +0    -129  applets/kickoff/package/contents/ui/FavoritesGridView.qml
D  +0    -133  applets/kickoff/package/contents/ui/FavoritesView.qml
A  +193  -0    applets/kickoff/package/contents/ui/Footer.qml     [License: GPL (v2+)]
D  +0    -20   applets/kickoff/package/contents/ui/FrequentlyUsedView.qml
M  +119  -736  applets/kickoff/package/contents/ui/FullRepresentation.qml
M  +186  -146  applets/kickoff/package/contents/ui/Header.qml
A  +59   -0    applets/kickoff/package/contents/ui/HorizontalStackView.qml     [License: LGPL(v2.0+)]
M  +53   -27   applets/kickoff/package/contents/ui/Kickoff.qml
D  +0    -93   applets/kickoff/package/contents/ui/KickoffGridItem.qml
M  +200  -288  applets/kickoff/package/contents/ui/KickoffGridView.qml
D  +0    -175  applets/kickoff/package/contents/ui/KickoffItem.qml
A  +227  -0    applets/kickoff/package/contents/ui/KickoffItemDelegate.qml     [License: GPL (v2+)]
M  +211  -288  applets/kickoff/package/contents/ui/KickoffListView.qml
A  +137  -0    applets/kickoff/package/contents/ui/KickoffSingleton.qml     [License: LGPL(v2.0+)]
M  +43   -104  applets/kickoff/package/contents/ui/LeaveButtons.qml
A  +53   -0    applets/kickoff/package/contents/ui/NormalPage.qml     [License: LGPL(v2.0+)]
A  +76   -0    applets/kickoff/package/contents/ui/PlacesPage.qml     [License: LGPL(v2.0+)]
D  +0    -22   applets/kickoff/package/contents/ui/PlacesView.qml
D  +0    -18   applets/kickoff/package/contents/ui/RecentlyUsedView.qml
D  +0    -87   applets/kickoff/package/contents/ui/SearchView.qml
D  +0    -42   applets/kickoff/package/contents/ui/SectionDelegate.qml
A  +61   -0    applets/kickoff/package/contents/ui/VerticalStackView.qml     [License: LGPL(v2.0+)]
M  +1    -1    applets/kickoff/package/contents/ui/code/tools.js
A  +2    -0    applets/kickoff/package/contents/ui/qmldir

https://invent.kde.org/plasma/plasma-desktop/commit/9d9c4f169ed424e976636a6d5fa23c7a1e40576b