Bug 433103 - New Plasma 5.21 Kickoff elides power strings, especially when Hibernation is enabled and using non-English languages
Summary: New Plasma 5.21 Kickoff elides power strings, especially when Hibernation is ...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Application Launcher (Kickoff) widget (show other bugs)
Version: 5.21.0
Platform: openSUSE Linux
: VHI normal
Target Milestone: 1.0
Assignee: David Edmundson
URL:
Keywords: regression
: 433106 433235 433612 435759 436326 438726 441034 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-02-17 18:37 UTC by kde
Modified: 2021-12-07 10:29 UTC (History)
13 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.23
Sentry Crash Report:


Attachments
screenshot (192.09 KB, image/png)
2021-02-17 18:37 UTC, kde
Details
screenshot_plasma_5.21.0_archlinux (125.98 KB, image/png)
2021-02-17 19:16 UTC, Yannick
Details

Note You need to log in before you can comment on or make changes to this bug.
Description kde 2021-02-17 18:37:56 UTC
Created attachment 135781 [details]
screenshot

Operating System: openSUSE Tumbleweed 20210215
KDE Plasma Version: 5.21.0
KDE Frameworks Version: 5.78.0
Qt Version: 5.15.2
Kernel Version: 5.10.16-1-default
OS Type: 64-bit
Graphics Platform: X11

I'm using a 1920x1080 screen with default scaling/dpi on this machine.

The new start menu in Plasma 5.21 looks good, but it's too small to accomodate the content which looks bad.

* Text on the top right is cut off.
* Categories on the left also don't fit inside the window so you always have to scroll.

As it is now, it looks very cramped.
It would be great if the start menu window size could be adjusted to fit the contents.
Comment 1 Yannick 2021-02-17 19:15:30 UTC
Same issue on Archlinux with Plasma 5.21.0.

In attachment, a screenshot in which the insufficient horizontal space is quite visible. I use the Ubuntu fonts, but with the Noto Sans fonts there is a bit more horizontal space.
Comment 2 Yannick 2021-02-17 19:16:46 UTC
Created attachment 135784 [details]
screenshot_plasma_5.21.0_archlinux
Comment 3 kde 2021-02-17 19:23:19 UTC
Seems like your bar with power actions at least has all (?) text written out, because you're not using suspend-to-disk.
The spacing between buttons looks random though, compare the space between the left two and the right two actions.

Do you know why your top and bottom bars are swapped compared to mine? Is that a setting somewhere?
Comment 4 Yannick 2021-02-17 19:28:38 UTC
Indeed, the spacing between buttons is inconsistent.
I guess the reason why the top and bottom bars are swapped compared to yours is because my panel is on the bottom of the screen, and yours is probably on top?
Comment 5 kde 2021-02-17 19:31:13 UTC
Yes, my bar is on the left with the launcher button on the top left.
Comment 6 Nate Graham 2021-02-17 23:04:35 UTC
Yeah, we've gotten a lot of complaints about this from the perspective of people with non-English languages and Hibernation enabled, since it results in the power actions getting elided into gibberish. I quite agree that overall the whole thing is pretty cramped too. I think it could stand to be about 10% bigger.

Let's use this bug report to track just the elided power action text issue, and I'd like to ask people to file additional bug reports for other issues. They will all need to be fixed separately.
Comment 7 Nate Graham 2021-02-17 23:25:31 UTC
*** Bug 433106 has been marked as a duplicate of this bug. ***
Comment 8 Bug Janitor Service 2021-02-18 09:23:31 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/356
Comment 9 Mikel Johnson 2021-02-19 12:45:30 UTC
*** Bug 433235 has been marked as a duplicate of this bug. ***
Comment 10 Nate Graham 2021-02-25 20:32:22 UTC
*** Bug 433612 has been marked as a duplicate of this bug. ***
Comment 11 Nate Graham 2021-04-15 15:57:34 UTC
*** Bug 435759 has been marked as a duplicate of this bug. ***
Comment 12 Nate Graham 2021-04-15 15:59:01 UTC
We're working on this. See https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/420
Comment 13 Nate Graham 2021-04-30 15:55:53 UTC
*** Bug 436326 has been marked as a duplicate of this bug. ***
Comment 14 Nate Graham 2021-06-16 16:42:36 UTC
*** Bug 438726 has been marked as a duplicate of this bug. ***
Comment 15 Noah Davis 2021-07-19 06:55:47 UTC
Git commit 9d9c4f169ed424e976636a6d5fa23c7a1e40576b by Noah Davis.
Committed on 19/07/2021 at 06:47.
Pushed by ndavis into branch 'master'.

Kickoff: Refactor and tweak design

Changes:

- Now uses implicit content size to set the size of the plasmoid, which
fixes translated string elision issues.
- Much simpler code. This is a red patch.
- Reduced RAM usage. Pages that are not in use are unloaded. The models
aren't unloaded, so it shouldn't negatively affect performance in other
ways.
- Vertical movement and opacity animation when switching from normal
page to search view.
- Single horizontal movement and opacity animation when switching from
applications page to places page.
- Opacity animation when switching from favorites grid to apps list.
- KickoffListView and KickoffGridView now support PageUp, PageDown,
Home, End, Ctrl+Home and Ctrl+End shortcuts like lists and grids do on
the web. See https://www.w3.org/TR/wai-aria-practices-1.2/#grid
- KickoffListView/KickoffGridView keyboard navigation disables hovering
to change current item for 100ms. It's meant to filter out accidental
mouse movement while using the arrow keys to navigate.
- Add Ctrl+F shortcut to focus search bar
- Focus the next item down when pressing down while the search bar is
focused instead of focusing the 1st item. The old kickoff did this and
made it faster to select and activate items.
- Hovering near the bottom/top of a view no longer rapidly selects a
series of new items lower down/higher up that are not yet visible.
- Single letter section headers are now horizontally center aligned with
icons.
- Scroll to switch tabs.
- Added pin button to keep the launcher open.
- Show tooltips for list/grid items that have elided text.
- Padding and spacing are more uniform.
- List items have better vertical pixel alignment.
- Fixed pixel alignment of arrows in sidebar category items
- Sidebar list items line up with main content area list items and
section headers
- Labels in grid items now have consistent vertical positions.
- Fixed error in tools.js with favoriteModel.enabled
Related: bug 432270, bug 439140, bug 434736, bug 431913, bug 433146, bug 433241, bug 408313

FIXED-IN: 5.23

M  +7    -3    applets/kickoff/package/contents/config/main.xml
M  +55   -97   applets/kickoff/package/contents/ui/ActionMenu.qml
D  +0    -142  applets/kickoff/package/contents/ui/ApplicationsGroupView.qml
A  +140  -0    applets/kickoff/package/contents/ui/ApplicationsPage.qml     [License: LGPL(v2.0+)]
D  +0    -358  applets/kickoff/package/contents/ui/ApplicationsView.qml
A  +88   -0    applets/kickoff/package/contents/ui/BasePage.qml     [License: GPL (v2+)]
D  +0    -55   applets/kickoff/package/contents/ui/BaseView.qml
D  +0    -70   applets/kickoff/package/contents/ui/Breadcrumb.qml
D  +0    -41   applets/kickoff/package/contents/ui/ComputerView.qml
M  +31   -11   applets/kickoff/package/contents/ui/ConfigGeneral.qml
A  +30   -0    applets/kickoff/package/contents/ui/EmptyPage.qml     [License: LGPL(v2.0+)]
D  +0    -129  applets/kickoff/package/contents/ui/FavoritesGridView.qml
D  +0    -133  applets/kickoff/package/contents/ui/FavoritesView.qml
A  +193  -0    applets/kickoff/package/contents/ui/Footer.qml     [License: GPL (v2+)]
D  +0    -20   applets/kickoff/package/contents/ui/FrequentlyUsedView.qml
M  +119  -736  applets/kickoff/package/contents/ui/FullRepresentation.qml
M  +186  -146  applets/kickoff/package/contents/ui/Header.qml
A  +59   -0    applets/kickoff/package/contents/ui/HorizontalStackView.qml     [License: LGPL(v2.0+)]
M  +53   -27   applets/kickoff/package/contents/ui/Kickoff.qml
D  +0    -93   applets/kickoff/package/contents/ui/KickoffGridItem.qml
M  +200  -288  applets/kickoff/package/contents/ui/KickoffGridView.qml
D  +0    -175  applets/kickoff/package/contents/ui/KickoffItem.qml
A  +227  -0    applets/kickoff/package/contents/ui/KickoffItemDelegate.qml     [License: GPL (v2+)]
M  +211  -288  applets/kickoff/package/contents/ui/KickoffListView.qml
A  +137  -0    applets/kickoff/package/contents/ui/KickoffSingleton.qml     [License: LGPL(v2.0+)]
M  +43   -104  applets/kickoff/package/contents/ui/LeaveButtons.qml
A  +53   -0    applets/kickoff/package/contents/ui/NormalPage.qml     [License: LGPL(v2.0+)]
A  +76   -0    applets/kickoff/package/contents/ui/PlacesPage.qml     [License: LGPL(v2.0+)]
D  +0    -22   applets/kickoff/package/contents/ui/PlacesView.qml
D  +0    -18   applets/kickoff/package/contents/ui/RecentlyUsedView.qml
D  +0    -87   applets/kickoff/package/contents/ui/SearchView.qml
D  +0    -42   applets/kickoff/package/contents/ui/SectionDelegate.qml
A  +61   -0    applets/kickoff/package/contents/ui/VerticalStackView.qml     [License: LGPL(v2.0+)]
M  +1    -1    applets/kickoff/package/contents/ui/code/tools.js
A  +2    -0    applets/kickoff/package/contents/ui/qmldir

https://invent.kde.org/plasma/plasma-desktop/commit/9d9c4f169ed424e976636a6d5fa23c7a1e40576b
Comment 16 Nate Graham 2021-08-16 18:08:53 UTC
*** Bug 441034 has been marked as a duplicate of this bug. ***