Bug 431913 - Elided sidebar text in Brazillian Portuguese with new kickoff replacement
Summary: Elided sidebar text in Brazillian Portuguese with new kickoff replacement
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Application Launcher (Kickoff) widget (show other bugs)
Version: master
Platform: Other Other
: HI normal
Target Milestone: 1.0
Assignee: David Edmundson
URL:
Keywords: regression
: 439580 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-01-22 04:17 UTC by guimarcalsilva
Modified: 2021-07-23 15:48 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.23
Sentry Crash Report:


Attachments
All apps (562.15 KB, image/png)
2021-01-22 04:17 UTC, guimarcalsilva
Details
Used frequently (552.35 KB, image/png)
2021-01-22 04:18 UTC, guimarcalsilva
Details
Plasma 5.22 (72.23 KB, image/png)
2021-06-11 03:36 UTC, guimarcalsilva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description guimarcalsilva 2021-01-22 04:17:55 UTC
Created attachment 135048 [details]
All apps

SUMMARY

I'm testing the latest Plasma 5.21 in Neon Unstable, and I've noticed some category labels are elided in the new menu. I think it should probably be wider than it is now to accomodate longer text.

I've attached some screenshots.

(I'm reporting this here under Kickoff since it appears there's no option to report bugs about the new menu. Is it still called Kickoff?)

STEPS TO REPRODUCE
1. Set language to pt_BR
2. Open new menu

OBSERVED RESULT

Text like "Todos os Aplicativos" (All Applications) and "Usados Frequentemente" (Used Frequently) are elided.

EXPECTED RESULT

There should be enough space to show all the text in any language.

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.21.80
KDE Frameworks Version: 5.79.0
Qt Version: 5.15.2
Kernel Version: 5.4.0-64-generic
OS Type: 64-bit
Processors: 4 × Intel® Core™ i5-9400F CPU @ 2.90GHz
Memory: 3.8 GiB of RAM
Graphics Processor: SVGA3D; build: RELEASE; LLVM;

ADDITIONAL INFORMATION

Tested on a VM.
Comment 1 guimarcalsilva 2021-01-22 04:18:27 UTC
Created attachment 135049 [details]
Used frequently
Comment 2 David Redondo 2021-01-22 07:38:45 UTC
At least for the applications view alternatively we ccould just always use a shorter string. i18n("All") instead of i18n("All Applications")?
Comment 3 Nate Graham 2021-01-22 15:19:12 UTC
Confirmed.

Not sure if we can dynamically increase the width of the sidebar, so maybe the simplest solution is simply to increase the hardcoded width by a tiny bit. Generally, Brazilian Portuguese has the longest strings, so we fix elision for that language, it will be fixed for other ones too.
Comment 4 guimarcalsilva 2021-01-22 19:52:51 UTC
(In reply to Nate Graham from comment #3)
> Confirmed.
> 
> Not sure if we can dynamically increase the width of the sidebar, so maybe
> the simplest solution is simply to increase the hardcoded width by a tiny
> bit. Generally, Brazilian Portuguese has the longest strings, so we fix
> elision for that language, it will be fixed for other ones too.

I think this solution is the best one, and not only that but it would also help with longer usernames too.
Comment 5 Mikel Johnson 2021-01-22 20:02:32 UTC
This is probably 5.22 material as it's a pretty significant change
Comment 6 Nate Graham 2021-01-22 20:35:18 UTC
Widening the sidebar by 20px is a significant change?
Comment 7 Mikel Johnson 2021-01-22 21:23:12 UTC
that 20 came out of nowhere but I guess you can submit a patch and the rest of VDG will figure this out (still consider that this value might not work)
Comment 8 Mikel Johnson 2021-01-22 21:26:10 UTC
this will probably create quite a bit of bikeshedding (hence pretty significant change)
Comment 9 Bug Janitor Service 2021-01-23 03:03:28 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/321
Comment 10 David Redondo 2021-01-23 08:53:58 UTC
(In reply to Mikel Johnson from comment #8)
> this will probably create quite a bit of bikeshedding (hence pretty
> significant change)

I would not classify the impact of changes by the amount bikeshedding it generates ;)
Comment 11 Mikel Johnson 2021-01-23 09:02:41 UTC
tbf it was bad wording more than anything
Comment 12 Bug Janitor Service 2021-02-18 09:23:32 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/356
Comment 13 guimarcalsilva 2021-06-11 03:35:26 UTC
I just want to update the situation on Plasma 5.22. Now only a single string is elided, not two as before. If you look at the new screenshot, it appears there's plenty of space to fit the entirety of the last word there (frequentemente).
Comment 14 guimarcalsilva 2021-06-11 03:36:04 UTC
Created attachment 139216 [details]
Plasma 5.22

New screenshot - Plasma 5.22
Comment 15 Noah Davis 2021-07-19 06:56:20 UTC
Git commit 9d9c4f169ed424e976636a6d5fa23c7a1e40576b by Noah Davis.
Committed on 19/07/2021 at 06:47.
Pushed by ndavis into branch 'master'.

Kickoff: Refactor and tweak design

Changes:

- Now uses implicit content size to set the size of the plasmoid, which
fixes translated string elision issues.
- Much simpler code. This is a red patch.
- Reduced RAM usage. Pages that are not in use are unloaded. The models
aren't unloaded, so it shouldn't negatively affect performance in other
ways.
- Vertical movement and opacity animation when switching from normal
page to search view.
- Single horizontal movement and opacity animation when switching from
applications page to places page.
- Opacity animation when switching from favorites grid to apps list.
- KickoffListView and KickoffGridView now support PageUp, PageDown,
Home, End, Ctrl+Home and Ctrl+End shortcuts like lists and grids do on
the web. See https://www.w3.org/TR/wai-aria-practices-1.2/#grid
- KickoffListView/KickoffGridView keyboard navigation disables hovering
to change current item for 100ms. It's meant to filter out accidental
mouse movement while using the arrow keys to navigate.
- Add Ctrl+F shortcut to focus search bar
- Focus the next item down when pressing down while the search bar is
focused instead of focusing the 1st item. The old kickoff did this and
made it faster to select and activate items.
- Hovering near the bottom/top of a view no longer rapidly selects a
series of new items lower down/higher up that are not yet visible.
- Single letter section headers are now horizontally center aligned with
icons.
- Scroll to switch tabs.
- Added pin button to keep the launcher open.
- Show tooltips for list/grid items that have elided text.
- Padding and spacing are more uniform.
- List items have better vertical pixel alignment.
- Fixed pixel alignment of arrows in sidebar category items
- Sidebar list items line up with main content area list items and
section headers
- Labels in grid items now have consistent vertical positions.
- Fixed error in tools.js with favoriteModel.enabled
Related: bug 433103, bug 432270, bug 439140, bug 434736, bug 433146, bug 433241, bug 408313

FIXED-IN: 5.23

M  +7    -3    applets/kickoff/package/contents/config/main.xml
M  +55   -97   applets/kickoff/package/contents/ui/ActionMenu.qml
D  +0    -142  applets/kickoff/package/contents/ui/ApplicationsGroupView.qml
A  +140  -0    applets/kickoff/package/contents/ui/ApplicationsPage.qml     [License: LGPL(v2.0+)]
D  +0    -358  applets/kickoff/package/contents/ui/ApplicationsView.qml
A  +88   -0    applets/kickoff/package/contents/ui/BasePage.qml     [License: GPL (v2+)]
D  +0    -55   applets/kickoff/package/contents/ui/BaseView.qml
D  +0    -70   applets/kickoff/package/contents/ui/Breadcrumb.qml
D  +0    -41   applets/kickoff/package/contents/ui/ComputerView.qml
M  +31   -11   applets/kickoff/package/contents/ui/ConfigGeneral.qml
A  +30   -0    applets/kickoff/package/contents/ui/EmptyPage.qml     [License: LGPL(v2.0+)]
D  +0    -129  applets/kickoff/package/contents/ui/FavoritesGridView.qml
D  +0    -133  applets/kickoff/package/contents/ui/FavoritesView.qml
A  +193  -0    applets/kickoff/package/contents/ui/Footer.qml     [License: GPL (v2+)]
D  +0    -20   applets/kickoff/package/contents/ui/FrequentlyUsedView.qml
M  +119  -736  applets/kickoff/package/contents/ui/FullRepresentation.qml
M  +186  -146  applets/kickoff/package/contents/ui/Header.qml
A  +59   -0    applets/kickoff/package/contents/ui/HorizontalStackView.qml     [License: LGPL(v2.0+)]
M  +53   -27   applets/kickoff/package/contents/ui/Kickoff.qml
D  +0    -93   applets/kickoff/package/contents/ui/KickoffGridItem.qml
M  +200  -288  applets/kickoff/package/contents/ui/KickoffGridView.qml
D  +0    -175  applets/kickoff/package/contents/ui/KickoffItem.qml
A  +227  -0    applets/kickoff/package/contents/ui/KickoffItemDelegate.qml     [License: GPL (v2+)]
M  +211  -288  applets/kickoff/package/contents/ui/KickoffListView.qml
A  +137  -0    applets/kickoff/package/contents/ui/KickoffSingleton.qml     [License: LGPL(v2.0+)]
M  +43   -104  applets/kickoff/package/contents/ui/LeaveButtons.qml
A  +53   -0    applets/kickoff/package/contents/ui/NormalPage.qml     [License: LGPL(v2.0+)]
A  +76   -0    applets/kickoff/package/contents/ui/PlacesPage.qml     [License: LGPL(v2.0+)]
D  +0    -22   applets/kickoff/package/contents/ui/PlacesView.qml
D  +0    -18   applets/kickoff/package/contents/ui/RecentlyUsedView.qml
D  +0    -87   applets/kickoff/package/contents/ui/SearchView.qml
D  +0    -42   applets/kickoff/package/contents/ui/SectionDelegate.qml
A  +61   -0    applets/kickoff/package/contents/ui/VerticalStackView.qml     [License: LGPL(v2.0+)]
M  +1    -1    applets/kickoff/package/contents/ui/code/tools.js
A  +2    -0    applets/kickoff/package/contents/ui/qmldir

https://invent.kde.org/plasma/plasma-desktop/commit/9d9c4f169ed424e976636a6d5fa23c7a1e40576b
Comment 16 Nate Graham 2021-07-23 15:48:52 UTC
*** Bug 439580 has been marked as a duplicate of this bug. ***