Bug 393401 - Kickoff favorites should update with "Show applications by name"
Summary: Kickoff favorites should update with "Show applications by name"
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Application Launcher (Kickoff) widget (show other bugs)
Version: 5.12.4
Platform: unspecified Linux
: NOR normal
Target Milestone: 1.0
Assignee: David Edmundson
URL:
Keywords:
: 346601 357125 398359 399162 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-04-22 16:45 UTC by wazhai
Modified: 2021-01-07 15:42 UTC (History)
7 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.21
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description wazhai 2018-04-22 16:45:53 UTC
The favourites in Kickoff should switch their title and sub-title (e.g. Dolphin - File Manager) accordingly whenever the option "Show applications by name" is changed.

Currently, they remain unchanged, which can lead to a mix of both, and removing and re-adding a favourite is necessary to update it.
Comment 1 Alexander Mentyu 2018-09-07 07:16:48 UTC
Can reproduce

Distribution: KDE neon Developer Edition
Kernel: 4.15.0-29-generic
Plasma: 5.13.80
Apps: 18.11.70
Qt: 5.11.1
Frameworks: 5.50.0
Graphics:
Card-1: Intel driver: i915 v: kernel bus ID: 00:02.0 chip ID: 8086:5917 
Card-2: NVIDIA GM108M [GeForce 940MX] driver: nouveau v: kernel bus ID: 01:00.0 chip ID: 10de:134d 
Display: wayland server: X.Org 1.19.6 driver: modesetting,nouveau 
unloaded: fbdev,vesa alternate: nvidia compositor: kwin wayland 
resolution: 1920x1080~57Hz 
OpenGL: renderer: Mesa DRI Intel UHD Graphics 620 (Kabylake GT2) v: 4.5 Mesa 18.0.5 
compat-v: 3.0 direct render: Yes
Comment 2 Kai Uwe Broulik 2018-09-07 07:18:23 UTC
I can confirm the Favorites view does not update the setting at runtime, only when plasmashell is restarted
Comment 3 Kai Uwe Broulik 2018-09-07 07:28:04 UTC
An AppEntry gets this setting from the rootModel, however the KAStatsFavoritesModel doesn't signal a change when this setting is changed, hence it only updating on restart or when adding a new favorite.
Comment 4 Nate Graham 2018-09-13 17:31:37 UTC
*** Bug 398359 has been marked as a duplicate of this bug. ***
Comment 5 Patrick Silva 2018-09-27 22:44:59 UTC
*** Bug 399162 has been marked as a duplicate of this bug. ***
Comment 6 Nate Graham 2021-01-06 17:52:21 UTC
*** Bug 357125 has been marked as a duplicate of this bug. ***
Comment 7 Nate Graham 2021-01-06 17:52:22 UTC
*** Bug 346601 has been marked as a duplicate of this bug. ***
Comment 8 Nate Graham 2021-01-07 15:42:21 UTC
Git commit 59985c6ed75ac9d63aa92785f913fb6943671f03 by Nate Graham, on behalf of Mikel Johnson.
Committed on 07/01/2021 at 15:41.
Pushed by ngraham into branch 'master'.

Kickoff redesign

This commit completely overhauls Kickoff's user interface!

Original design (UI/UX) discussion
----------------------------------
- https://phabricator.kde.org/T12192
- https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/186

Features / issues
-----------------
New:
- Double pane UI
- Both keyboard and mouse navigation have been overhauled
- Power/Session actions are available in the footer
- Improved RTL support
- Grid view
- All applications view
- Accessibility

Screenshots / Videos
--------------------
Apps

![image](/uploads/b44c0e36d7687b22f9df563ed19aad19/image.png)

Places

![image](/uploads/93ad74bd8e037dc70d4927eb20a8ec29/image.png)

Search

![image](/uploads/f77da9df55bd1f9e75c0b0de96eebfd8/image.png)

Accessibility

https://youtu.be/Vqah3yL5h_E

Bugs fixed
----------
Related: bug 357379, bug 369159, bug 369405, bug 378815, bug 387510, bug 387797, bug 391383, bug 392005, bug 394924, bug 398234, bug 398279, bug 398349, bug 398350, bug 398352, bug 398353, bug 405674, bug 408313, bug 410018, bug 412090, bug 415392, bug 416423, bug 419169, bug 423160, bug 425970, bug 426329, bug 427846, bug 428297

FIXED-IN: 5.21

@teams/vdg

A  +7    -0    applets/kickoff/ABOUT DESIGN CHANGES
D  +0    -71   applets/kickoff/DESIGN-GOALS
M  +6    -6    applets/kickoff/package/contents/config/config.qml
M  +45   -39   applets/kickoff/package/contents/config/main.xml
M  +9    -16   applets/kickoff/package/contents/ui/ActionMenu.qml
A  +144  -0    applets/kickoff/package/contents/ui/ApplicationsGroupView.qml     [License: GPL (v2+)]
M  +128  -46   applets/kickoff/package/contents/ui/ApplicationsView.qml
M  +12   -12   applets/kickoff/package/contents/ui/BaseView.qml
M  +13   -5    applets/kickoff/package/contents/ui/Breadcrumb.qml
M  +0    -2    applets/kickoff/package/contents/ui/ComputerView.qml
D  +0    -227  applets/kickoff/package/contents/ui/ConfigButtons.qml
M  +72   -18   applets/kickoff/package/contents/ui/ConfigGeneral.qml
C  +29   -43   applets/kickoff/package/contents/ui/FavoritesGridView.qml [from: applets/kickoff/package/contents/ui/FavoritesView.qml - 061% similarity]
M  +14   -24   applets/kickoff/package/contents/ui/FavoritesView.qml
R  +2    -3    applets/kickoff/package/contents/ui/FrequentlyUsedView.qml [from: applets/kickoff/package/contents/ui/OftenUsedView.qml - 089% similarity]
M  +599  -451  applets/kickoff/package/contents/ui/FullRepresentation.qml
M  +117  -64   applets/kickoff/package/contents/ui/Header.qml
M  +8    -9    applets/kickoff/package/contents/ui/Kickoff.qml
D  +0    -67   applets/kickoff/package/contents/ui/KickoffButton.qml
D  +0    -60   applets/kickoff/package/contents/ui/KickoffConfigurationButton.qml
A  +106  -0    applets/kickoff/package/contents/ui/KickoffGridItem.qml     [License: GPL (v2+)]
A  +345  -0    applets/kickoff/package/contents/ui/KickoffGridView.qml     [License: GPL (v2+)]
D  +0    -31   applets/kickoff/package/contents/ui/KickoffHighlight.qml
M  +45   -40   applets/kickoff/package/contents/ui/KickoffItem.qml
M  +184  -26   applets/kickoff/package/contents/ui/KickoffListView.qml
A  +145  -0    applets/kickoff/package/contents/ui/LeaveButtons.qml     [License: GPL (v2+)]
R  +13   -11   applets/kickoff/package/contents/ui/PlacesView.qml [from: applets/kickoff/package/contents/ui/LeaveView.qml - 065% similarity]
M  +0    -1    applets/kickoff/package/contents/ui/RecentlyUsedView.qml
M  +25   -13   applets/kickoff/package/contents/ui/SearchView.qml
M  +4    -2    applets/kickoff/package/contents/ui/SectionDelegate.qml
M  +2    -2    applets/kickoff/package/contents/ui/code/tools.js
M  +3    -3    applets/kickoff/package/metadata.desktop

https://invent.kde.org/plasma/plasma-desktop/commit/59985c6ed75ac9d63aa92785f913fb6943671f03