Bug 433146 - Two-line grid item labels are closer to the icon than single-line labels are
Summary: Two-line grid item labels are closer to the icon than single-line labels are
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Application Launcher (Kickoff) (show other bugs)
Version: 5.21.0
Platform: Other Linux
: NOR minor
Target Milestone: 1.0
Assignee: David Edmundson
URL:
Keywords:
: 437985 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-02-18 09:25 UTC by Ilya Bizyaev
Modified: 2021-07-19 06:56 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.23


Attachments
1 (5.21 KB, image/png)
2021-02-18 09:30 UTC, Ilya Bizyaev
Details
2 (18.97 KB, image/png)
2021-02-18 09:30 UTC, Ilya Bizyaev
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Bizyaev 2021-02-18 09:25:46 UTC
SUMMARY
Unlike other icon grids in KDE apps (Dolphin, System Settings, Cuttlefish), new Kickoff grid's labels are aligned by vertical center instead of top. With some combinations of icons and labels, it makes the grid look disorganized.

SOFTWARE/OS VERSIONS
Operating System: openSUSE Leap 15.2
KDE Plasma Version: 5.21.0
KDE Frameworks Version: 5.79.0
Qt Version: 5.15.2

ADDITIONAL INFORMATION
See the attached screenshots.
Comment 1 Ilya Bizyaev 2021-02-18 09:30:11 UTC
Created attachment 135822 [details]
1
Comment 2 Ilya Bizyaev 2021-02-18 09:30:29 UTC
Created attachment 135823 [details]
2
Comment 3 Nate Graham 2021-02-18 15:15:53 UTC
I think this was done to avoid making the parent frame too tall. Maybe we can tweak it.
Comment 4 Patrick Silva 2021-06-03 00:14:53 UTC
*** Bug 437985 has been marked as a duplicate of this bug. ***
Comment 5 Noah Davis 2021-07-19 06:56:28 UTC
Git commit 9d9c4f169ed424e976636a6d5fa23c7a1e40576b by Noah Davis.
Committed on 19/07/2021 at 06:47.
Pushed by ndavis into branch 'master'.

Kickoff: Refactor and tweak design

Changes:

- Now uses implicit content size to set the size of the plasmoid, which
fixes translated string elision issues.
- Much simpler code. This is a red patch.
- Reduced RAM usage. Pages that are not in use are unloaded. The models
aren't unloaded, so it shouldn't negatively affect performance in other
ways.
- Vertical movement and opacity animation when switching from normal
page to search view.
- Single horizontal movement and opacity animation when switching from
applications page to places page.
- Opacity animation when switching from favorites grid to apps list.
- KickoffListView and KickoffGridView now support PageUp, PageDown,
Home, End, Ctrl+Home and Ctrl+End shortcuts like lists and grids do on
the web. See https://www.w3.org/TR/wai-aria-practices-1.2/#grid
- KickoffListView/KickoffGridView keyboard navigation disables hovering
to change current item for 100ms. It's meant to filter out accidental
mouse movement while using the arrow keys to navigate.
- Add Ctrl+F shortcut to focus search bar
- Focus the next item down when pressing down while the search bar is
focused instead of focusing the 1st item. The old kickoff did this and
made it faster to select and activate items.
- Hovering near the bottom/top of a view no longer rapidly selects a
series of new items lower down/higher up that are not yet visible.
- Single letter section headers are now horizontally center aligned with
icons.
- Scroll to switch tabs.
- Added pin button to keep the launcher open.
- Show tooltips for list/grid items that have elided text.
- Padding and spacing are more uniform.
- List items have better vertical pixel alignment.
- Fixed pixel alignment of arrows in sidebar category items
- Sidebar list items line up with main content area list items and
section headers
- Labels in grid items now have consistent vertical positions.
- Fixed error in tools.js with favoriteModel.enabled
Related: bug 433103, bug 432270, bug 439140, bug 434736, bug 431913, bug 433241, bug 408313

FIXED-IN: 5.23

M  +7    -3    applets/kickoff/package/contents/config/main.xml
M  +55   -97   applets/kickoff/package/contents/ui/ActionMenu.qml
D  +0    -142  applets/kickoff/package/contents/ui/ApplicationsGroupView.qml
A  +140  -0    applets/kickoff/package/contents/ui/ApplicationsPage.qml     [License: LGPL(v2.0+)]
D  +0    -358  applets/kickoff/package/contents/ui/ApplicationsView.qml
A  +88   -0    applets/kickoff/package/contents/ui/BasePage.qml     [License: GPL (v2+)]
D  +0    -55   applets/kickoff/package/contents/ui/BaseView.qml
D  +0    -70   applets/kickoff/package/contents/ui/Breadcrumb.qml
D  +0    -41   applets/kickoff/package/contents/ui/ComputerView.qml
M  +31   -11   applets/kickoff/package/contents/ui/ConfigGeneral.qml
A  +30   -0    applets/kickoff/package/contents/ui/EmptyPage.qml     [License: LGPL(v2.0+)]
D  +0    -129  applets/kickoff/package/contents/ui/FavoritesGridView.qml
D  +0    -133  applets/kickoff/package/contents/ui/FavoritesView.qml
A  +193  -0    applets/kickoff/package/contents/ui/Footer.qml     [License: GPL (v2+)]
D  +0    -20   applets/kickoff/package/contents/ui/FrequentlyUsedView.qml
M  +119  -736  applets/kickoff/package/contents/ui/FullRepresentation.qml
M  +186  -146  applets/kickoff/package/contents/ui/Header.qml
A  +59   -0    applets/kickoff/package/contents/ui/HorizontalStackView.qml     [License: LGPL(v2.0+)]
M  +53   -27   applets/kickoff/package/contents/ui/Kickoff.qml
D  +0    -93   applets/kickoff/package/contents/ui/KickoffGridItem.qml
M  +200  -288  applets/kickoff/package/contents/ui/KickoffGridView.qml
D  +0    -175  applets/kickoff/package/contents/ui/KickoffItem.qml
A  +227  -0    applets/kickoff/package/contents/ui/KickoffItemDelegate.qml     [License: GPL (v2+)]
M  +211  -288  applets/kickoff/package/contents/ui/KickoffListView.qml
A  +137  -0    applets/kickoff/package/contents/ui/KickoffSingleton.qml     [License: LGPL(v2.0+)]
M  +43   -104  applets/kickoff/package/contents/ui/LeaveButtons.qml
A  +53   -0    applets/kickoff/package/contents/ui/NormalPage.qml     [License: LGPL(v2.0+)]
A  +76   -0    applets/kickoff/package/contents/ui/PlacesPage.qml     [License: LGPL(v2.0+)]
D  +0    -22   applets/kickoff/package/contents/ui/PlacesView.qml
D  +0    -18   applets/kickoff/package/contents/ui/RecentlyUsedView.qml
D  +0    -87   applets/kickoff/package/contents/ui/SearchView.qml
D  +0    -42   applets/kickoff/package/contents/ui/SectionDelegate.qml
A  +61   -0    applets/kickoff/package/contents/ui/VerticalStackView.qml     [License: LGPL(v2.0+)]
M  +1    -1    applets/kickoff/package/contents/ui/code/tools.js
A  +2    -0    applets/kickoff/package/contents/ui/qmldir

https://invent.kde.org/plasma/plasma-desktop/commit/9d9c4f169ed424e976636a6d5fa23c7a1e40576b