| Summary: | "Send To" options fail because they try to use the proposed (unexistent) file name | ||
|---|---|---|---|
| Product: | [Unmaintained] ksnapshot | Reporter: | jos poortvliet <jospoortvliet> |
| Component: | general | Assignee: | Richard Moore <rich> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | 2Kmm, andresbajotierra, arthur, aseigo, ashl1future, blprince, bugzilla, illumilore, istdasklar, janjabber, kdebugs, mail, omnicrox, pgquiles, richard.llom, sobik2, sven.burmeister, thomas |
| Priority: | NOR | ||
| Version: | 0.7.1 | ||
| Target Milestone: | --- | ||
| Platform: | openSUSE | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/ksnapshot/1e367462a06b3a1a5952554d7706e740d008156e | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: | Sets new snapshots to modified so it is saved temporarily. | ||
|
Description
jos poortvliet
2010-11-30 21:27:20 UTC
[Comment from a bug triager] I can confirm this bug on KDE SC 4.6 beta2 on ArchLinux (but it works properly on KDE SC 4.5.4) *** Bug 259466 has been marked as a duplicate of this bug. *** I can reproduce it in 4.6b2 under Archlinux, and 4.5.2 under Mandriva. Think the duplicate of bug 240051 [Comment from a bug triager] In fact, it is very related but I don't know if the behaviour is exactly the same. Just checked again with KDE SC 4.6beta1 1) KSnapshot starts, first screenshot is taken, Send To menu options doesn't work 2) A second screenshots is taken, the Send To menu options work! 3) The second screenshot is saved to a file, the proposed filename in the KSnapshot window titlebar changes again, the Send To menu options doesn't work ... (I don't know if bug 240051 included this cases as well...) Regards Confirmed on Kubuntu 10.10 KDE SC 4.5.90 (4.6 RC1). If you take a snapshot you can share it on facebook _if you don't save it first_ Otherwise KSnapshot increments the numbering of the filename which points to a non-existing file. Besides that: Great UI and potentially great sharing possibility. See this thread for my acknoledgement of the problem, a possible fix, and rejection of the fix by one of the maintainers of KSnapshot: http://thread.gmane.org/gmane.comp.kde.devel.graphics/119 (In reply to comment #7) > See this thread for my acknoledgement of the problem, a possible fix, and > rejection of the fix by one of the maintainers of KSnapshot: > > http://thread.gmane.org/gmane.comp.kde.devel.graphics/119 That was long ;-) My 0.02 €: - When starting KSnapshot it should take a snapshot, create a tempory file under /tmp, show "New Snapshot" or something in the title bar. KSnapshot could/should delete any unused temporary files on exit. - When the user clicks "Save As..." it should suggest the last used name incremented by 1. - When the user chooses to "Send to" a different program or plugin it should be passed the temporary file. I don't know if there's a way to notify the opening application that it's a temporary file, but I see it as the responsibility of the external application - not KSnapshot - to determine the action taken when saving the image. At least on Linux/*nix it's just checking whether it's under /tmp and then suggest another location. @Pau While that thread did end up with something usable (the [modified] behind the filename instead of showing unsaved should solve the issue there) one of the things you mentioned, the issue we talk about here (send to not working) was not discussed. Because Aaron got carried away with the other item. Looks like he had a bad day there ;-) I think you mentioned 2 different issues and only 1 of them got addressed. Nobody responded to your first issue: - The behavior when you open KSnapshot (a snapshot is taken but it's not available to Send To... actions) (eg this bug) I hope Aaron can look at that at least ;-) @Jos Send to... does not work because the first snapshot taken when you start KSnapshot is not saved. I have seen an even trickier consequence of the (IMHO, wrong) saving workflow KSnapshot currently uses: you take a snapshot, but when you do Send to..., the file which is used (opened) is actually the snapshot *before* the last one. I'm currently busy with Christmas and porting KSnapshot to Windows. If noone has provided a solution when I'm done with that (in a week or so), I'll work on a solution to the root cause of this bug. It'll be a variation of what I proposed in the thread I linked above. I think this variation would be acceptable to Aaron because it will unconditionally save the file to the last-used directory (no guessing of temporary vs definitive) and won't automatically show a dialog. IIRC there are more bugs against KSnapshot which are caused by the saving flow. Created attachment 57319 [details]
Sets new snapshots to modified so it is saved temporarily.
One line to rule them all :D I added a Patch to fix this. This bug has been fixed in KSnapshot 0.8.2 (part of KDE Applications 4.6.0 or is this part of workspace?) (In reply to comment #14) > I added a Patch to fix this. You patch only fixes this bug for the first time. Steps to reproduce after applying your patch: 1. Open KSnapshot 2. Send to -> KolourPaint. Screenshot is there. Great! 3. Close KolourPaint, go back to KSnapshot 4. Save As... 5. Take new snapshot 6. Send to -> KolourPaint. Expected: screenshot is in KolourPaint Actual result: KolourPaint shows a white rectangle I have applied your patch because it's better than nothing, but it's not THE fix. (Sorry for taking so long to answer, I have been very busy lately) Jos: not, this is not fixed yet. I don't know why this bug was marked as FIXED. (In reply to comment #14) > I added a Patch to fix this. You patch only fixes this bug for the first time. Steps to reproduce after applying your patch: 1. Open KSnapshot 2. Send to -> KolourPaint. Screenshot is there. Great! 3. Close KolourPaint, go back to KSnapshot 4. Save As... 5. Take new snapshot 6. Send to -> KolourPaint. Expected: screenshot is in KolourPaint Actual result: KolourPaint shows a white rectangle I have applied your patch because it's better than nothing, but it's not THE fix. (Sorry for taking so long to answer, I have been very busy lately) Jos: not, this is not fixed yet. I don't know why this bug was marked as FIXED. Debian bug #617793 might be related http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=617793 *** Bug 274536 has been marked as a duplicate of this bug. *** *** Bug 282708 has been marked as a duplicate of this bug. *** Unfortunately I can still reproduce this on Plasma Workspace 4.7.3 (KSnapshot 0.8.2). *** Bug 317552 has been marked as a duplicate of this bug. *** *** Bug 240051 has been marked as a duplicate of this bug. *** *** Bug 268712 has been marked as a duplicate of this bug. *** *** Bug 270310 has been marked as a duplicate of this bug. *** *** Bug 237353 has been marked as a duplicate of this bug. *** *** Bug 280947 has been marked as a duplicate of this bug. *** Kudos to whoever reopened this issue! Still valid in KDE SC 4.13.4. - increasing the file numbering only should take place after a new screenshot is taken, not after a file is saved. Git commit 1e367462a06b3a1a5952554d7706e740d008156e by Aaron Seigo. Committed on 15/09/2014 at 08:41. Pushed by aseigo into branch 'frameworks'. send the last saved snapshot, otherwise save our shot to a temp file M +2 -2 ksnapshot.cpp http://commits.kde.org/ksnapshot/1e367462a06b3a1a5952554d7706e740d008156e I can still reproduce this in 'frameworks' although the changes from comment#30 seem to be applied there in ksnapshot.cpp. → Open ksnapshot → Create a new snapshot → Send To… → Gwenview - Loading 'snapshot_TJ9858.png' failed - Could not open file /home/elias/snapshot_TJ9858.png The mentioned file doesn't exist in my FS, neither in the mentioned path, nor in /tmp or other possible QDir::tempPath() (used by QTemporaryFile). Using Qt 5.4.0 beta and ksnapshot 9cce9db7 With our new screenshot app this is no longer an issue, so - close. |