Bug 366462 - Desktop icons cannot be interacted with via touch
Summary: Desktop icons cannot be interacted with via touch
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Folder (show other bugs)
Version: master
Platform: Other Linux
: VHI major
Target Milestone: 1.0
Assignee: Eike Hein
URL:
Keywords:
: 395151 408049 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-08-05 23:25 UTC by sac
Modified: 2020-11-20 16:55 UTC (History)
14 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.21


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description sac 2016-08-05 23:25:42 UTC
If the desktop "folder view" is used (or in the widget of the usual desktop) there is no chance on a touchscreen to launch the items.

Reproducible: Always

Steps to Reproduce:
1. Boot Live CD
2. Activate desktop folder view
3. try to touch & open "Home" from desktop

Actual Results:  
No chance to launch or open any desktop items on a tablet / convertible / touchscreen.

Expected Results:  
That all items can be touched & open as in pre 5.7.

Kernel & drivers are working correctly. If the symbol is hovered via touchpad, so that the selection box is shown, it can be tapped via touchscreen and the folder / item opens correctly. 

Seems that sth. expects a hover event before click, which of course isn't happening with touchscreens.
Comment 1 sterz 2016-08-18 13:39:06 UTC
This is also occuring in the usual "desktop" view if one trys to touch on a folder on the desktop. However, everywhere else touchscreen support works for me on my convertible (KMenu, applications...).

Just the desktop folder widget is broken.
Comment 2 sac 2016-12-25 09:55:38 UTC
Hm, I fix it myself. Is anyone mainting the code or can point to the widget source code? If I submit the patch would there be anyone here to include this in KDE?

(think I'm somehow lost here or not at the right place)
Comment 3 Christoph Feck 2016-12-31 21:07:56 UTC
If you have a patch, please open a review request via https://phabricator.kde.org/differential/diff/create/
Comment 4 sac 2017-03-05 19:14:18 UTC
Still trying to determine the affected component. By coincidence I got some message after a false update indicating that the plugin is "/usr/lib64/qt5/plugins/kf5/kio/desktop.so". However I didn't find the source, "https://cgit.kde.org/plasma-desktop.git/tree/containments/folder/plugin/foldermodel.cpp?id=c8f43a8fa712171cb62c53000a3343a8eb08f1a9" seems to be sth. else :(
Comment 5 Eike Hein 2017-03-06 20:40:52 UTC
The problem is that MouseEventListener in frameworks doesn't have touch event support.
Comment 6 sac 2017-03-07 19:09:23 UTC
>The problem is that MouseEventListener in frameworks doesn't have touch event support.

Many thanks for the verification & debugging. Is this a bug in QT?

In general QT should support this:
"By default, QGuiApplication translates the first touch point in a QTouchEvent into a QMouseEvent. This makes it possible to enable touch events on existing widgets that do not normally handle QTouchEvent. "
http://doc.qt.io/qt-5/qtouchevent.html

"The MouseArea type allows mouse and touch events to be handled in a QML application."
http://doc.qt.io/qt-5/qtquick-usecase-userinput.html

Is this just related to the following (I guess onContainsMouseChanged will never fire in case of touch)?

https://cgit.kde.org/kde-workspace.git/tree/plasma/desktop/applets/tasks/package/contents/ui/Task.qml?id=e9023a81186145ac4b33268a08759ab00df61466
        onClicked: {
            if (isGroupParent) {
                groupDialog.target = task;
                groupDialog.visible = true;
            } else {
               tasks.activateItem(model.Id, true);
            }
        }
Comment 7 Eike Hein 2017-03-07 19:30:24 UTC
Qt Quick isn't widgets though, and the entire Qt Quick event handling code is currently in major flux and being rewritten.

The code you've quotes is from Task Manager and not related to Folder View.
Comment 8 sac 2017-03-12 13:31:19 UTC
>The code you've quotes is from Task Manager and not related to Folder View.
Sry, was the only component where "MouseEventListener" was referenced.

Still wonder why all other components are working well with single touches (like the menu button in the upper left corner). Is it not possible to use a similar "mechanism" for folderview? At least as workaround until Qt Quick event handling code has been reworked.
Comment 9 Eike Hein 2017-03-12 15:51:37 UTC
MouseEventListener is in kdeclarative. And no, FV needs it.
Comment 10 thebunnyrules 2018-01-14 13:44:05 UTC
I confirm that this behavior is happening with me too.
Comment 11 thebunnyrules 2018-01-14 13:45:03 UTC
And that this and bug 366527 have the same roots.
Comment 12 Patrick Silva 2018-06-14 15:46:09 UTC
*** Bug 395151 has been marked as a duplicate of this bug. ***
Comment 13 loop.rw 2018-08-03 16:28:23 UTC
I confirm the presence of this bug in 5.12.5-r1.
Touchscreen hardware is ELAN22CA:00 04F3:22CA on HP spectre x360 1WB97AV

While touchscreen tap and drag work within any other software (dolphin, firefox etc), on desktop taps yield no effect.

Have there been any updates or fixes to address this?
Comment 14 Gabriel Tr 2018-09-20 13:13:31 UTC
Same problem on my Lenovo Miix 700. Same touchscreen too (ELAN22CA)
Comment 15 Nate Graham 2019-11-05 18:36:57 UTC
*** Bug 408049 has been marked as a duplicate of this bug. ***
Comment 16 Nate Graham 2020-02-20 20:01:14 UTC
Open patch in need of review: https://phabricator.kde.org/D25428
Comment 17 The Feren OS Dev 2020-04-15 19:48:39 UTC
I can also reproduce this.
Comment 18 Nate Graham 2020-09-24 18:29:17 UTC
We really need to move on https://phabricator.kde.org/D25428.
Comment 19 Bug Janitor Service 2020-10-03 09:54:53 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/170
Comment 20 François-Xavier Thomas 2020-10-22 18:52:55 UTC
I've had the same symptoms for as long as I've been using KDE on an HP x2-10.

I found a workaround on X11 (doesn't work on Wayland): first touch an empty zone in the panel, _then_ touch the desktop icon, which can be selected and opened properly.
Comment 21 David Edmundson 2020-10-30 21:14:13 UTC
Git commit a366714231dcdb24e17bf12c39d4457ac5d7dbb7 by David Edmundson, on behalf of Steffen Hartleib.
Committed on 30/10/2020 at 21:14.
Pushed by davidedmundson into branch 'master'.

Allow touch to interact with Icons in FolderView mode

* moving icon's on the desktop around with touch
* open/launch icons with tap (only singe tap, regardless of mouse workspace behavior)
* access the icon's context menu with tap and hold
Related: bug 408051

M  +29   -1    containments/desktop/package/contents/ui/FolderView.qml

https://invent.kde.org/plasma/plasma-desktop/commit/a366714231dcdb24e17bf12c39d4457ac5d7dbb7
Comment 22 Patrick Silva 2020-11-12 18:18:40 UTC
This isuse persists. Nothing happens when I tap icons on desktop with my touchscreen.

Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.20.80
KDE Frameworks Version: 5.76.0
Qt Version: 5.15.1
Comment 23 Nate Graham 2020-11-12 18:21:16 UTC
Works for me. Does your machine have a wacom touchscreen? Is it a Lenovo? If yo you are likely running into https://bugs.launchpad.net/ubuntu/+source/xf86-input-wacom/+bug/1774242 or a variant of it.
Comment 24 Patrick Silva 2020-11-12 18:34:27 UTC
it's an old lenovo laptop with synaptics touchscreen.
My touchscreen works as expected with other parts of the system
and KDE apps.
Comment 25 Nate Graham 2020-11-12 18:52:27 UTC
I very strongly suspect that this is a driver issue and your touchscreen is not sending proper touch events. But do you by any chance have any other distros on the same machine that you can test with?

I don't know how to debug any further as it works for me and it works for the person who submitted the fix (obviously).
Comment 26 Patrick Silva 2020-11-12 19:05:25 UTC
I have reinstalled neon unstable a few hours ago, right now it is the only system installed on my laptop. I plan to do dual boot with Arch + Gnome later.
I'm reinstalling everything due to recent problems with my hard disk. :(
Comment 27 sac 2020-11-12 20:38:04 UTC
BTW: Works great for me:

- Lenovo Yoga 900S
- neon-unstable-20201112-1102.iso

Tested: 
- touchable icon on standard desktop
- context menu for a long touch on desktop
- touchable icon & context menu in Dolphin (nice box animation)
- all tested also with desktop scale 1,5

Absolutely awesome, amazing work ;)

@Patrick 
probably worth a try with Fedora, but might be sth. weird with your Lenovo (although they're usally really good with Linux)
Comment 28 Patrick Silva 2020-11-20 13:39:56 UTC
I have found the problem.
Set icons arranged in columns and aligned to the right side.
Tap any icon on desktop, nothing happens.

Can anyone confirm?
Comment 29 Nate Graham 2020-11-20 16:14:04 UTC
Can confirm when using Right Column arrangement. Seems to work with left column arrangement as well as right or left row arrangement.

Could be related to Bug 359783.

Can you open a new bug report to track this?
Comment 30 Patrick Silva 2020-11-20 16:38:59 UTC
(In reply to Nate Graham from comment #29)
> Can you open a new bug report to track this?

done, bug 429401
Comment 31 Nate Graham 2020-11-20 16:55:13 UTC
Thanks!