Bug 408049 - Touch activation on touchscreen for Folder View items almost never works (does work for Desktop view and for Folder View with touchpad )
Summary: Touch activation on touchscreen for Folder View items almost never works (doe...
Status: RESOLVED DUPLICATE of bug 366462
Alias: None
Product: plasmashell
Classification: Plasma
Component: Folder (show other bugs)
Version: 5.15.90
Platform: Neon Linux
: NOR major
Target Milestone: 1.0
Assignee: Eike Hein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-29 00:14 UTC by Marian Klein
Modified: 2021-08-27 14:08 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marian Klein 2019-05-29 00:14:30 UTC
SUMMARY

Opening/launching an app does not work with touchscreen.

STEPS TO REPRODUCE

1. Get a laptop/convertible with a touchscreen. (I have HP spectre x360 convertible)

2.) install neon-developer-20190514-0001.iso (or alternativally install into virtual box)

3.) After booting the system pick an application from the menu.
and drag&drop it onto desktop. (I am picking a dolphin app from menu/launcher/dashboard.) You can choose any app. Problem does not depend on the app.

I drag a dolphin icon from menu/launcher/dashboard to a plasma desktop.

4.) Depending on your settings in "System settings/Desktop behaviour/Workspace/"
  a)Single click to open files and folders
  b)Double click to open files and folders/single click select
either try to double click or single click on the dropped icon on desktop.


OBSERVED RESULT

Dolphin Does not open.

EXPECTED RESULT

Dolphin should open.

Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.16.80
KDE Frameworks Version: 5.59.0
Qt Version: 5.12.0
Kernel Version: 5.0.0-15-lowlatency
OS Type: 64-bit
Processor: 1 × Intel® Core™ i7-8550U CPU @ 1.80GHz
Memory: 3.9 GiB of RAM
Comment 1 Marian Klein 2019-05-29 00:24:44 UTC
To be clear the 4) point you click/tap on touchscreen.

4.) Depending on your settings in "System settings/Desktop behaviour/Workspace/"
  a)Single click to open files and folders
  b)Double click to open files and folders/single click select
either try to double click or single click on the dropped icon on desktop by using touch screen.
Comment 2 Marian Klein 2019-05-29 00:31:27 UTC
opening the same app on the touchscreen works via the menu/launcher/dashboard with single click. It is just when the icon is on the desktop it does not work.
I noticed sometimes it does for me, but most of the time it DOES not.
It is very unreliable. I believe it is something to do with the focus, the icon gets when mouse is hovered over the icon, but the focus/hover is not received when you use touchscreen. Hence the click action and app activation is not working.

Can someone with touchscreen to reproduce and confirm this problem?
Also once confirmed can someone re-assign it to the correct team?
Thanks.
Comment 3 Christoph Feck 2019-05-29 00:46:16 UTC
Click handling on the desktop depends on which desktop layout you are using (folder view or a regular desktop). Please check Configure Desktop > Wallpaper.
Comment 4 Marian Klein 2019-05-29 00:52:21 UTC
Thank you for you reply.

I cannot see "Configure Desktop > Wallpaper" in system settings. Can you correct yourself or be more specific where it is?

I use out of the box setting for neon and for kubuntu 19.04 I use either kubuntu or breze theme.
Comment 5 Marian Klein 2019-05-29 00:53:17 UTC
Thank you for you reply.

I cannot see "Configure Desktop > Wallpaper" in system settings. Can you correct yourself or be more specific where it is?

I use out of the box setting for neon and for kubuntu 19.04 I use either kubuntu or breze theme.
Comment 6 Christoph Feck 2019-05-29 00:54:59 UTC
"Configure Desktop" is in the desktop's right-click menu.
Comment 7 Marian Klein 2019-05-29 01:23:41 UTC
Thanks,I learned something new. This is a mess. So there are two types of icons? Those dragged to desktop with Folder view and those with desktop view?
What is the rationale for having those two views and what should be a difference between those two views?
This is not user friendly at all.

Out of the box setting for KDE/neon/kubuntu should be such that launching an app with tapping/clicking on touchscreen works out-of-the-box reliably and consistently in both views as is the case for mouse/touchpad.

Touchscreen now works with one of those (the other one from what was a default option, I lost track of what was original default setting ), but it does not respect single/double click setting in system settings. It always open with single click. why?
Launching an app with mouse/touchpad works in both views, but touchscreen with one of those only. Why?
This needs to be consistent and reliable. What is the reason for not having consistent behaviour?

Also I noticed when I dragged the dolphin icon in one of those view I got huge icon, but this is probably related to my "force font dpi=288" option. I have a hidpi laptop and setting 3840x2160 monitor?
Comment 8 Marian Klein 2019-05-29 02:01:14 UTC
Under the "Desktop view" 

a)The icons dragged onto desktop are stored ~/.local/share/plasma_icons/
b) Icons from ~/.local/share/plasma_icons/ are only displayed on desktop 
c) Icons get activated/launched always by single click not respecting "system settings/Desktop behaviour/click behaviour"
d) Touchscreen works for launching an app by single tapping.

Under the "Folder view"
a) Dragged icons are stored into ~/Desktop
b) Icons from both ~/.local/share/plasma_icons/ and ~/Desktop are displayed
   on Desktop.
c) Only icons from ~/.local/share/plasma_icons/ work with touchscreen (single click)
    Icons in ~/Desktop are not possible to launch with touchscreen
d) this is the default out-of-box setting in "Configure desktop" preventing
   to place new icons into
Comment 9 Marian Klein 2019-05-29 03:47:22 UTC
Would you consider changing the default in

/usr/share/plasma/shells/org.kde.plasma.desktop/contents/defaults

from

[Desktop]
Containment=org.kde.plasma.folder
ToolBox=org.kde.desktoptoolbox
RuntimePlatform=Desktop

to

[Desktop]
Containment=org.kde.desktopcontainment
ToolBox=org.kde.desktoptoolbox
RuntimePlatform=Desktop

Basically reverting commit
https://github.com/KDE/plasma-desktop/commit/151bfb728ce8eed923f8e32ae39e345441af2f7b#diff-6366258246a7ce4ad842884ba6d6e247

until touchscreen clicks are properly fixed in Folder View.

In Folder view the only way how I can launch an application by employing a touchscreen is this:
I can position pointer with the mouse or touchpad on the icon (hovering)
 followed by a tapping either single click or double click (depending on setting in "System settings/Desktop behaviour/Workspace/click behaviour") on the icon on the touchscreen.
Comment 10 Nate Graham 2019-05-29 04:11:33 UTC
No, because that would prevent people from moving files and folders to the desktop, and would be especially unwelcome for people who don't have a touchscreen device. The solution is to fix the bug, not to work around it by changing the defaults and breaking someone else.

Anyway, I can confirm the bug. Touch in Folder View does not seem to work reliably.
Comment 11 Marian Klein 2019-05-29 04:24:31 UTC
Thanks Nate.
Now if you don't mind me helping kde/plasma, you can point me to the relevant source files so I can start looking into it to help kde to fix it fast.
Comment 12 Nate Graham 2019-05-29 04:30:29 UTC
Absolutely! Please feel free to. Check out https://cgit.kde.org/plasma-desktop.git/tree/desktoppackage/contents/views/Desktop.qml

Side note: I know I probably came off as a bit of a jerk in your last few bug reports, and for that I apologize. When I was new to KDE, I filed a lot of similar bug reports asking for Plasma to support workarounds for issues that didn't seem like they were getting fixed fast enough. But eventually I learned that doing this is not a sustainable way to develop software, because over time it causes your codebase to become so messy and fragile that fixing issues correctly becomes practically impossible. So it's important that we not shoot ourselves in the foot by fixing things the wrong way that makes it harder to fix them in the right way later.

We absolutely welcome efforts to fix bugs in the right way, though! If you haven't set up a development environment yet, check out https://community.kde.org/Get_Involved/development
Comment 13 Nate Graham 2019-05-29 04:37:14 UTC
My bad, the source file you want to look at is actually https://cgit.kde.org/plasma-desktop.git/tree/containments/desktop/package/contents/ui/FolderView.qml
Comment 14 Marian Klein 2019-05-29 04:41:33 UTC
Ok I will look at it.

For touchscreen users , current workaround is to switch to Desktop View temporarily when they drag new icons to Desktop. After they are finished with adding new icons they can switch immediately back to Folder View and they still can open those new icons always by single tap irrespective of System Settings.
Comment 15 Nate Graham 2019-11-05 18:36:57 UTC

*** This bug has been marked as a duplicate of bug 366462 ***
Comment 16 Jones Willian 2021-08-27 14:08:58 UTC
(In reply to Marian Klein from comment #14)
> Ok, vou olhar para ele.
> 
> Para usuários de tela sensível ao toque, a solução alternativa atual é
> alternar para a Visualização da área de trabalho temporariamente quando eles
> arrastam novos ícones para a área de trabalho. Depois de terminar de
> adicionar novos ícones, eles podem voltar imediatamente para a exibição de
> pastas e ainda podem abrir esses novos ícones sempre com um único toque,
> independentemente das configurações do sistema.

Olá Maria bom dia, estou com um problema semelhante no KDE Plasma, por acaso você conseguiu resolver?