Bug 366527 - Touch events cannot launch applications
Summary: Touch events cannot launch applications
Status: RESOLVED FIXED
Alias: None
Product: kdeplasma-addons
Classification: Plasma
Component: Application Dashboard (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Eike Hein
URL:
Keywords:
: 353964 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-08-08 13:01 UTC by Martin Flöser
Modified: 2018-02-20 15:29 UTC (History)
9 users (show)

See Also:
Latest Commit:
Version Fixed In: KDE Plasma 5.12.2


Attachments
Video example of touchscreen tap-clicks not launching applications on dashboard (876.70 KB, video/webm)
2018-02-14 06:04 UTC, Andrew Crouthamel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Flöser 2016-08-08 13:01:54 UTC
The application dashboard cannot launch applications through the touch screen. Switching the categories is possible through touch events

Reproducible: Always

Steps to Reproduce:
1. Have a touch screen
2. Open application dash board
3. Try to launch an application through the touch screen

Actual Results:  
Nothing happens

Expected Results:  
Application is launched

If the mouse pointer is moved to an item, one can launch that through the touch screen.
Comment 1 hcoohb 2017-11-21 07:16:48 UTC
I can confirm this behavior.
Which is really a shame, if it was working, this dashboard would be perfect for touchscreen laptop/tablet like mine!!
(It also affects plasmoid Simple menu)
Comment 2 thebunnyrules 2018-01-14 13:19:47 UTC
I confirm the behavior. the dash does not let me click an icon unless it's been hovered over by a mouse and the blue highlight appears. In touch that translate to not be able to click since it is not possible to hove
Comment 3 fouad.racy@gmail.com 2018-01-14 13:25:35 UTC
It doesn't work for me either. I have a touch screen and can't use the dash.
Comment 4 Kai Uwe Broulik 2018-01-14 13:29:54 UTC
This might have been fixed by https://cgit.kde.org/plasma-desktop.git/commit/?id=1062a6a25d498adbb6f2ed810dd1d163d5f3a8a7 at least I've seen a removal of a MouseEventListener
Comment 5 thebunnyrules 2018-01-14 13:41:20 UTC
I believe this is related to bug 66462 ( https://bugs.kde.org/show_bug.cgi?id=366462 ). Both bogs have the same roots. "The problem is that MouseEventListener in frameworks doesn't have touch event support.(Comment 5: Eike Hein)"
Comment 6 thebunnyrules 2018-01-14 13:42:21 UTC
Sorry I made a typo: it's bug 366462
Comment 7 Eike Hein 2018-01-15 07:14:21 UTC
The comment Kai linked should also resolve this indeed.
Comment 8 Andrew Crouthamel 2018-02-14 06:04:06 UTC
I confirm this as well (someone should mark this confirmed). Do we know what version this will make it into, as Kai linked to a git fix?

KDE Plasma Version: 5.12.0
KDE Frameworks Version: 5.42.0
Qt Version: 5.9.3
Kernel Version 4.13.0-32-generic
OS Type: 64-bit
Comment 9 Andrew Crouthamel 2018-02-14 06:04:39 UTC
Created attachment 110645 [details]
Video example of touchscreen tap-clicks not launching applications on dashboard
Comment 10 Patrick Silva 2018-02-14 09:07:57 UTC
Confirmed on my laptop with touch screen running neon dev unstable.
Comment 11 Eike Hein 2018-02-14 10:38:18 UTC
I finally have a touchscreen and can now confirm this.
Comment 12 Eike Hein 2018-02-14 15:54:16 UTC
Git commit 31bcd0ac95906186a0fd734b7ee43d15c0273975 by Eike Hein.
Committed on 14/02/2018 at 15:51.
Pushed by hein into branch 'Plasma/5.12'.

Fix launching by touchscreen tap

Summary:
The mouse handling code relied on onPositionChanged to do setup work
prior to onPressed. This is never guaranteed, but it's is likely to
happen when using the mouse (since the pointer is usually moved from
a panel icon to a delegate elsewhere on screen). In a touchscreen
scenario, these odds reverse.

The lesson to take away: Never assume onPositionChanged has run
before onPressed.

Reviewers: #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D10513

M  +30   -22   applets/kicker/package/contents/ui/ItemGridView.qml

https://commits.kde.org/plasma-desktop/31bcd0ac95906186a0fd734b7ee43d15c0273975
Comment 13 Andrew Crouthamel 2018-02-14 16:05:49 UTC
(In reply to Eike Hein from comment #12)
> Git commit 31bcd0ac95906186a0fd734b7ee43d15c0273975 by Eike Hein.
> Committed on 14/02/2018 at 15:51.
> Pushed by hein into branch 'Plasma/5.12'.
> 
> Fix launching by touchscreen tap
> 
> Summary:
> The mouse handling code relied on onPositionChanged to do setup work
> prior to onPressed. This is never guaranteed, but it's is likely to
> happen when using the mouse (since the pointer is usually moved from
> a panel icon to a delegate elsewhere on screen). In a touchscreen
> scenario, these odds reverse.
> 
> The lesson to take away: Never assume onPositionChanged has run
> before onPressed.
> 
> Reviewers: #plasma
> 
> Subscribers: plasma-devel
> 
> Tags: #plasma
> 
> Differential Revision: https://phabricator.kde.org/D10513
> 
> M  +30   -22   applets/kicker/package/contents/ui/ItemGridView.qml
> 
> https://commits.kde.org/plasma-desktop/
> 31bcd0ac95906186a0fd734b7ee43d15c0273975

Awesome! Thanks!
Comment 14 Patrick Silva 2018-02-20 15:29:35 UTC
*** Bug 353964 has been marked as a duplicate of this bug. ***