Bug 408051 - With touch, always activate items on single-click
Summary: With touch, always activate items on single-click
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Folder (show other bugs)
Version: 5.15.90
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Eike Hein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-29 04:15 UTC by Nate Graham
Modified: 2020-10-30 22:28 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.21


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2019-05-29 04:15:48 UTC
When using a touchscreen, the concept of the double-click does not make sense. When the user is using the systemwide double-click setting, this should be ignored when trying to activate Folder View items with a touchscreen, and they should always be activated with a single touch.

Alternatively, if it's deemed critically important to respect the single-click/double-click setting even with touch input, a double-tap should not require that the cursor click the same spot; tapping twice *anywhere* on the item should be sufficient to trigger the double-tap to activate the item.
Comment 1 Christoph Feck 2019-06-14 12:12:27 UTC
> a double-tap should not require that the cursor click the same spot

Even for mouse clicks a slight tolerance should be accepted (pushing down the button can cause a slight move). Some applications use the startDragDistance() property also for double clicks.
Comment 2 Nate Graham 2019-06-14 13:20:04 UTC
(In reply to Christoph Feck from comment #1)
> > a double-tap should not require that the cursor click the same spot
> 
> Even for mouse clicks a slight tolerance should be accepted (pushing down
> the button can cause a slight move). Some applications use the
> startDragDistance() property also for double clicks.
Right. However the tolerance would need to be much higher for touch.

I still think single-click/touch-only is what makes the most sense for touch. No other touch-first platform that I'm aware of implement a double-tap-to-open behavior.
Comment 3 Christoph Feck 2019-06-16 02:48:20 UTC
The startDragDistance used to be configurable with 'kcmshell5 mouse'. Unfortunately the QML 'port' removed many options.
Comment 4 Nate Graham 2019-06-16 16:00:49 UTC
It wasn't a QML port. Rather, a new QML UI was created to support using the Libinput driver. The missing features are ones not supported by Libinput, not anything that was missed or lost in the process of creating the new UI.
Comment 5 Christoph Feck 2019-06-17 01:07:07 UTC
startDragDistance and related values are not input driver features, but Qt features.
Comment 6 Nate Graham 2019-06-17 04:15:19 UTC
Ah, that's true.

We should indeed bring that back. However I would not put it in the mouse settings, because it doesn't on;y affect mice (e.g. you duoble-click with a touchpad too).

Maybe we need a combined "Mouse & Touchpad" KCM that holds settings common to both (single-click vs double-click; drag distance, etc) and also allows configuring mice and touchpads.

That's all material for another bug though. :)
Comment 7 Nate Graham 2020-01-23 17:06:22 UTC
This is being implemented in https://phabricator.kde.org/D25428.
Comment 8 Bug Janitor Service 2020-10-03 09:54:55 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/170
Comment 9 David Edmundson 2020-10-30 21:14:21 UTC
Git commit a366714231dcdb24e17bf12c39d4457ac5d7dbb7 by David Edmundson, on behalf of Steffen Hartleib.
Committed on 30/10/2020 at 21:14.
Pushed by davidedmundson into branch 'master'.

Allow touch to interact with Icons in FolderView mode

* moving icon's on the desktop around with touch
* open/launch icons with tap (only singe tap, regardless of mouse workspace behavior)
* access the icon's context menu with tap and hold
Related: bug 366462

M  +29   -1    containments/desktop/package/contents/ui/FolderView.qml

https://invent.kde.org/plasma/plasma-desktop/commit/a366714231dcdb24e17bf12c39d4457ac5d7dbb7