Bug 417551 - Juk ignores the queue if a file gets dragged there
Summary: Juk ignores the queue if a file gets dragged there
Status: RESOLVED FIXED
Alias: None
Product: juk
Classification: Applications
Component: general (other bugs)
Version First Reported In: 19.04.0
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Scott Wheeler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-13 11:10 UTC by lupccs
Modified: 2021-03-25 01:50 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 21.04
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description lupccs 2020-02-13 11:10:43 UTC
SUMMARY
With a right click on a title and a click to "add to queue", everything works perfectly, but if a title gets dragged to the queue juk seems to ignore it

STEPS TO REPRODUCE
1. While playing a file, from the main library view (with the queue visible on the left panel and the normal shuffle enabled) click on a song and drag it to the queue
2. Click on the queue just to make sure the title is added, then go back to the library view
3. Wait for the currently playing song to finish (or slide the indicator towards the end or skip to the next song)


OBSERVED RESULT
When the current song stops playing, juk plays a random song

EXPECTED RESULT
When the current song stops playing, juk should play the next song in queue

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: Kubuntu 19.10
(available in About System)
KDE Plasma Version: 5.16.5
KDE Frameworks Version: 5.62.0
Qt Version: 5.12.4

ADDITIONAL INFORMATION
juk 19.04.3
Comment 1 Michael Pyne 2021-03-23 03:12:43 UTC
Git commit 6aef3be8682d829f07ab86901ceff8755fee8610 by Michael Pyne.
Committed on 23/03/2021 at 02:59.
Pushed by mpyne into branch 'master'.

Improve track sequencing by removing the track sequencing classes.

This removes one of my first contributions to JuK :(

But it's worth it because the extra code is not worth the complexity,
seeing as how the job is really pretty simple in the first place, even
with album random play and randomized playback.

I believe this also fixes some bugs, including some longstanding ones.
Bug 417551 (being unable to drag and drop into Play Queue) had some
related work in a recent commit but was still broken until now.
Related: bug 100356, bug 166711, bug 302250, bug 303901, bug 336637, bug 353259, bug 404157
FIXED-IN:21.04

M  +0    -2    CMakeLists.txt
M  +7    -20   dynamicplaylist.cpp
M  +2    -0    dynamicplaylist.h
M  +0    -1    juk.cpp
M  +2    -21   playermanager.cpp
M  +0    -1    playermanager.h
M  +62   -51   playlist.cpp
M  +14   -1    playlist.h
M  +14   -18   playlistbox.cpp
M  +3    -1    playlistbox.h
M  +2    -4    playlistcollection.cpp
M  +4    -0    playlistcollection.h
M  +11   -0    playlistitem.cpp
M  +1    -0    playlistitem.h
M  +0    -2    playlistsplitter.cpp
D  +0    -316  tracksequenceiterator.cpp
D  +0    -233  tracksequenceiterator.h
D  +0    -182  tracksequencemanager.cpp
D  +0    -187  tracksequencemanager.h
M  +36   -166  upcomingplaylist.cpp
M  +11   -133  upcomingplaylist.h

https://invent.kde.org/multimedia/juk/commit/6aef3be8682d829f07ab86901ceff8755fee8610
Comment 2 Michael Pyne 2021-03-25 01:50:02 UTC
Git commit b46844f6aad1359f971ad2c876d7c0728cec77d5 by Michael Pyne.
Committed on 25/03/2021 at 01:38.
Pushed by mpyne into branch 'release/21.04'.

Improve track sequencing by removing the track sequencing classes.

This removes one of my first contributions to JuK :(

But it's worth it because the extra code is not worth the complexity,
seeing as how the job is really pretty simple in the first place, even
with album random play and randomized playback.

I believe this also fixes some bugs, including some longstanding ones.
Bug 417551 (being unable to drag and drop into Play Queue) had some
related work in a recent commit but was still broken until now.
Related: bug 100356, bug 166711, bug 302250, bug 303901, bug 336637, bug 353259, bug 404157
FIXED-IN:21.04

(cherry picked from commit 6aef3be8682d829f07ab86901ceff8755fee8610)

M  +0    -2    CMakeLists.txt
M  +7    -20   dynamicplaylist.cpp
M  +2    -0    dynamicplaylist.h
M  +1    -0    juk.cpp
M  +19   -29   playermanager.cpp
M  +0    -1    playermanager.h
M  +62   -51   playlist.cpp
M  +14   -1    playlist.h
M  +21   -22   playlistbox.cpp
M  +3    -1    playlistbox.h
M  +2    -4    playlistcollection.cpp
M  +4    -0    playlistcollection.h
M  +11   -0    playlistitem.cpp
M  +1    -0    playlistitem.h
M  +0    -2    playlistsplitter.cpp
D  +0    -316  tracksequenceiterator.cpp
D  +0    -233  tracksequenceiterator.h
D  +0    -182  tracksequencemanager.cpp
D  +0    -187  tracksequencemanager.h
M  +36   -166  upcomingplaylist.cpp
M  +11   -133  upcomingplaylist.h

https://invent.kde.org/multimedia/juk/commit/b46844f6aad1359f971ad2c876d7c0728cec77d5