Bug 100356 - double-click to play item only works, till play-queue was used
Summary: double-click to play item only works, till play-queue was used
Status: RESOLVED FIXED
Alias: None
Product: juk
Classification: Applications
Component: general (show other bugs)
Version: 19.12
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Scott Wheeler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-02-27 10:23 UTC by S. Burmeister
Modified: 2021-03-25 01:49 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 21.04
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description S. Burmeister 2005-02-27 10:23:06 UTC
Version:            (using KDE KDE 3.4.0)
Installed from:    SuSE RPMs
OS:                Linux

According to bug 88888, JuK should play any item double-clicked instantly. This behaviour only holds true till you use the play-queue once. After that, double-clicking a playlist just plays the last played item from the play-queue, even if that one was deleted from the play-queue.

Open JuK, double click a custom-playlist, it is played instanlty.
Double-click an item in the collection-list, it is played instantly without adding it to the play-queue.

Add a title to the play-queue, double-click a custom-playlist, the item in the play-queue is re-started instead of the playlist being played. Further, after having used the play-queue once, double-clicking an item in the collection list plays it, as well as adds it to the play-queue, which should not happen until a title is explicitly added to the play-queue.
Comment 1 Scott Wheeler 2005-02-27 11:48:31 UTC
Are you sure that you're actually running the latest CVS?  I can reproduce any of the bugs that you've just reported.
Comment 2 S. Burmeister 2005-02-27 13:48:17 UTC
> Are you sure that you're actually running the latest CVS?  I can reproduce
> any of the bugs that you've just reported.

SuSE packages for 3.4 RC1.

Start JuK.
Double-click a custom playlist, JuK start playing.
Right-click another item from the playlist you just double-clicked, add it to 
the queue.
Double-click another custom-playlist.

You cannot reproduce the bugs, if you do not trigger the latter first.

Comment 3 Philip Rodrigues 2006-02-16 23:57:42 UTC
I can reproduce this with 3.5 branch r504903.
Comment 4 Michael Pyne 2011-05-05 03:35:03 UTC
Bug is /still/ present in KDE 4.6.3. I'm surprised I haven't run across it myself, although to be clear double-clicking a playlist item (i.e. a song) does work, it's double-clicking a playlist that does not.
Comment 5 lupccs 2020-08-17 22:49:51 UTC
Bug still present in 19.12.3 - kubuntu 20.04; I can reproduce both the bugs mentioned in the opening comment
Comment 6 Michael Pyne 2021-03-23 03:12:25 UTC
Git commit 6aef3be8682d829f07ab86901ceff8755fee8610 by Michael Pyne.
Committed on 23/03/2021 at 02:59.
Pushed by mpyne into branch 'master'.

Improve track sequencing by removing the track sequencing classes.

This removes one of my first contributions to JuK :(

But it's worth it because the extra code is not worth the complexity,
seeing as how the job is really pretty simple in the first place, even
with album random play and randomized playback.

I believe this also fixes some bugs, including some longstanding ones.
Bug 417551 (being unable to drag and drop into Play Queue) had some
related work in a recent commit but was still broken until now.
Related: bug 166711, bug 302250, bug 303901, bug 336637, bug 353259, bug 404157, bug 417551
FIXED-IN:21.04

M  +0    -2    CMakeLists.txt
M  +7    -20   dynamicplaylist.cpp
M  +2    -0    dynamicplaylist.h
M  +0    -1    juk.cpp
M  +2    -21   playermanager.cpp
M  +0    -1    playermanager.h
M  +62   -51   playlist.cpp
M  +14   -1    playlist.h
M  +14   -18   playlistbox.cpp
M  +3    -1    playlistbox.h
M  +2    -4    playlistcollection.cpp
M  +4    -0    playlistcollection.h
M  +11   -0    playlistitem.cpp
M  +1    -0    playlistitem.h
M  +0    -2    playlistsplitter.cpp
D  +0    -316  tracksequenceiterator.cpp
D  +0    -233  tracksequenceiterator.h
D  +0    -182  tracksequencemanager.cpp
D  +0    -187  tracksequencemanager.h
M  +36   -166  upcomingplaylist.cpp
M  +11   -133  upcomingplaylist.h

https://invent.kde.org/multimedia/juk/commit/6aef3be8682d829f07ab86901ceff8755fee8610
Comment 7 Michael Pyne 2021-03-25 01:49:38 UTC
Git commit b46844f6aad1359f971ad2c876d7c0728cec77d5 by Michael Pyne.
Committed on 25/03/2021 at 01:38.
Pushed by mpyne into branch 'release/21.04'.

Improve track sequencing by removing the track sequencing classes.

This removes one of my first contributions to JuK :(

But it's worth it because the extra code is not worth the complexity,
seeing as how the job is really pretty simple in the first place, even
with album random play and randomized playback.

I believe this also fixes some bugs, including some longstanding ones.
Bug 417551 (being unable to drag and drop into Play Queue) had some
related work in a recent commit but was still broken until now.
Related: bug 166711, bug 302250, bug 303901, bug 336637, bug 353259, bug 404157, bug 417551
FIXED-IN:21.04

(cherry picked from commit 6aef3be8682d829f07ab86901ceff8755fee8610)

M  +0    -2    CMakeLists.txt
M  +7    -20   dynamicplaylist.cpp
M  +2    -0    dynamicplaylist.h
M  +1    -0    juk.cpp
M  +19   -29   playermanager.cpp
M  +0    -1    playermanager.h
M  +62   -51   playlist.cpp
M  +14   -1    playlist.h
M  +21   -22   playlistbox.cpp
M  +3    -1    playlistbox.h
M  +2    -4    playlistcollection.cpp
M  +4    -0    playlistcollection.h
M  +11   -0    playlistitem.cpp
M  +1    -0    playlistitem.h
M  +0    -2    playlistsplitter.cpp
D  +0    -316  tracksequenceiterator.cpp
D  +0    -233  tracksequenceiterator.h
D  +0    -182  tracksequencemanager.cpp
D  +0    -187  tracksequencemanager.h
M  +36   -166  upcomingplaylist.cpp
M  +11   -133  upcomingplaylist.h

https://invent.kde.org/multimedia/juk/commit/b46844f6aad1359f971ad2c876d7c0728cec77d5