Bug 404157 - Track length is not updated when advancing in the playlist
Summary: Track length is not updated when advancing in the playlist
Status: RESOLVED FIXED
Alias: None
Product: juk
Classification: Applications
Component: general (other bugs)
Version First Reported In: 18.12.1
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Scott Wheeler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-02-09 22:25 UTC by Antonio Rojas
Modified: 2021-03-25 01:50 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 21.04
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio Rojas 2019-02-09 22:25:19 UTC
SUMMARY
When a sing ends and the playlist advances to the next song, the track length is not updated, so the progress bar is in a broken state. Using gstreamer backend.

This is another regression from f07d305eb627028ff87475506f8fa466801f8890
Comment 1 Michael Pyne 2021-03-23 03:12:41 UTC
Git commit 6aef3be8682d829f07ab86901ceff8755fee8610 by Michael Pyne.
Committed on 23/03/2021 at 02:59.
Pushed by mpyne into branch 'master'.

Improve track sequencing by removing the track sequencing classes.

This removes one of my first contributions to JuK :(

But it's worth it because the extra code is not worth the complexity,
seeing as how the job is really pretty simple in the first place, even
with album random play and randomized playback.

I believe this also fixes some bugs, including some longstanding ones.
Bug 417551 (being unable to drag and drop into Play Queue) had some
related work in a recent commit but was still broken until now.
Related: bug 100356, bug 166711, bug 302250, bug 303901, bug 336637, bug 353259, bug 417551
FIXED-IN:21.04

M  +0    -2    CMakeLists.txt
M  +7    -20   dynamicplaylist.cpp
M  +2    -0    dynamicplaylist.h
M  +0    -1    juk.cpp
M  +2    -21   playermanager.cpp
M  +0    -1    playermanager.h
M  +62   -51   playlist.cpp
M  +14   -1    playlist.h
M  +14   -18   playlistbox.cpp
M  +3    -1    playlistbox.h
M  +2    -4    playlistcollection.cpp
M  +4    -0    playlistcollection.h
M  +11   -0    playlistitem.cpp
M  +1    -0    playlistitem.h
M  +0    -2    playlistsplitter.cpp
D  +0    -316  tracksequenceiterator.cpp
D  +0    -233  tracksequenceiterator.h
D  +0    -182  tracksequencemanager.cpp
D  +0    -187  tracksequencemanager.h
M  +36   -166  upcomingplaylist.cpp
M  +11   -133  upcomingplaylist.h

https://invent.kde.org/multimedia/juk/commit/6aef3be8682d829f07ab86901ceff8755fee8610
Comment 2 Antonio Rojas 2021-03-23 20:06:07 UTC
If you really meant to fix this for 21.04, you need to push the changes to the release/21.04 branch too.
Comment 3 Michael Pyne 2021-03-25 01:50:35 UTC
Git commit b46844f6aad1359f971ad2c876d7c0728cec77d5 by Michael Pyne.
Committed on 25/03/2021 at 01:38.
Pushed by mpyne into branch 'release/21.04'.

Improve track sequencing by removing the track sequencing classes.

This removes one of my first contributions to JuK :(

But it's worth it because the extra code is not worth the complexity,
seeing as how the job is really pretty simple in the first place, even
with album random play and randomized playback.

I believe this also fixes some bugs, including some longstanding ones.
Bug 417551 (being unable to drag and drop into Play Queue) had some
related work in a recent commit but was still broken until now.
Related: bug 100356, bug 166711, bug 302250, bug 303901, bug 336637, bug 353259, bug 417551
FIXED-IN:21.04

(cherry picked from commit 6aef3be8682d829f07ab86901ceff8755fee8610)

M  +0    -2    CMakeLists.txt
M  +7    -20   dynamicplaylist.cpp
M  +2    -0    dynamicplaylist.h
M  +1    -0    juk.cpp
M  +19   -29   playermanager.cpp
M  +0    -1    playermanager.h
M  +62   -51   playlist.cpp
M  +14   -1    playlist.h
M  +21   -22   playlistbox.cpp
M  +3    -1    playlistbox.h
M  +2    -4    playlistcollection.cpp
M  +4    -0    playlistcollection.h
M  +11   -0    playlistitem.cpp
M  +1    -0    playlistitem.h
M  +0    -2    playlistsplitter.cpp
D  +0    -316  tracksequenceiterator.cpp
D  +0    -233  tracksequenceiterator.h
D  +0    -182  tracksequencemanager.cpp
D  +0    -187  tracksequencemanager.h
M  +36   -166  upcomingplaylist.cpp
M  +11   -133  upcomingplaylist.h

https://invent.kde.org/multimedia/juk/commit/b46844f6aad1359f971ad2c876d7c0728cec77d5