Bug 166711 - random playing is not so random
Summary: random playing is not so random
Status: RESOLVED FIXED
Alias: None
Product: juk
Classification: Applications
Component: general (show other bugs)
Version: 3.1
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Scott Wheeler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-16 11:46 UTC by Salvatore Brigaglia
Modified: 2021-03-25 01:49 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 21.04
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Salvatore Brigaglia 2008-07-16 11:46:31 UTC
Version:           3.1 (using KDE 4.0.98)
Installed from:    SuSE RPMs
OS:                Linux

When you set random or album random juk tends to stick with an artist. It should play randomly over the intere collection when in random and randomly play a full album when in the other mode. Here is stick with Eros Ramazzotti (in a collection with many more artists) so please... help :)
Comment 1 Georg Grabler 2009-01-25 06:05:01 UTC
Hmh, strange, for me in 4.2 the random album play does not work at all.

Something which probably needs some more love as well... 
Comment 2 Georg Grabler 2009-01-25 06:41:16 UTC
Update:
~trunk it does not seem to do anything wrong there anymore.
Maybe retry with 4.2.1 again.
Comment 3 Michael Pyne 2009-01-25 06:54:56 UTC
I think right now the criteria for splitting albums is that the artist and album names both have to be the same for it to be the same "album".  This was so albums like "Greatest Hits" and other common album titles would not cause unrelated albums to be played together in Album random mode.

I understand this is not completely accurate however.
Comment 4 Andrew Crouthamel 2018-11-02 04:23:37 UTC
Dear Bug Submitter,

This bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? I am setting the status to NEEDSINFO pending your response, please change the Status back to REPORTED when you respond.

Thank you for helping us make KDE software even better for everyone!
Comment 5 Andrew Crouthamel 2018-11-16 02:49:28 UTC
Dear Bug Submitter,

This is a reminder that this bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version?

Thank you for helping us make KDE software even better for everyone!
Comment 6 Michael Pyne 2021-03-23 03:12:57 UTC
Git commit 6aef3be8682d829f07ab86901ceff8755fee8610 by Michael Pyne.
Committed on 23/03/2021 at 02:59.
Pushed by mpyne into branch 'master'.

Improve track sequencing by removing the track sequencing classes.

This removes one of my first contributions to JuK :(

But it's worth it because the extra code is not worth the complexity,
seeing as how the job is really pretty simple in the first place, even
with album random play and randomized playback.

I believe this also fixes some bugs, including some longstanding ones.
Bug 417551 (being unable to drag and drop into Play Queue) had some
related work in a recent commit but was still broken until now.
Related: bug 100356, bug 302250, bug 303901, bug 336637, bug 353259, bug 404157, bug 417551
FIXED-IN:21.04

M  +0    -2    CMakeLists.txt
M  +7    -20   dynamicplaylist.cpp
M  +2    -0    dynamicplaylist.h
M  +0    -1    juk.cpp
M  +2    -21   playermanager.cpp
M  +0    -1    playermanager.h
M  +62   -51   playlist.cpp
M  +14   -1    playlist.h
M  +14   -18   playlistbox.cpp
M  +3    -1    playlistbox.h
M  +2    -4    playlistcollection.cpp
M  +4    -0    playlistcollection.h
M  +11   -0    playlistitem.cpp
M  +1    -0    playlistitem.h
M  +0    -2    playlistsplitter.cpp
D  +0    -316  tracksequenceiterator.cpp
D  +0    -233  tracksequenceiterator.h
D  +0    -182  tracksequencemanager.cpp
D  +0    -187  tracksequencemanager.h
M  +36   -166  upcomingplaylist.cpp
M  +11   -133  upcomingplaylist.h

https://invent.kde.org/multimedia/juk/commit/6aef3be8682d829f07ab86901ceff8755fee8610
Comment 7 Michael Pyne 2021-03-25 01:49:54 UTC
Git commit b46844f6aad1359f971ad2c876d7c0728cec77d5 by Michael Pyne.
Committed on 25/03/2021 at 01:38.
Pushed by mpyne into branch 'release/21.04'.

Improve track sequencing by removing the track sequencing classes.

This removes one of my first contributions to JuK :(

But it's worth it because the extra code is not worth the complexity,
seeing as how the job is really pretty simple in the first place, even
with album random play and randomized playback.

I believe this also fixes some bugs, including some longstanding ones.
Bug 417551 (being unable to drag and drop into Play Queue) had some
related work in a recent commit but was still broken until now.
Related: bug 100356, bug 302250, bug 303901, bug 336637, bug 353259, bug 404157, bug 417551
FIXED-IN:21.04

(cherry picked from commit 6aef3be8682d829f07ab86901ceff8755fee8610)

M  +0    -2    CMakeLists.txt
M  +7    -20   dynamicplaylist.cpp
M  +2    -0    dynamicplaylist.h
M  +1    -0    juk.cpp
M  +19   -29   playermanager.cpp
M  +0    -1    playermanager.h
M  +62   -51   playlist.cpp
M  +14   -1    playlist.h
M  +21   -22   playlistbox.cpp
M  +3    -1    playlistbox.h
M  +2    -4    playlistcollection.cpp
M  +4    -0    playlistcollection.h
M  +11   -0    playlistitem.cpp
M  +1    -0    playlistitem.h
M  +0    -2    playlistsplitter.cpp
D  +0    -316  tracksequenceiterator.cpp
D  +0    -233  tracksequenceiterator.h
D  +0    -182  tracksequencemanager.cpp
D  +0    -187  tracksequencemanager.h
M  +36   -166  upcomingplaylist.cpp
M  +11   -133  upcomingplaylist.h

https://invent.kde.org/multimedia/juk/commit/b46844f6aad1359f971ad2c876d7c0728cec77d5