Bug 302250 - juk album random play does not play album
Summary: juk album random play does not play album
Status: RESOLVED FIXED
Alias: None
Product: juk
Classification: Applications
Component: general (show other bugs)
Version: 3.7
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Scott Wheeler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-20 17:08 UTC by John Wheaton
Modified: 2021-03-25 01:49 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 21.04
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description John Wheaton 2012-06-20 17:08:34 UTC
Using the "Player > Random Play > Use Album Random Play" is not playing entire albums in juk 3.7.

I've tried using the forward and backward track selections and it tracks through the album, but when it progresses on its own it will jump to an entirely new album.

Reproducible: Always
Comment 1 John Wheaton 2012-06-20 17:09:26 UTC
I should also mention that I'm on Kubuntu 11.10 (64 bit), KDE Platform Version 4.7.4.
Comment 2 Michael Pyne 2012-06-21 23:57:07 UTC
I don't know, it seems broken for me even when using Prev/Next buttons. Hrm..
Comment 3 Justin Zobel 2021-03-09 06:26:55 UTC
Thank you for the bug report.

As this report hasn't seen any changes in 5 years or more, we ask if you can please confirm that the issue still persists.

If this bug is no longer persisting or relevant please change the status to resolved.
Comment 4 Michael Pyne 2021-03-23 03:12:33 UTC
Git commit 6aef3be8682d829f07ab86901ceff8755fee8610 by Michael Pyne.
Committed on 23/03/2021 at 02:59.
Pushed by mpyne into branch 'master'.

Improve track sequencing by removing the track sequencing classes.

This removes one of my first contributions to JuK :(

But it's worth it because the extra code is not worth the complexity,
seeing as how the job is really pretty simple in the first place, even
with album random play and randomized playback.

I believe this also fixes some bugs, including some longstanding ones.
Bug 417551 (being unable to drag and drop into Play Queue) had some
related work in a recent commit but was still broken until now.
Related: bug 100356, bug 166711, bug 303901, bug 336637, bug 353259, bug 404157, bug 417551
FIXED-IN:21.04

M  +0    -2    CMakeLists.txt
M  +7    -20   dynamicplaylist.cpp
M  +2    -0    dynamicplaylist.h
M  +0    -1    juk.cpp
M  +2    -21   playermanager.cpp
M  +0    -1    playermanager.h
M  +62   -51   playlist.cpp
M  +14   -1    playlist.h
M  +14   -18   playlistbox.cpp
M  +3    -1    playlistbox.h
M  +2    -4    playlistcollection.cpp
M  +4    -0    playlistcollection.h
M  +11   -0    playlistitem.cpp
M  +1    -0    playlistitem.h
M  +0    -2    playlistsplitter.cpp
D  +0    -316  tracksequenceiterator.cpp
D  +0    -233  tracksequenceiterator.h
D  +0    -182  tracksequencemanager.cpp
D  +0    -187  tracksequencemanager.h
M  +36   -166  upcomingplaylist.cpp
M  +11   -133  upcomingplaylist.h

https://invent.kde.org/multimedia/juk/commit/6aef3be8682d829f07ab86901ceff8755fee8610
Comment 5 Michael Pyne 2021-03-25 01:49:46 UTC
Git commit b46844f6aad1359f971ad2c876d7c0728cec77d5 by Michael Pyne.
Committed on 25/03/2021 at 01:38.
Pushed by mpyne into branch 'release/21.04'.

Improve track sequencing by removing the track sequencing classes.

This removes one of my first contributions to JuK :(

But it's worth it because the extra code is not worth the complexity,
seeing as how the job is really pretty simple in the first place, even
with album random play and randomized playback.

I believe this also fixes some bugs, including some longstanding ones.
Bug 417551 (being unable to drag and drop into Play Queue) had some
related work in a recent commit but was still broken until now.
Related: bug 100356, bug 166711, bug 303901, bug 336637, bug 353259, bug 404157, bug 417551
FIXED-IN:21.04

(cherry picked from commit 6aef3be8682d829f07ab86901ceff8755fee8610)

M  +0    -2    CMakeLists.txt
M  +7    -20   dynamicplaylist.cpp
M  +2    -0    dynamicplaylist.h
M  +1    -0    juk.cpp
M  +19   -29   playermanager.cpp
M  +0    -1    playermanager.h
M  +62   -51   playlist.cpp
M  +14   -1    playlist.h
M  +21   -22   playlistbox.cpp
M  +3    -1    playlistbox.h
M  +2    -4    playlistcollection.cpp
M  +4    -0    playlistcollection.h
M  +11   -0    playlistitem.cpp
M  +1    -0    playlistitem.h
M  +0    -2    playlistsplitter.cpp
D  +0    -316  tracksequenceiterator.cpp
D  +0    -233  tracksequenceiterator.h
D  +0    -182  tracksequencemanager.cpp
D  +0    -187  tracksequencemanager.h
M  +36   -166  upcomingplaylist.cpp
M  +11   -133  upcomingplaylist.h

https://invent.kde.org/multimedia/juk/commit/b46844f6aad1359f971ad2c876d7c0728cec77d5