| Summary: | Immediate crash when starting | ||
|---|---|---|---|
| Product: | [Applications] amarok | Reporter: | Aaron Hughes <hughesac> |
| Component: | general | Assignee: | Amarok Developers <amarok-bugs-dist> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | cad-heinrich, gerarddavila, hughesac, narkhedkarcn, radiosabato, s5saso, shodan82 |
| Priority: | NOR | ||
| Version: | 2.5.0 | ||
| Target Milestone: | 2.6 | ||
| Platform: | Debian testing | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/amarok/352c20df7abb396770f1f78dc868cb4b94d01789 | Version Fixed In: | 2.6 |
| Sentry Crash Report: | |||
| Attachments: |
The patch prevents a playlist scanning crash during startup
New crash information added by DrKonqi New crash information added by DrKonqi |
||
|
Description
Aaron Hughes
2012-06-27 04:10:38 UTC
I think I had songs in the queue when I last closed Amarok. Is there a way to clear the queue without running Amarok? You should be able to remove the queue by erasing this file: $HOME/.kde/share/apps/amarok/current.xspf Not much we can do unfortunately if this is due to a corrupt playlist file. Could you please tell if this solved the issue? *** Bug 302650 has been marked as a duplicate of this bug. *** (In reply to comment #2) > You should be able to remove the queue by erasing this file: > $HOME/.kde/share/apps/amarok/current.xspf > > Not much we can do unfortunately if this is due to a corrupt playlist file. > Could you please tell if this solved the issue? I looked at that file and there was 1 item in the queue. I edited the file to remove all items from the queue and that fixed the problem. <extension application="http://amarok.kde.org"> <queue/> </extension> Thanks for your help. Thank you for the fast feedback :) Created attachment 72523 [details]
The patch prevents a playlist scanning crash during startup
My Amarok also crashed in Playlist::TrackNavigator::queueIds. Editing or deleting the file $HOME/.kde/share/apps/amarok/current.xspf did not solve the crash.
In a debugging session I found, that the variable track can be NULL in Playlist::TrackNavigator::queueIds:
void
Playlist::TrackNavigator::queueIds( const QList<quint64> &ids )
{
Meta::TrackPtr track;
foreach( quint64 id, ids )
{
track = m_model->trackForId( id );
if( !m_queue.contains( id ) && track->isPlayable() )
m_queue.enqueue( id );
}
}
Adding a check for track != NULL solved the problem for me. Amarok now starts without a crash.
Please take a look at the attached patch.
Please consider to reopen this bug.
Your patch has not much to do with a corrupt playlist, I closed it based on your own feedback... In any case, please submit patches to http://reviewboard.kde.org with a reference to the relevant bug report. Created attachment 72737 [details]
New crash information added by DrKonqi
amarok (2.5.0) on KDE Platform 4.8.4 (4.8.4) using Qt 4.8.1
I just started the application and it crashed unexpectedly
-- Backtrace (Reduced):
#7 Playlist::TrackNavigator::queueIds (this=0x9ed6490, ids=...) at ../../src/playlist/navigators/TrackNavigator.cpp:61
#8 0xb6c892ce in Playlist::TrackNavigator::queueId (this=0x9ed6490, id=0) at ../../src/playlist/navigators/TrackNavigator.cpp:51
#9 0xb6bf8dbe in Playlist::Actions::queue (this=0x9ec00a8, rows=...) at ../../src/playlist/PlaylistActions.cpp:400
#10 0xb6bfe89f in Playlist::Actions::restoreDefaultPlaylist (this=0x0) at ../../src/playlist/PlaylistActions.cpp:514
#11 0xb6bfed7a in Playlist::Actions::init (this=0x9ec00a8) at ../../src/playlist/PlaylistActions.cpp:94
*** Bug 303966 has been marked as a duplicate of this bug. *** Git commit 352c20df7abb396770f1f78dc868cb4b94d01789 by Ralf Engels. Committed on 08/08/2012 at 17:53. Pushed by rengels into branch 'master'. Fix some more playlist related problems. The assumption was that a playlist always contains valid tracks. However that does not seem to be the case. Scenario: Tracks are deleted from collection but not from playlist. So, when handling playlist tracks, make sure that there is an actual track object behind it. FIXED-IN: 2.6 M +2 -2 ChangeLog M +3 -0 src/core-impl/playlists/types/file/pls/PLSPlaylist.cpp M +2 -0 src/core-impl/playlists/types/file/xspf/XSPFPlaylist.cpp M +2 -0 src/playlist/navigators/TrackNavigator.cpp http://commits.kde.org/amarok/352c20df7abb396770f1f78dc868cb4b94d01789 *** Bug 310171 has been marked as a duplicate of this bug. *** *** Bug 312312 has been marked as a duplicate of this bug. *** Created attachment 76093 [details]
New crash information added by DrKonqi
amarok (2.5.0) on KDE Platform 4.8.5 (4.8.5) using Qt 4.8.1
Error appeared suddenly. No chance to start amarok.
-- Backtrace (Reduced):
#7 Playlist::TrackNavigator::queueIds (this=0x9e63d10, ids=...) at ../../src/playlist/navigators/TrackNavigator.cpp:61
#8 0x00fce2ce in Playlist::TrackNavigator::queueId (this=0x9e63d10, id=0) at ../../src/playlist/navigators/TrackNavigator.cpp:51
#9 0x00f3ddbe in Playlist::Actions::queue (this=0x9ee4d68, rows=...) at ../../src/playlist/PlaylistActions.cpp:400
#10 0x00f4389f in Playlist::Actions::restoreDefaultPlaylist (this=0x0) at ../../src/playlist/PlaylistActions.cpp:514
#11 0x00f43d7a in Playlist::Actions::init (this=0x9ee4d68) at ../../src/playlist/PlaylistActions.cpp:94
(In reply to comment #13) > Created attachment 76093 [details] > New crash information added by DrKonqi > > amarok (2.5.0) on KDE Platform 4.8.5 (4.8.5) using Qt 4.8.1 Please do not add backtraces to a bug that is fixed in a version ahead of yours, instead install Amarok 2.6, the 2.5 version is rather outdated now. |