Bug 481533 - Some pinned popups move weirdly when floating panel defloats
Summary: Some pinned popups move weirdly when floating panel defloats
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Panel (show other bugs)
Version: 5.93.0
Platform: Gentoo Packages Linux
: NOR minor
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords: qt6
: 466466 481822 483206 (view as bug list)
Depends on:
Blocks:
 
Reported: 2024-02-19 06:38 UTC by Quinten Kock
Modified: 2025-02-06 15:14 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.3.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Quinten Kock 2024-02-19 06:38:49 UTC
SUMMARY
When the panel is floating and defloats, an open popup should move smoothly to 'attach' to the panel.

Some popups (e.g. Audio Volume) do this, but others don't (e.g. Media Player).


STEPS TO REPRODUCE
1. Open and pin Media Player popup
2. Make panel defloat by moving window to it

OBSERVED RESULT
Popup 'jumps' around

EXPECTED RESULT
Popup moves smoothly with panel, like happens when you pin the Audio Volume popup instead.

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 5.93.0
KDE Frameworks Version: 5.249.0
Qt Version: 6.6.1

ADDITIONAL INFORMATION
Graphics Platform: Wayland
Graphics Driver: Nvidia 545.29.06-r1 (RTX 2070)
Comment 1 Niccolò Venerandi 2024-02-19 20:39:48 UTC
Agh, can confirm
Comment 2 Nate Graham 2024-02-21 19:45:13 UTC
Hmm, they're all a bit jumpy for me.
Comment 3 Niccolò Venerandi 2024-02-25 21:46:59 UTC
*** Bug 481822 has been marked as a duplicate of this bug. ***
Comment 4 Niccolò Venerandi 2024-03-11 14:34:44 UTC
*** Bug 483206 has been marked as a duplicate of this bug. ***
Comment 5 Nate Graham 2024-04-11 20:25:00 UTC
*** Bug 466466 has been marked as a duplicate of this bug. ***
Comment 6 Bug Janitor Service 2024-12-13 13:45:04 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/5001
Comment 7 Bug Janitor Service 2024-12-13 13:45:16 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/libplasma/-/merge_requests/1232
Comment 8 Bug Janitor Service 2024-12-13 13:45:29 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2670
Comment 9 Niccolò Venerandi 2025-01-14 10:19:35 UTC
Git commit d6040d2f2a6fedec18e633b55ad4a4ecb11f07bc by Niccolò Venerandi.
Committed on 14/01/2025 at 10:14.
Pushed by niccolove into branch 'master'.

Immediately update popup position upon setting margin

Margin is used to animate applets when the panel switches
from floating to not floating, so we immediately update the
position instead of using queuePositionUpdate, which would
only run at the end of the animation.

M  +5    -0    src/plasmaquick/popupplasmawindow.cpp

https://invent.kde.org/plasma/libplasma/-/commit/d6040d2f2a6fedec18e633b55ad4a4ecb11f07bc
Comment 10 Niccolò Venerandi 2025-01-14 10:51:14 UTC
Git commit 652c766243221f2452ae3628f1d915253b9ac999 by Niccolò Venerandi.
Committed on 14/01/2025 at 10:03.
Pushed by niccolove into branch 'master'.

Animate margin changes for system tray popups

M  +10   -0    applets/systemtray/package/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-workspace/-/commit/652c766243221f2452ae3628f1d915253b9ac999
Comment 11 Niccolò Venerandi 2025-01-14 10:51:16 UTC
Git commit fd0e395be444600a03e1d4d2ebc6b07b38ee3f45 by Niccolò Venerandi.
Committed on 14/01/2025 at 10:03.
Pushed by niccolove into branch 'master'.

Animate margin changes for applet popups

M  +11   -0    desktoppackage/contents/applet/CompactApplet.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/fd0e395be444600a03e1d4d2ebc6b07b38ee3f45
Comment 12 Niccolò Venerandi 2025-01-14 10:51:53 UTC
Git commit 0c6b954c89ea11a4957a3578e4aa02d4e5be598f by Niccolò Venerandi.
Committed on 14/01/2025 at 10:51.
Pushed by niccolove into branch 'Plasma/6.3'.

Immediately update popup position upon setting margin

Margin is used to animate applets when the panel switches
from floating to not floating, so we immediately update the
position instead of using queuePositionUpdate, which would
only run at the end of the animation.


(cherry picked from commit d6040d2f2a6fedec18e633b55ad4a4ecb11f07bc)

Co-authored-by: Niccolò Venerandi <niccolo@venerandi.com>

M  +5    -0    src/plasmaquick/popupplasmawindow.cpp

https://invent.kde.org/plasma/libplasma/-/commit/0c6b954c89ea11a4957a3578e4aa02d4e5be598f
Comment 13 Niccolò Venerandi 2025-01-14 10:52:04 UTC
Git commit e4eac6ceedd36d3f24f5b04c76f7adadfdb09530 by Niccolò Venerandi.
Committed on 14/01/2025 at 10:52.
Pushed by niccolove into branch 'Plasma/6.3'.

Animate margin changes for system tray popups


(cherry picked from commit 652c766243221f2452ae3628f1d915253b9ac999)

Co-authored-by: Niccolò Venerandi <niccolo@venerandi.com>

M  +10   -0    applets/systemtray/package/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-workspace/-/commit/e4eac6ceedd36d3f24f5b04c76f7adadfdb09530
Comment 14 Niccolò Venerandi 2025-01-14 10:52:11 UTC
Git commit cf4aef91df8b918eb1078b3479e705374efd976f by Niccolò Venerandi.
Committed on 14/01/2025 at 10:52.
Pushed by niccolove into branch 'Plasma/6.3'.

Animate margin changes for applet popups


(cherry picked from commit fd0e395be444600a03e1d4d2ebc6b07b38ee3f45)

Co-authored-by: Niccolò Venerandi <niccolo@venerandi.com>

M  +11   -0    desktoppackage/contents/applet/CompactApplet.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/cf4aef91df8b918eb1078b3479e705374efd976f
Comment 15 Bug Janitor Service 2025-02-06 15:14:52 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/5169