Bug 468009 - Panel length saved in absolute terms, which makes maximized panels non-portable to larger screen sizes
Summary: Panel length saved in absolute terms, which makes maximized panels non-portab...
Alias: None
Product: plasmashell
Classification: Plasma
Component: Panel (show other bugs)
Version: 5.27.3
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Plasma Bugs List
: 412699 (view as bug list)
Depends on:
Reported: 2023-03-31 18:10 UTC by PK
Modified: 2023-11-06 20:15 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.0

diff of two org.kde.plasma.desktop-layout.js files of the same theme applied to machines with different screens. (1.34 KB, patch)
2023-03-31 18:10 UTC, PK

Note You need to log in before you can comment on or make changes to this bug.
Description PK 2023-03-31 18:10:05 UTC
Created attachment 157748 [details]
diff of two org.kde.plasma.desktop-layout.js files of the same theme applied to machines with different screens.

In a self-made global theme there is a maximized panel (full screen width or full screen heidth). When I use this global theme on a computer with other screen specifications the maximized panel is rendered wrong (too long/too short)

1. create global theme with the look-and-feel explorer
2. apply the theme to a machine with other screen properties

maximized panel too small or too wide

maximized panel is also just from side to side and fits.

Operating System: KDE neon 5.27
KDE Plasma Version: 5.27.3
KDE Frameworks Version: 5.104.0
Qt Version: 5.15.8
Kernel Version: 5.19.0-35-generic (64-bit)
Graphics Platform: Wayland
Processors: 4 × Intel® Celeron® J4105 CPU @ 1.50GHz
Memory: 7.4 GiB of RAM
Graphics Processor: Mesa Intel® UHD Graphics 600
Comment 1 PK 2023-03-31 18:17:14 UTC
In this first attachment there is the "diff" file of two org.kde.plasma.desktop-layout.js-files of the same global theme-with-maximized-panel, applied to two machines with different screen properties and saved on each machine as global theme.
This diff-file is best opened with kde-kompare.
In my eyes it would make the theme much more portable when it didn't read:
"maximumLength": 67.5,
-            "minimumLength": 67.5,
+            "maximumLength": 56.25,
+            "minimumLength": 56.25,
but something like:
"maximumLength": maximum
-            "minimumLength": maximum
+            "maximumLength": maximum
+            "minimumLength": maximum
Comment 2 Nate Graham 2023-04-04 18:53:45 UTC
Indeed, this isn't ideal.

We should either save maximized state as its own "I'm maximized" state in the config data as you suggest, or else add a bit of logic to infer maximized panel status based on whether the panel had the same length as the screen edge it formerly lived on. That sounds like it would be complicated, so your idea is probably better.
Comment 3 Nate Graham 2023-09-18 20:46:45 UTC
*** Bug 412699 has been marked as a duplicate of this bug. ***
Comment 4 Niccolò Venerandi 2023-11-06 20:15:33 UTC
Git commit 8bad74fe9ed43af3081b8dd97cc17524b82c2d77 by Niccolò Venerandi.
Committed on 06/11/2023 at 21:15.
Pushed by niccolove into branch 'master'.

Redesign panel settings with a dialog

This moves all panel options in a single dialog that floats near the panel.
Related: bug 450892, bug 459103, bug 458008, bug 440274, bug 453693, bug 460844, bug 455478, bug 462980, bug 454720, bug 455476, bug 460845, bug 474354, bug 364456

M  +495  -133  desktoppackage/contents/configuration/PanelConfiguration.qml
D  +0    -305  desktoppackage/contents/configuration/panelconfiguration/MoreSettingsMenu.qml
M  +76   -84   desktoppackage/contents/configuration/panelconfiguration/PanelRepresentation.qml
M  +53   -266  desktoppackage/contents/configuration/panelconfiguration/Ruler.qml
M  +10   -37   desktoppackage/contents/configuration/panelconfiguration/SliderHandle.qml
D  +0    -594  desktoppackage/contents/configuration/panelconfiguration/ToolBar.qml