Bug 459103 - In Edit Mode toolbar, closing "More Options" popup doesn't return focus to the button that was used to open it
Summary: In Edit Mode toolbar, closing "More Options" popup doesn't return focus to th...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Panel (show other bugs)
Version: master
Platform: openSUSE Linux
: NOR minor
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords: accessibility
Depends on:
Blocks:
 
Reported: 2022-09-14 14:13 UTC by Fushan Wen
Modified: 2023-11-06 20:15 UTC (History)
5 users (show)

See Also:
Latest Commit: https://invent.kde.org/plasma/plasma-desktop/-/commit/8bad74fe9ed43af3081b8dd97cc17524b82c2d77
Version Fixed In: 6.0
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Fushan Wen 2022-09-14 14:13:11 UTC 
SUMMARY
Plasma Dialog does not restore old focus after it's closed.

STEPS TO REPRODUCE
1. requestActivate a Plasma dialog
2. Close the dialog
3. The old window focus should be restored
Comment 1 Aleix Pol 2022-09-14 14:37:23 UTC 
Can you maybe be a bit more explicit? It will surely help to understand what you are after.

Can you maybe provide a video of what you have and explain how it should be different? A test qml file would be handy as well.
Comment 2 Fushan Wen 2022-09-14 14:43:52 UTC 
1. Open "More Options" in the panel edit toolbar
2. Assuming I use dialog.requestActivate(), the dialog should have focus now
3. Press esc to close the dialog
4. The focus is not restored to "More Options" button
Comment 3 Aleix Pol 2022-09-14 14:55:05 UTC 
What makes you think it's a problem with Plasma Dialog and not the toolbar editing mode? As I see it, It cancels everything... Not saying that this is what we want, just trying to get to the same conclusion as you.
Comment 4 Nate Graham 2022-09-14 16:53:18 UTC 
Indeed, it would appear to be a bug with just that.

The original description's steps to reproduce are working fine for me with regular windows, e.g. opening and closing kickoff causes the app window that was focused before to be focused again.
Comment 5 Niccolò Venerandi 2023-11-06 20:15:48 UTC 
Git commit 8bad74fe9ed43af3081b8dd97cc17524b82c2d77 by Niccolò Venerandi.
Committed on 06/11/2023 at 21:15.
Pushed by niccolove into branch 'master'.

Redesign panel settings with a dialog

This moves all panel options in a single dialog that floats near the panel.
Related: bug 450892, bug 458008, bug 440274, bug 453693, bug 460844, bug 455478, bug 462980, bug 454720, bug 455476, bug 460845, bug 468009, bug 474354, bug 364456
FIXED-IN: 6.0

M  +495  -133  desktoppackage/contents/configuration/PanelConfiguration.qml
D  +0    -305  desktoppackage/contents/configuration/panelconfiguration/MoreSettingsMenu.qml
M  +76   -84   desktoppackage/contents/configuration/panelconfiguration/PanelRepresentation.qml
M  +53   -266  desktoppackage/contents/configuration/panelconfiguration/Ruler.qml
M  +10   -37   desktoppackage/contents/configuration/panelconfiguration/SliderHandle.qml
D  +0    -594  desktoppackage/contents/configuration/panelconfiguration/ToolBar.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/8bad74fe9ed43af3081b8dd97cc17524b82c2d77