Bug 436929 - less aggressive offline reboot advertisement
Summary: less aggressive offline reboot advertisement
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: Updates (offline) (show other bugs)
Version: unspecified
Platform: Other Linux
: HI normal
Target Milestone: ---
Assignee: Dan Leinir Turthra Jensen
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2021-05-11 13:20 UTC by Harald Sitter
Modified: 2023-05-17 18:39 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.23


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Harald Sitter 2021-05-11 13:20:05 UTC
SUMMARY
with offline updates we are currently seeing a lot of complaints about having to reboot too much. while that kind of ties into how often we notify about updates (bug #436927), I expect the way we advertise the reboot is also not ideal.

users apparently feel prompted to reboot immediately, but realistically we really only want them to shutdown their system ... eventually (and be aware that the next bootup will install updates - bug #436924).

with that in mind it may be a good idea to grab the VDG and come up with more appropriate notification wording.
also currently the reboot notification icon is a fairly aggressive orange, a new icon with more muted green option may be more reflective of the lack of urgency. 

if the user doesn't reboot for 3 days there might be an option to throw up a reminder notification with the original iconography and message though. I am not terribly convinced a person that doesn't reboot for 3 days will be swayed by our notifications though -> might be needless complexity
Comment 1 Nate Graham 2021-05-11 14:30:02 UTC
If anything, with offline updates there's *less* of a need to pester the user to reboot, since their system remains in a safe state, unlike with interactive updates. Maybe we can just notofy the user that the offline updates will be fully applied on the next reboot and not bug them at all.

Seems to somewhat overlap with Bug 436928.
Comment 2 Aleix Pol 2021-05-17 23:16:34 UTC
That could make sense indeed.
Comment 3 Bug Janitor Service 2021-08-28 13:27:30 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/discover/-/merge_requests/156
Comment 4 Aleix Pol 2021-08-29 17:08:30 UTC
Git commit b6f9d1f117a83b5bc699df77930d4ba3a81cc1ef by Aleix Pol Gonzalez, on behalf of Nate Graham.
Committed on 29/08/2021 at 17:03.
Pushed by ngraham into branch 'master'.

Be less aggressive about reboot notifications with offline updates

When we're doing online updates, it's imperative that the user reboot
ASAP, as the system is in an unknown state until that happens. However
with offline updates, this is not the case, and the system can safely be
used  indefinitely between the time when the update is downloaded and
the time when it's installed during the next reboot.

Therefore, when using offline updates, we don't need to badger the user
as much to reboot, so this commit disables the persistent "reboot now"
notification and adjusts the message shown on the updates page.
Hopefully this should alleviate some of the frustration that users have
expressed when using distros that enable offline updates by default.
Related: bug 438443, bug 437454
FIXED-IN: 5.23

M  +1    -1    discover/qml/UpdatesPage.qml
M  +16   -1    libdiscover/resources/ResourcesUpdatesModel.cpp
M  +3    -0    libdiscover/resources/ResourcesUpdatesModel.h
M  +8    -6    notifier/DiscoverNotifier.cpp

https://invent.kde.org/plasma/discover/commit/b6f9d1f117a83b5bc699df77930d4ba3a81cc1ef