Bug 438443 - There is no way to disable the notification that asks for reboot after updates
Summary: There is no way to disable the notification that asks for reboot after updates
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: Updates (offline) (show other bugs)
Version: 5.22.0
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Dan Leinir Turthra Jensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-11 02:26 UTC by Patrick Silva
Modified: 2021-08-29 17:08 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.23


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2021-06-11 02:26:51 UTC
SUMMARY
Discover displays a notification asking for reboot even when offline update feature is disabled (see screenshot) and currently there is no way to disable this notification.

screenshot: https://bugsfiles.kde.org/attachment.cgi?id=138930

EXPECTED RESULT
a way to disable the notification that asks for reboot should exist

SOFTWARE/OS VERSIONS
Operating System: Arch Linux
KDE Plasma Version: 5.21.90
KDE Frameworks Version: 5.82.0
Qt Version: 5.15.2
Graphics Platform: Wayland
Comment 1 Nate Graham 2021-06-15 22:25:56 UTC
Confirmed.
Comment 2 Bug Janitor Service 2021-08-28 13:27:32 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/discover/-/merge_requests/156
Comment 3 Aleix Pol 2021-08-29 17:08:38 UTC
Git commit b6f9d1f117a83b5bc699df77930d4ba3a81cc1ef by Aleix Pol Gonzalez, on behalf of Nate Graham.
Committed on 29/08/2021 at 17:03.
Pushed by ngraham into branch 'master'.

Be less aggressive about reboot notifications with offline updates

When we're doing online updates, it's imperative that the user reboot
ASAP, as the system is in an unknown state until that happens. However
with offline updates, this is not the case, and the system can safely be
used  indefinitely between the time when the update is downloaded and
the time when it's installed during the next reboot.

Therefore, when using offline updates, we don't need to badger the user
as much to reboot, so this commit disables the persistent "reboot now"
notification and adjusts the message shown on the updates page.
Hopefully this should alleviate some of the frustration that users have
expressed when using distros that enable offline updates by default.
Related: bug 436929, bug 437454
FIXED-IN: 5.23

M  +1    -1    discover/qml/UpdatesPage.qml
M  +16   -1    libdiscover/resources/ResourcesUpdatesModel.cpp
M  +3    -0    libdiscover/resources/ResourcesUpdatesModel.h
M  +8    -6    notifier/DiscoverNotifier.cpp

https://invent.kde.org/plasma/discover/commit/b6f9d1f117a83b5bc699df77930d4ba3a81cc1ef