Bug 437454 - restart notification before update is finished with offline updates
Summary: restart notification before update is finished with offline updates
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: Updates (offline) (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Dan Leinir Turthra Jensen
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2021-05-21 11:14 UTC by Harald Sitter
Modified: 2021-08-29 17:08 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.23


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Harald Sitter 2021-05-21 11:14:41 UTC
SUMMARY
when multiple updates are available in both the system (offline update) and flatpak/snap (online) the restart notification appears once the offline update is staged. The flatpak update may still be downloading and installing at that point in time. Depending on system configuration shutting down mid update might end up KILLing the flatpak update mid-flight so we really shouldn't tell the user to restart while we are still updating stuff.
Comment 1 Aleix Pol 2021-05-24 01:49:20 UTC
Although Discover should refuse to be closed mid-update so it shouldn't be all that terrible after all.
Comment 2 Bug Janitor Service 2021-08-28 13:27:33 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/discover/-/merge_requests/156
Comment 3 Aleix Pol 2021-08-29 17:08:22 UTC
Git commit b6f9d1f117a83b5bc699df77930d4ba3a81cc1ef by Aleix Pol Gonzalez, on behalf of Nate Graham.
Committed on 29/08/2021 at 17:03.
Pushed by ngraham into branch 'master'.

Be less aggressive about reboot notifications with offline updates

When we're doing online updates, it's imperative that the user reboot
ASAP, as the system is in an unknown state until that happens. However
with offline updates, this is not the case, and the system can safely be
used  indefinitely between the time when the update is downloaded and
the time when it's installed during the next reboot.

Therefore, when using offline updates, we don't need to badger the user
as much to reboot, so this commit disables the persistent "reboot now"
notification and adjusts the message shown on the updates page.
Hopefully this should alleviate some of the frustration that users have
expressed when using distros that enable offline updates by default.
Related: bug 436929, bug 438443
FIXED-IN: 5.23

M  +1    -1    discover/qml/UpdatesPage.qml
M  +16   -1    libdiscover/resources/ResourcesUpdatesModel.cpp
M  +3    -0    libdiscover/resources/ResourcesUpdatesModel.h
M  +8    -6    notifier/DiscoverNotifier.cpp

https://invent.kde.org/plasma/discover/commit/b6f9d1f117a83b5bc699df77930d4ba3a81cc1ef