This is an alternative to Bug 426107. Both are aiming at the same goal: to improve the UX when annotating a screenshot that is substantially larger than the prior size of Spectacle's window. Right now the existing window shows a small viewport that displays a fraction of the screensoht, which is not very user-friendly.
*** Bug 443192 has been marked as a duplicate of this bug. ***
a) resize the window of Spectacle when Annotate is activated, for example to show at least 50% of the image, but not getting out of the bounds of the current screen. When annotating is done, resize Spectacle to the previous window size. b) in the Annotate widget, zoom out of the image, aka "fit image to window" (this would have to be applied upstream first).
*** Bug 444149 has been marked as a duplicate of this bug. ***
*** Bug 446967 has been marked as a duplicate of this bug. ***
A possibly relevant merge request was started @ https://invent.kde.org/graphics/spectacle/-/merge_requests/127
*** Bug 452368 has been marked as a duplicate of this bug. ***
Git commit f2b9321cdd624024d0b6003335fa284943f1d102 by Antonio Prcela. Committed on 29/06/2022 at 20:13. Pushed by felixernst into branch 'master'. Resize Spectacle's window to screenshot size when entering annotation mode Also reverts back to prev size after annotation is done. M +3 -0 CMakeLists.txt M +3 -0 src/Config.h.in M +49 -17 src/Gui/KSMainWindow.cpp M +3 -0 src/Gui/KSMainWindow.h M +23 -0 src/Gui/KSWidget.cpp M +1 -0 src/Gui/KSWidget.h https://invent.kde.org/graphics/spectacle/commit/f2b9321cdd624024d0b6003335fa284943f1d102
Still does this, probably because of the QML rewrite
Yeah, the change got reverted in the QML rewrite.
(In reply to Nate Graham from comment #9) > Yeah, the change got reverted in the QML rewrite. does this mean we possibly lost more commits with qml rewrite, approx those that were merged between qml rewrite start and end? will take a look at this and re-post it if neccessary
It wasn't the commit itself, it was just the change in general. It needed to be re-implemented in the QML version and wasn't done so. If you wanna re-add it, that would be lovely! We should maximize rather than resizing, since resizing doesn't work properly on Wayland because we can't also move the window when we resize to make sure it remains centered on its previous point. Easier to just maximize.