Bug 421015 - The "get plugins" kipi_plguins [sic] appstream URL has a typo
Summary: The "get plugins" kipi_plguins [sic] appstream URL has a typo
Status: RESOLVED FIXED
Alias: None
Product: gwenview
Classification: Applications
Component: general (show other bugs)
Version: Other (add details in bug description)
Platform: Kubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Gwenview Bugs
URL:
Keywords: junior-jobs
: 422055 422358 424008 428432 430504 432590 434124 444523 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-05-04 18:27 UTC by dennis
Modified: 2022-09-09 06:58 UTC (History)
12 users (show)

See Also:
Latest Commit: https://invent.kde.org/graphics/gwenview/commit/888fa4274d95d7f92683db6d3c3a028fd2e17f27
Version Fixed In: 20.08.3
Sentry Crash Report:

Attachments
Bug is still there in Neon 5.20 with Gwenview 20.08.2 (316.93 KB, image/png)
2020-10-17 16:08 UTC, jdvm 		Details
Typo in (K)ubuntu Focal Fossa (51.35 KB, image/png)
2022-07-07 16:08 UTC, Ewald Müller 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description dennis 2020-05-04 18:27:09 UTC 
https://github.com/KDE/gwenview/blob/14b962f2945e8c63b9d6daf17004390f0a872264/app/kipiinterface.cpp#L59

In kipiinterface.cpp, it says as such: 

#define KIPI_PLUGINS_URL QStringLiteral("appstream://org.kde.kipi_plguins")

I think "plguins" is a typo, and hitting that menu entry also opens Discover with zero results

STEPS TO REPRODUCE
1. Go into the menu "plugins"
2. Hit the "get plugins" menu entry
3. Observe how discover is started with a typo in the appstream url

OBSERVED RESULT

The AppStream URL is appstream://org.kde.kipi_plguins

EXPECTED RESULT

The AppStream URL is appstream://org.kde.kipi_plugins (?)

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Manjaro
KDE Plasma Version: 5.18.4
KDE Frameworks Version: 5.69.0
Qt Version: 5.14.2
GwenView version: 20.04 but current HEAD on GIT still has the same typo!

ADDITIONAL INFORMATION

I don't know if this is actually the error on why discover showed nothing - but I assume the typo wasn't introduced in kipiplugins itself and then propagated, but made in this instance

I think this is the commit that introduced it: https://github.com/KDE/gwenview/commit/09119995c8110ffce110ce0b35b4d4c9109c3877
Comment 1 jdvm 2020-06-20 23:03:28 UTC 
*** Bug 422358 has been marked as a duplicate of this bug. ***
Comment 2 jdvm 2020-06-20 23:04:22 UTC 
*** Bug 422055 has been marked as a duplicate of this bug. ***
Comment 3 Nicolas Fella 2020-07-08 20:31:17 UTC 
*** Bug 424008 has been marked as a duplicate of this bug. ***
Comment 4 Nicolas Fella 2020-07-11 22:29:19 UTC 
Git commit 9187ae35d7d3af45417c2cedda18b3dcee4363e5 by Nicolas Fella.
Committed on 11/07/2020 at 22:22.
Pushed by nicolasfella into branch 'master'.

Fix typo in KIPI plugins URL

This prevents discover from installing it.

M  +1    -1    app/kipiinterface.cpp

https://invent.kde.org/graphics/gwenview/commit/9187ae35d7d3af45417c2cedda18b3dcee4363e5
Comment 5 Bruce Wolfe 2020-07-21 03:08:34 UTC 
This is not fixed in Gwenview version 19.12.3
Comment 6 Bruce Wolfe 2020-07-21 03:14:39 UTC 
Additionally, the corrected spelling is still a broken link:
appstream://org.kde.kipi_plugins
Comment 7 Christoph Feck 2020-07-21 07:52:53 UTC 
The fix can only appear in a future version, never in a past version.
Comment 8 jdvm 2020-10-17 16:06:38 UTC 
Using KDE Neon 5.20 with Plasma 5.20.0 and Gwenview 20.08.2 the menu item still points to the wrong URL, is now a distro problem?
Comment 9 jdvm 2020-10-17 16:08:36 UTC 
Created attachment 132481 [details]
Bug is still there in Neon 5.20 with Gwenview 20.08.2
Comment 10 Nicolas Fella 2020-10-29 15:53:05 UTC 
*** Bug 428432 has been marked as a duplicate of this bug. ***
Comment 11 Nicolas Fella 2020-10-29 16:29:55 UTC 
Git commit 888fa4274d95d7f92683db6d3c3a028fd2e17f27 by Nicolas Fella.
Committed on 29/10/2020 at 16:01.
Pushed by nicolasfella into branch 'release/20.08'.

Fix typo in KIPI plugins URL

This prevents discover from installing it.
(cherry picked from commit 9187ae35d7d3af45417c2cedda18b3dcee4363e5)

M  +1    -1    app/kipiinterface.cpp

https://invent.kde.org/graphics/gwenview/commit/888fa4274d95d7f92683db6d3c3a028fd2e17f27
Comment 12 Nicolas Fella 2020-10-29 16:31:22 UTC 
The issue was fixed in master, but somehow the fix never was put in the 20.08 branch. I've cherry-picked it now
Comment 13 Nicolas Fella 2020-12-17 13:15:40 UTC 
*** Bug 430504 has been marked as a duplicate of this bug. ***
Comment 14 Nate Graham 2021-02-08 19:40:57 UTC 
*** Bug 432590 has been marked as a duplicate of this bug. ***
Comment 15 Nicolas Fella 2021-03-07 23:23:22 UTC 
*** Bug 434124 has been marked as a duplicate of this bug. ***
Comment 16 Nicolas Fella 2021-10-28 13:22:24 UTC 
*** Bug 444523 has been marked as a duplicate of this bug. ***
Comment 17 Ewald Müller 2022-07-07 16:08:04 UTC 
Created attachment 150471 [details]
Typo in (K)ubuntu Focal Fossa
Comment 18 Bruce Wolfe 2022-09-09 02:00:42 UTC 
(In reply to Christoph Feck from comment #7)
> The fix can only appear in a future version, never in a past version.

Huh? If the current version of the stable OS is Kubuntu 20.04 and the version of Gwenview doesn't get updated past v19.12.3 then what? This bug goes back 2+ years. So, the issue never gets fixed? Applications don't get upgraded? Confused, please clarify.
Comment 19 Antonio Rojas 2022-09-09 06:58:45 UTC 
(In reply to Bruce Wolfe from comment #18)
> Huh? If the current version of the stable OS is Kubuntu 20.04 and the
> version of Gwenview doesn't get updated past v19.12.3 then what? This bug
> goes back 2+ years. So, the issue never gets fixed? Applications don't get
> upgraded? Confused, please clarify.

Then complain to your distro or switch to a different one. KDE has no influence on when distros upgrade their packages.