Bug 401861 - Menu search doesn't return any results if cursor happens to be positioned below the tab bar
Summary: Menu search doesn't return any results if cursor happens to be positioned bel...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Application Launcher (Kickoff) (show other bugs)
Version: master
Platform: Other Linux
: HI normal
Target Milestone: 1.0
Assignee: trmdi
URL:
Keywords: regression, usability
: 401365 402423 404655 411678 415314 415338 420282 420759 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-12-07 14:41 UTC by NiO
Modified: 2020-04-29 21:01 UTC (History)
15 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.18.5


Attachments
Bug still present in 5.16.3 (987.01 KB, video/mp4)
2019-07-15 08:08 UTC, Filip Fila
Details

Note You need to log in before you can comment on or make changes to this bug.
Description NiO 2018-12-07 14:41:04 UTC
There are two issues with kickoff regarding mouse placement.  That is, the location where your mouse cursor is inactive while typing into the search box.  I have recorded a screen demo of both issues, this is reproducible.

Issue 1: If the cursor is positioned in the bottom-left corner of kickoff, the search does not work at all.

Issue 2: If the cursor is positioned over the search results area, while you're typing, the result underneath the cursor is the item that gets chosen when you finally press Enter. It should always launch the most relevant search result at the top of the list when you press Enter.


I run into these problems very often, because I usually click the launcher icon, then move my hands over to the keyboard to start typing.  So my mouse cursor usually lays to rest somewhere on top of the menu.

Screen recording: https://www.youtube.com/watch?v=6wDR4rtgxuo

Note: In the video, I am using adapta and some other custom styling, but I tested with all default Breeze and the same issues were present.


Linux/KDE Plasma: KDE Neon
(available in About System)
KDE Plasma Version: 5.14.4
KDE Frameworks Version: 5.52.0
Qt Version: 5.11.2
Comment 1 Saeid Akbari 2018-12-08 17:13:09 UTC
Regarding Issue 2: duplicate of https://bugs.kde.org/show_bug.cgi?id=397693
Comment 2 Nate Graham 2018-12-11 18:41:45 UTC
Can confirm issue #1 in 5.14.4 and git master. Very odd. Possibly related to the recent single mousearea patch?
Comment 3 NiO 2018-12-11 19:22:04 UTC
(In reply to Nate Graham from comment #2)
> Can confirm issue #1 in 5.14.4 and git master. Very odd. Possibly related to
> the recent single mousearea patch?

Thanks for taking a look. I just double-checked something, it's not just the bottom-left corner.  It's the entire horizontal space under the large icons at the bottom (below Favorites/Applications/Computer/History/Leave).  There's about a 20 pixel-high strip below those icons where search doesn't work.

That might make it slightly less puzzling than just one single corner.
Comment 4 Nate Graham 2018-12-11 19:43:42 UTC
Yep, that makes more sense to me too.
Comment 5 Kai Uwe Broulik 2018-12-12 08:59:44 UTC
Can confirm. The "Search Results" page technically is another Tab pushed into page stack. When the mouse rests (I think it has to move) over the tab bar while the search page enters, you end up accidentally switching to another tab. Likely bug exposed by the tab bar no longer having a delay before it switches tabs.
Comment 6 Filip Fila 2019-01-01 08:37:09 UTC
*** Bug 402423 has been marked as a duplicate of this bug. ***
Comment 7 SimplyCorbett 2019-03-20 16:24:23 UTC
Confirmed in 5.15.3. One of the most annoying bugs I've ever dealt with as it sometimes requires reopening kicker multiple times before search starts to work correctly. But that's my use case, since I open the menu with a keybind and the mouse doesn't move doing so.
Comment 8 Filip Fila 2019-06-21 23:16:13 UTC
I did some poking around. The bug is not reproducible before this commit: 

https://github.com/KDE/plasma-desktop/commit/62f92fd822efb059a07dd77c93158ecba73d1ced#diff-5ab15790503cdc8b5d9ba1fff5cebec2

After removing line 524 ("button.clicked();") in master version of FullRepresentation.qml, the problem goes away.

See: https://phabricator.kde.org/D21978
Comment 9 Nate Graham 2019-06-21 23:20:43 UTC
Nice find! I hope you use `git bisect` for that. :) If you didn't, or you don't know how to use it, let me show you tomorrow!
Comment 10 Eike Hein 2019-06-22 10:54:36 UTC
Patch https://phabricator.kde.org/D21988
Comment 11 Eike Hein 2019-06-22 11:05:01 UTC
Git commit 0628dab8f42ba0d4c4acdb6004d8e5ad98bfdb52 by Eike Hein.
Committed on 22/06/2019 at 11:04.
Pushed by hein into branch 'Plasma/5.16'.

Reject duplicate events with identical coordinates

Summary: BUG:401861

Reviewers: #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D21988

M  +6    -0    applets/kickoff/package/contents/ui/FullRepresentation.qml

https://commits.kde.org/plasma-desktop/0628dab8f42ba0d4c4acdb6004d8e5ad98bfdb52
Comment 12 Filip Fila 2019-07-15 08:06:44 UTC
I'm still experiencing this bug with 5.16.3, see video.

Reproduced in master as well.
Comment 13 Filip Fila 2019-07-15 08:08:25 UTC
Created attachment 121521 [details]
Bug still present in 5.16.3
Comment 14 Björn Feber 2019-09-07 20:59:53 UTC
*** Bug 411678 has been marked as a duplicate of this bug. ***
Comment 15 Filip Fila 2019-12-21 23:37:17 UTC
You can turn off the "Switch tabs on hover" option to work around this.

The other solution with removing the "button.clicked()" line I did in that patch above also works well, I have been using that for some time now.
Comment 16 Nate Graham 2020-01-02 17:31:09 UTC
*** Bug 415338 has been marked as a duplicate of this bug. ***
Comment 17 Nate Graham 2020-01-02 17:31:14 UTC
*** Bug 401365 has been marked as a duplicate of this bug. ***
Comment 18 Nate Graham 2020-01-02 17:31:20 UTC
*** Bug 404655 has been marked as a duplicate of this bug. ***
Comment 19 Nate Graham 2020-01-02 17:31:38 UTC
*** Bug 415314 has been marked as a duplicate of this bug. ***
Comment 20 trmdi 2020-04-19 16:18:11 UTC
*** Bug 420282 has been marked as a duplicate of this bug. ***
Comment 21 Nate Graham 2020-04-19 20:18:35 UTC
Patch: https://phabricator.kde.org/D28985
Comment 22 Nate Graham 2020-04-20 14:16:54 UTC
Git commit 020c67fc8ba30240215f498eb8106635b05ecd04 by Nate Graham, on behalf of Tranter Madi.
Committed on 20/04/2020 at 14:16.
Pushed by ngraham into branch 'Plasma/5.18'.

[Kickoff] Disable tabBar's mouseArea when searching

Summary:
When the root is in the "Search" state, we can safely disable it.

Reviewers: #plasma, hein, ngraham, davidedmundson

Reviewed By: #plasma, ngraham, davidedmundson

Subscribers: davidedmundson, ngraham, bugseforuns, dginovker, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D28985

M  +1    -0    applets/kickoff/package/contents/ui/FullRepresentation.qml

https://commits.kde.org/plasma-desktop/020c67fc8ba30240215f498eb8106635b05ecd04
Comment 23 Patrick Silva 2020-04-29 21:01:13 UTC
*** Bug 420759 has been marked as a duplicate of this bug. ***