Bug 397693 - Kickoff immediately selects entry under mouse in search
Summary: Kickoff immediately selects entry under mouse in search
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Application Launcher (Kickoff) (show other bugs)
Version: 5.12.5
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: 1.0
Assignee: David Edmundson
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2018-08-21 07:29 UTC by Saeid Akbari
Modified: 2019-02-22 22:24 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Saeid Akbari 2018-08-21 07:29:58 UTC
When searching for an application or file in the Kickoff menu, upon each change of the results items (with each character added and thus different results), the entry under mouse automatically gets highlighted which is unwanted and upon enter, runs that. (Always does that, reproducible)

Expected Behavior:

Highlight the top item (the most relevant item) and ignore the mouse pointer position until it actually moves which means the mouse is intended to highlight and select the desired item.

Actual Behavior:

Any item under mouse immediately gets selected, and with each character added, and different results, the item retains its highlight for an instant and then the other entry that comes under mouse gets highlighted.

This is kinda annoying because every time I want to use the Kickoff by pressing Super key and typing program, I have to make sure that mouse pointer isn't in its area! This slows me down a bit, and when I forget to do that, a wrong program or file gets opened which slows me a lot!
Comment 1 Nate Graham 2018-08-21 21:38:46 UTC
My wife actually hit this yesterday and was very confused. She tried the same thing three times and got frustrated before I figured out what was happening and showed her a workaround. Perhaps we should require movement before selecting the item that's under the pointer, if it happens to be positioned where results will show up.
Comment 2 Alexander Mentyu 2018-09-24 15:32:14 UTC
Noticed that searchable entries in Kicker aren't highlighted if cursor was not moved

Operating System: KDE neon Developer Edition
KDE Plasma Version: 5.14.80
Qt Version: 5.11.1
KDE Frameworks Version: 5.51.0
Kernel Version: 4.15.0-34-generic
Comment 3 Saeid Akbari 2018-09-28 21:35:04 UTC
Yup, The issue is resolved after a world update.

OS: Gentoo
Plasma Workspace: 5.12.5 (same as before)
Qt: 5.9.6
KDE Framework: 5.46.0

If anyone still facing it after the update, it'll be reopened.
Comment 4 Nate Graham 2018-09-29 04:13:20 UTC
Definitely not fixed, sadly. Still a problem in all versions of Plasma.
Comment 5 Saeid Akbari 2018-09-29 11:25:58 UTC
Nate Graham, did you update KDE Frameworks? I think that fixed the issue for me as I only updated that and still using the same version of Plasma desktop.
Comment 6 Nate Graham 2018-09-29 15:32:43 UTC
I'm a KDE developer and I run everything from git master. :)
Comment 7 Eike Hein 2018-09-30 13:16:44 UTC
Patch under review: https://phabricator.kde.org/D15855
Comment 8 Eike Hein 2018-10-24 08:01:33 UTC
Git commit 48b32259e73f374a456ed836ba44e3effe2baee5 by Eike Hein.
Committed on 24/10/2018 at 08:01.
Pushed by hein into branch 'master'.

Port Kickoff to shared view component using single-MouseArea pattern

Summary:
This:
* Moves MouseArea out of the item delegate and uses a single MouseArea
  per view.
* Ports all the pages to using a shared view component.

Aside from saving a lot of QObjects, using a single MouseArea also
has the advantage that MouseArea.positionChanged isn't fired when
QQuickWindow synthesizes a hover event per frame, unlike MouseArea
.containsMouse. This fixes a user-reported bug in the search page,
and the same pattern is used by various other UIs we have for
similar reasons.

Reviewers: #plasma, ngraham, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: davidedmundson, ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D15855

M  +42   -52   applets/kickoff/package/contents/ui/ApplicationsView.qml
M  +21   -34   applets/kickoff/package/contents/ui/BaseView.qml
M  +1    -1    applets/kickoff/package/contents/ui/Breadcrumb.qml
M  +39   -56   applets/kickoff/package/contents/ui/FavoritesView.qml
M  +66   -135  applets/kickoff/package/contents/ui/KickoffItem.qml
A  +170  -0    applets/kickoff/package/contents/ui/KickoffListView.qml     [License: GPL (v2+)]
M  +23   -33   applets/kickoff/package/contents/ui/SearchView.qml

https://commits.kde.org/plasma-desktop/48b32259e73f374a456ed836ba44e3effe2baee5