Bug 166593 - Menu bar is too high
Summary: Menu bar is too high
Status: RESOLVED FIXED
Alias: None
Product: konqueror
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Konqueror Developers
URL:
Keywords:
: 166814 166939 167350 168232 170964 181115 183949 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-07-15 06:28 UTC by pierre
Modified: 2009-05-28 00:13 UTC (History)
10 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Screenshot of the problem. (21.81 KB, image/png)
2008-07-15 06:29 UTC, pierre
Details
konqueror with patch from bug 180852 (13.56 KB, image/jpeg)
2009-01-23 17:15 UTC, Roland Leißa
Details
Konqueror's status bar in KDE4 (39.76 KB, image/jpeg)
2009-02-02 18:41 UTC, brad
Details

Note You need to log in before you can comment on or make changes to this bug.
Description pierre 2008-07-15 06:28:28 UTC
Version:           4.00.85 (KDE 4.0.85 (KDE 4.1 >= 20080703)) (using 4.00.98 (KDE 4.0.98 (4.1 RC1)), Debian packages)
Compiler:          cc
OS:                Linux (x86_64) release 2.6.25-2-amd64

Hi

The menu bar (and also the toolbar, but that's less serious there) are taking too much room on the screen when using the Plastique style and Konqueror 4.1 rc1.
I'll attach a screen shot of the problem, but you lose easily 10 pixels, that's quite a lot. It is not that big when using the Phase style, but is still present there.

Some informations about my display : 
  dimensions:    2960x1050 pixels (583x210 millimeters)
  resolution:    129x127 dots per inch       
It's a twinview setup, using nVidia proprietary driver on GeForce 8600...

Thanks
Comment 1 pierre 2008-07-15 06:29:26 UTC
Created attachment 26137 [details]
Screenshot of the problem.

Ok, so here is a screenshot of Konqueror 4.1 using the Plastique style...
Comment 2 Pino Toscano 2008-07-15 15:32:26 UTC
This is not due to the plastique style, but to the fact that the throbber (ie the animated logo) was moved from the toolbar to the menu bar.

There is bug #163519 asking to move back the throbber to the toolbar.
Comment 3 pierre 2008-07-15 15:35:23 UTC
Well, that's not what I'm asking, I think it's a good idea to have the throbber in the menu bar...
Isn't it possible to slightly reduce its size or the border ?
Comment 4 Christophe Marin 2008-07-17 12:22:51 UTC
*** Bug 166814 has been marked as a duplicate of this bug. ***
Comment 5 Christophe Marin 2008-07-20 13:12:16 UTC
*** Bug 166939 has been marked as a duplicate of this bug. ***
Comment 6 Janet 2008-07-21 01:37:55 UTC
It's not only the menu bar and it's also in the default Oxygen style. There's a lot of horizontal unused space between all toolbars, if it's the bookmark toolbar in konqueror or any other toolbar (and the menu bar). Look at this screenshot: http://bugs.kde.org/attachment.cgi?id=26240&action=view which shows KDE3 at the left and KDE4 at the right.
Comment 7 Pino Toscano 2008-07-24 14:57:01 UTC
*** Bug 167350 has been marked as a duplicate of this bug. ***
Comment 8 Ivo Anjo 2008-07-24 15:52:17 UTC
As I had said in # 167350 it's not only on the plastique style, but you can see it with cleanlooks and oxygen too (although it's harder to see with oxygen, but if you put konqueror and dolphin side by side you'll notice).
Comment 9 Pino Toscano 2008-08-03 18:15:44 UTC
*** Bug 168232 has been marked as a duplicate of this bug. ***
Comment 10 Pino Toscano 2008-09-13 11:05:12 UTC
*** Bug 170964 has been marked as a duplicate of this bug. ***
Comment 11 Roland Leißa 2008-12-22 13:42:37 UTC
Still not fixed in Kde 4.2 beta 2. You'll notice the gap with all styles. Especially on small screens or widescreens this bug is very annoying.
Comment 12 Michal Witkowski 2008-12-22 18:29:08 UTC
I can confirm. This is REALLY annoying. Why is konqueror supposed to work nicely with only one theme: Oxygen? :(
Comment 13 S. Burmeister 2008-12-22 18:34:43 UTC
If you read all comments, you will notice that this is a general issue and affects all styles, including oxygen.
Comment 14 Roland Leißa 2009-01-15 18:51:28 UTC
It would be useful if the "K" icon would just have the size of the menu. If you look closely you'll see that it is slightly larger than the captions of the menu. This is surly one reason which causes this large gray area. Another one is bug #180852. I'm not quite sure if these two bugs would resolve this issue completely.
Comment 15 Pino Toscano 2009-01-18 00:06:06 UTC
*** Bug 181115 has been marked as a duplicate of this bug. ***
Comment 16 Roland Leißa 2009-01-23 17:15:36 UTC
Created attachment 30534 [details]
konqueror with patch from bug 180852

I played a bit with oxygen's code. Have a look at Bug #180852. The
attachment shows, how konqui looks now for me. IMHO only the icon has to be
made slightly smaller.
Comment 17 Grósz Dániel 2009-01-23 18:35:41 UTC
If you make the icon smaller, please remember to make it scaled depending on the height of the menu bar and don't just make it statically smaller. In the latter case the problem will occur again as soon as somebody decides to use a style with an even smaller menu bar.
Comment 18 Roland Leißa 2009-02-02 03:00:21 UTC
I suggest to calculate the K-icon like this:
menu-fontsize * 1.5 + 5.
Somebody here who has experience with konqueror's code? Perhaps it would be nice to try that with my patch from bug 171085.
Comment 19 Roland Leißa 2009-02-02 03:01:11 UTC
Sorry meant bug 180852
Comment 20 brad 2009-02-02 18:41:13 UTC
Created attachment 30876 [details]
Konqueror's status bar in KDE4

The wasted space is not only a problem in the menu bar and toolbars, but also with the status bar at the bottom of the window. There are several rows of wasted space above and below the status text. KDE3 did an amazing job with vertical and horizontal space efficiency, KDE4 needs work.
Comment 21 Roland Leißa 2009-02-02 18:45:09 UTC
This is another bug. I've already filed one: bug 180856.
Comment 22 Pino Toscano 2009-02-11 01:01:50 UTC
*** Bug 183949 has been marked as a duplicate of this bug. ***
Comment 23 David Faure 2009-02-20 20:31:29 UTC
Seems much better here in trunk with Qt-4.5-rc1. No idea why, though.
Comment 24 Christoph Feck 2009-04-14 22:19:18 UTC
SVN commit 953953 by cfeck:

Fix menu bar being too tall because of the animated logo

The previous fix for the bug did not work, because Qt's menu
bar does not respect the fixedSize() attribute of the button,
but simply looks at sizeHint(). Also added an event filter to
catch style and font changes.

There is one issue: changing the font size resizes the button,
but the icons are not reloaded. It causes KAnimatedButton to
crash when enabling that code.

Reviewed by dfaure

CCBUG: 166593
CCBUG: 163519
CCBUG: 180856
CCBUG: 181642
CCBUG: 182124


 M  +1 -0      CMakeLists.txt  
 A             konqanimatedlogo.cpp   [License: GPL (v2+)]
 A             konqanimatedlogo_p.h   [License: GPL (v2+)]
 M  +3 -52     konqmainwindow.cpp  
 M  +2 -6      konqmainwindow.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=953953
Comment 25 Christoph Feck 2009-05-28 00:13:13 UTC
SVN commit 973832 by cfeck:

Update animated logo icon size on font size changes

Followup on r953953, finalizes the fix for bug 166593.

NOTE: This requires kdelibs r973828, otherwise -> crash!!!

BUG: 194197
BUG: 166593


 M  +2 -3      konqanimatedlogo.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=973832