Bug 180856 - Konqueror wastes space in the status bar
Summary: Konqueror wastes space in the status bar
Status: RESOLVED FIXED
Alias: None
Product: konqueror
Classification: Applications
Component: general (show other bugs)
Version: 4.1.3
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: Konqueror Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-15 19:00 UTC by Roland Leißa
Modified: 2009-09-08 12:28 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
statusbar comparison (97.98 KB, image/jpeg)
2009-01-15 19:02 UTC, Roland Leißa
Details
Header of konqueror window showing space beneath menu and location bars (47.82 KB, image/png)
2009-04-10 12:17 UTC, Jedd
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Roland Leißa 2009-01-15 19:00:46 UTC
Version:            (using KDE 4.1.3)
OS:                Linux
Installed from:    Gentoo Packages

Konqueror wastes space in its status bar. Below the text is a gray area which just shows nothing. See the screen shot of firefox vs Konqueror in the attachment and have a look at the statusbar.
Comment 1 Roland Leißa 2009-01-15 19:02:47 UTC
Created attachment 30287 [details]
statusbar comparison
Comment 2 David Faure 2009-02-20 20:24:33 UTC
Seems to be better in trunk with Qt-4.5-rc1? Or is it just my choice of fonts?
Comment 3 Jedd 2009-04-10 01:00:29 UTC
Can we close this one off against bug #177494
Comment 4 Roland Leißa 2009-04-10 05:25:14 UTC
Not showing the status bar at all does not resolve this bug. Konqueror still wastes space in the status bar.
Comment 5 Jedd 2009-04-10 12:17:17 UTC
Created attachment 32738 [details]
Header of konqueror window showing space beneath menu and location bars
Comment 6 Jedd 2009-04-10 12:17:43 UTC
Okay then .. can we expand it slightly to include customising / options for space conservation, not just in the status bar?  I was considering creating a docket for the wasted space around the menu and tab bars - that would look just fine on my old 22" monitor, but stuck on a netbook for 6 months and you really start to get frugal with pixels.  I don't really care about the growing number of netbook users out there, although they probably will care as much about wasted real estate.

Image attached shows what I mean.  Simple tests show that space above tab bar belongs entirely to the menu bar, and space above tab bar belongs entirely to location bar.  Tab bar seems to take up slightly more than it needs in the vertical, it's not as pronounced.  I haven't played with modifying tab bar fonts yet to see if that'll reduce the space allocated.  Given the location bar and menu bar space, I suspect it won't.

I'm losing 93 (or 128 including tabs) pixels from the header lump on konqi under KDE4, and 33 from the status bar.  

On a 600 pixel screen this equates to 21-26% of my max'd konqi window not showing me a web page.  Yes, some of that data is essential.  But some isn't, and the fact I'm down by a quarter of my screen explains why I'm especially eager to recover every single row of pixels that I possibly can.
Comment 7 Christoph Feck 2009-04-14 22:19:17 UTC
SVN commit 953953 by cfeck:

Fix menu bar being too tall because of the animated logo

The previous fix for the bug did not work, because Qt's menu
bar does not respect the fixedSize() attribute of the button,
but simply looks at sizeHint(). Also added an event filter to
catch style and font changes.

There is one issue: changing the font size resizes the button,
but the icons are not reloaded. It causes KAnimatedButton to
crash when enabling that code.

Reviewed by dfaure

CCBUG: 166593
CCBUG: 163519
CCBUG: 180856
CCBUG: 181642
CCBUG: 182124


 M  +1 -0      CMakeLists.txt  
 A             konqanimatedlogo.cpp   [License: GPL (v2+)]
 A             konqanimatedlogo_p.h   [License: GPL (v2+)]
 M  +3 -52     konqmainwindow.cpp  
 M  +2 -6      konqmainwindow.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=953953
Comment 8 Jedd 2009-04-15 01:10:21 UTC
I seem to recall the animated logo used to be part of one of the toolbars - such that it would end up on the left-side of my konq window - in 3.5.x.

If this fix fixes it - makes it reduce in size appropriate to the font size of the menu - all good.

But is it worth making it mobile again - part of an existing, or its own dedicated, toolbar component?

I think we have a similar problem with the tabs, and even the location toolbar itself (the draggable dotted hook for the location toolbar seems much taller than the tallbar proper - does that have a similar effect as the animated logo does on the menu section?).
Comment 9 Roland Leißa 2009-09-08 12:28:54 UTC
Is now fixed in kde 4.3