Bug 163519 - put back animated logo among toolbar widgets
Summary: put back animated logo among toolbar widgets
Status: CONFIRMED
Alias: None
Product: konqueror
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: openSUSE Linux
: NOR wishlist
Target Milestone: ---
Assignee: Konqueror Developers
URL:
Keywords:
: 164745 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-06-08 12:11 UTC by Maciej Pilichowski
Modified: 2011-05-10 14:00 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Menu bars (26.18 KB, image/jpeg)
2008-11-02 01:05 UTC, Brenton
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Pilichowski 2008-06-08 12:11:21 UTC
Version:            (using KDE 4.0.4)
Installed from:    SuSE RPMs

In KDE3 I had nice, bug animated logo in toolbar. In KDE4 it is placed in the menu instead of toolbar.

Please revert this to the old design.

Bug, since putting anything in the menu is against KDE HIG.
"Do not put anything other than menus and menu-options in the menus or the menu-bar.".
Comment 1 Christophe Marin 2008-06-23 23:27:35 UTC
*** Bug 164745 has been marked as a duplicate of this bug. ***
Comment 2 Brenton 2008-11-02 01:05:25 UTC
Created attachment 28271 [details]
Menu bars

The screenshot shows the excess space in the Konqueror menubar. Firefox is on top, Konqueror below.
Comment 3 Christoph Feck 2009-04-14 22:19:13 UTC
SVN commit 953953 by cfeck:

Fix menu bar being too tall because of the animated logo

The previous fix for the bug did not work, because Qt's menu
bar does not respect the fixedSize() attribute of the button,
but simply looks at sizeHint(). Also added an event filter to
catch style and font changes.

There is one issue: changing the font size resizes the button,
but the icons are not reloaded. It causes KAnimatedButton to
crash when enabling that code.

Reviewed by dfaure

CCBUG: 166593
CCBUG: 163519
CCBUG: 180856
CCBUG: 181642
CCBUG: 182124


 M  +1 -0      CMakeLists.txt  
 A             konqanimatedlogo.cpp   [License: GPL (v2+)]
 A             konqanimatedlogo_p.h   [License: GPL (v2+)]
 M  +3 -52     konqmainwindow.cpp  
 M  +2 -6      konqmainwindow.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=953953
Comment 4 FiNeX 2010-09-05 21:40:11 UTC
@Christoph: hi! what about the one issue left open on your commit comment???
Comment 5 Christoph Feck 2010-09-06 00:03:51 UTC
FiNeX, this bug got CCed in r953953 because it fixed the "too high menu bar", but the actual request for the throbber moved back to toolbars is still open. There is chance for that to happen in 4.6 for the global D-Bus based menu bar.

As for the follow-up commit to address the mentioned crash, see (the actual) bug 166593.
Comment 6 Janet 2010-11-06 19:28:06 UTC
In Kubuntu's KDE 4.5.x version it is possible to have the throbber in the toolbar (addressbar). Finally it can be adjusted in size to the user's needs again, great. I hope this isn't only a Kubuntu hack. Alas in Kubuntu's Konqueror it is not possible to place the throbber at the right side of the search box. I hope when this enters KDE it will be possible to place the throbber as the most right element in the toolbar without the need to disable the search box.