Summary: | less aggressive offline reboot advertisement | ||
---|---|---|---|
Product: | [Applications] Discover | Reporter: | Harald Sitter <sitter> |
Component: | Updates (offline) | Assignee: | Dan Leinir Turthra Jensen <leinir> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | aleixpol, alex765, nate |
Priority: | HI | Keywords: | usability |
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
See Also: | https://bugs.kde.org/show_bug.cgi?id=436928 | ||
Latest Commit: | https://invent.kde.org/plasma/discover/commit/b6f9d1f117a83b5bc699df77930d4ba3a81cc1ef | Version Fixed In: | 5.23 |
Description
Harald Sitter
2021-05-11 13:20:05 UTC
If anything, with offline updates there's *less* of a need to pester the user to reboot, since their system remains in a safe state, unlike with interactive updates. Maybe we can just notofy the user that the offline updates will be fully applied on the next reboot and not bug them at all. Seems to somewhat overlap with Bug 436928. That could make sense indeed. A possibly relevant merge request was started @ https://invent.kde.org/plasma/discover/-/merge_requests/156 Git commit b6f9d1f117a83b5bc699df77930d4ba3a81cc1ef by Aleix Pol Gonzalez, on behalf of Nate Graham. Committed on 29/08/2021 at 17:03. Pushed by ngraham into branch 'master'. Be less aggressive about reboot notifications with offline updates When we're doing online updates, it's imperative that the user reboot ASAP, as the system is in an unknown state until that happens. However with offline updates, this is not the case, and the system can safely be used indefinitely between the time when the update is downloaded and the time when it's installed during the next reboot. Therefore, when using offline updates, we don't need to badger the user as much to reboot, so this commit disables the persistent "reboot now" notification and adjusts the message shown on the updates page. Hopefully this should alleviate some of the frustration that users have expressed when using distros that enable offline updates by default. Related: bug 438443, bug 437454 FIXED-IN: 5.23 M +1 -1 discover/qml/UpdatesPage.qml M +16 -1 libdiscover/resources/ResourcesUpdatesModel.cpp M +3 -0 libdiscover/resources/ResourcesUpdatesModel.h M +8 -6 notifier/DiscoverNotifier.cpp https://invent.kde.org/plasma/discover/commit/b6f9d1f117a83b5bc699df77930d4ba3a81cc1ef |