Bug 415392

Summary: Kickoff favorites drag/drop icon not always using icon of currently dragged item
Product: [Plasma] plasmashell Reporter: Björn Feber <bfeber>
Component: Application Launcher (Kickoff) widgetAssignee: David Edmundson <kde>
Status: RESOLVED FIXED    
Severity: normal CC: nate, plasma-bugs
Priority: NOR    
Version: master   
Target Milestone: 1.0   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed In: 5.21
Sentry Crash Report:
Attachments: Screenshot

Description Björn Feber 2019-12-20 12:35:15 UTC
Created attachment 124613 [details]
Screenshot

SUMMARY
When clicking and holding the mouse near the top/bottom of a favorites item to move it up/down it can show the icon of the item where you started clicking instead of the one you are actually moving.

STEPS TO REPRODUCE
1. Click and hold the mouse near the top/bottom of a favorites item
2. Move your mouse up/down

OBSERVED RESULT
It shows the icon of the item where you started clicking instead of the one that you are actually moving.

EXPECTED RESULT
It shows the icon of the item you are actually moving.
Comment 1 Nate Graham 2020-01-02 16:35:55 UTC
Can reproduce if I click-and-drag on the bottom-most pixel of a favorites icon.
Comment 2 Nate Graham 2021-01-07 15:41:18 UTC
Git commit 59985c6ed75ac9d63aa92785f913fb6943671f03 by Nate Graham, on behalf of Mikel Johnson.
Committed on 07/01/2021 at 15:41.
Pushed by ngraham into branch 'master'.

Kickoff redesign

This commit completely overhauls Kickoff's user interface!

Original design (UI/UX) discussion
----------------------------------
- https://phabricator.kde.org/T12192
- https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/186

Features / issues
-----------------
New:
- Double pane UI
- Both keyboard and mouse navigation have been overhauled
- Power/Session actions are available in the footer
- Improved RTL support
- Grid view
- All applications view
- Accessibility

Screenshots / Videos
--------------------
Apps

![image](/uploads/b44c0e36d7687b22f9df563ed19aad19/image.png)

Places

![image](/uploads/93ad74bd8e037dc70d4927eb20a8ec29/image.png)

Search

![image](/uploads/f77da9df55bd1f9e75c0b0de96eebfd8/image.png)

Accessibility

https://youtu.be/Vqah3yL5h_E

Bugs fixed
----------
Related: bug 357379, bug 369159, bug 369405, bug 378815, bug 387510, bug 387797, bug 391383, bug 392005, bug 393401, bug 394924, bug 398234, bug 398279, bug 398349, bug 398350, bug 398352, bug 398353, bug 405674, bug 408313, bug 410018, bug 412090, bug 416423, bug 419169, bug 423160, bug 425970, bug 426329, bug 427846, bug 428297

FIXED-IN: 5.21

@teams/vdg

A  +7    -0    applets/kickoff/ABOUT DESIGN CHANGES
D  +0    -71   applets/kickoff/DESIGN-GOALS
M  +6    -6    applets/kickoff/package/contents/config/config.qml
M  +45   -39   applets/kickoff/package/contents/config/main.xml
M  +9    -16   applets/kickoff/package/contents/ui/ActionMenu.qml
A  +144  -0    applets/kickoff/package/contents/ui/ApplicationsGroupView.qml     [License: GPL (v2+)]
M  +128  -46   applets/kickoff/package/contents/ui/ApplicationsView.qml
M  +12   -12   applets/kickoff/package/contents/ui/BaseView.qml
M  +13   -5    applets/kickoff/package/contents/ui/Breadcrumb.qml
M  +0    -2    applets/kickoff/package/contents/ui/ComputerView.qml
D  +0    -227  applets/kickoff/package/contents/ui/ConfigButtons.qml
M  +72   -18   applets/kickoff/package/contents/ui/ConfigGeneral.qml
C  +29   -43   applets/kickoff/package/contents/ui/FavoritesGridView.qml [from: applets/kickoff/package/contents/ui/FavoritesView.qml - 061% similarity]
M  +14   -24   applets/kickoff/package/contents/ui/FavoritesView.qml
R  +2    -3    applets/kickoff/package/contents/ui/FrequentlyUsedView.qml [from: applets/kickoff/package/contents/ui/OftenUsedView.qml - 089% similarity]
M  +599  -451  applets/kickoff/package/contents/ui/FullRepresentation.qml
M  +117  -64   applets/kickoff/package/contents/ui/Header.qml
M  +8    -9    applets/kickoff/package/contents/ui/Kickoff.qml
D  +0    -67   applets/kickoff/package/contents/ui/KickoffButton.qml
D  +0    -60   applets/kickoff/package/contents/ui/KickoffConfigurationButton.qml
A  +106  -0    applets/kickoff/package/contents/ui/KickoffGridItem.qml     [License: GPL (v2+)]
A  +345  -0    applets/kickoff/package/contents/ui/KickoffGridView.qml     [License: GPL (v2+)]
D  +0    -31   applets/kickoff/package/contents/ui/KickoffHighlight.qml
M  +45   -40   applets/kickoff/package/contents/ui/KickoffItem.qml
M  +184  -26   applets/kickoff/package/contents/ui/KickoffListView.qml
A  +145  -0    applets/kickoff/package/contents/ui/LeaveButtons.qml     [License: GPL (v2+)]
R  +13   -11   applets/kickoff/package/contents/ui/PlacesView.qml [from: applets/kickoff/package/contents/ui/LeaveView.qml - 065% similarity]
M  +0    -1    applets/kickoff/package/contents/ui/RecentlyUsedView.qml
M  +25   -13   applets/kickoff/package/contents/ui/SearchView.qml
M  +4    -2    applets/kickoff/package/contents/ui/SectionDelegate.qml
M  +2    -2    applets/kickoff/package/contents/ui/code/tools.js
M  +3    -3    applets/kickoff/package/metadata.desktop

https://invent.kde.org/plasma/plasma-desktop/commit/59985c6ed75ac9d63aa92785f913fb6943671f03