| Summary: | "open externally called folder in new tab" feature should take virtual Desktops and Activities into account | ||
|---|---|---|---|
| Product: | [Applications] dolphin | Reporter: | Eugene Shalygin <eugene.shalygin+bugzilla.kde> |
| Component: | general | Assignee: | Dolphin Bug Assignee <dolphin-bugs-null> |
| Status: | ASSIGNED --- | ||
| Severity: | major | CC: | a.saoutkin, asturm, connectbhatta, edzis, elvis.angelaccio, ericsbinaryworld, fdelgado.it, hoperidesalone, jakubby, kde545, kde, keithhacks-kdebug, meven29, meven, micraft.b, nate, nplatis, phd, piotr.mierzwinski, reavertm, reeves.87, sam, tapiwazimunhu18 |
| Priority: | HI | Keywords: | usability |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| See Also: | https://bugs.kde.org/show_bug.cgi?id=383125 | ||
| Latest Commit: | https://invent.kde.org/system/dolphin/-/commit/70d0154adbae71be40ee6961272a7738ee5c9a9e | Version Fixed In: | Dolphin 23.04.1 on X11; still needs fixing on Wayland |
|
Description
Eugene Shalygin
2019-06-19 17:36:38 UTC
Sorry by screen do you mean a physical monitor, or something else? (In reply to a.saoutkin from comment #1) > Sorry by screen do you mean a physical monitor, or something else? Pardon for the vague term. I mean Plasma virtual desktops. Also, it turns out the feature does not work with activities too: launching Dolphin switches to the activity where it is open already. Yep, we need to make this aware of virtual desktops and activities. There's already an open patch to turn it off, BTW. It should be landing soon enough. *** Bug 412156 has been marked as a duplicate of this bug. *** *** Bug 414384 has been marked as a duplicate of this bug. *** *** Bug 415725 has been marked as a duplicate of this bug. *** *** Bug 416891 has been marked as a duplicate of this bug. *** *** Bug 417951 has been marked as a duplicate of this bug. *** Is there something we can do to expedite the integration of the patch? There is no patch to expedite. Fixing this turns out to be pretty tricky. *** Bug 420002 has been marked as a duplicate of this bug. *** *** Bug 411942 has been marked as a duplicate of this bug. *** *** Bug 423981 has been marked as a duplicate of this bug. *** *** Bug 424996 has been marked as a duplicate of this bug. *** (In reply to Nate Graham from comment #3) > Yep, we need to make this aware of virtual desktops and activities. There's > already an open patch to turn it off, BTW. It should be landing soon enough. I just want to confirm that this is indeed still a problem on current neon unstable, although it may behave differently now: When opening a directory in a different activity on another virtual desktop, dolphin activates the activity which already has dolphin open and moves the window to the same virtual desktop as you were when launching said directory. *** Bug 431543 has been marked as a duplicate of this bug. *** I was going to create a new bug for Dolphin <-> Activities interaction, but it seems that this is the place to comment. Please suggest if new bug has to be created. So, here are my 2 issues. I have one Dolphin window opened in each of my 9 activities, when mounting external LUKS encrypted disk from "Disks & devices", KDE always change the activity and open the mounted directory in some arbitrary Dolphin instance on other activity. To me the destination activity looks random, every reboot it’s different activity (maybe first dolphin window which was started?). It should open it in the Dolphin window of the activity I’m currently on. Similar thing happens when I’m uncompressing a file in Dolphin using right click on the file. It uncompresses the file, switch the activity and focus some other Dolphin window on some other activity not even showing the contents of the uncompressed archive in original nor the wrong activity it switched to. I think that this actually worked on 5.22.x, but I'm not very sure about this. Most people here are reporting the issue with respect to activities, so I would like to affirm that it still holds for virtual desktops as well. For me, it happens every time I "mount and open" a new drive, and it opens in a tab on a window which was on a different virtual desktop -- probably never on the one which already resides on my current desktop! Since KDE promotes so much Activities and Virtual Desktops, maybe this issue should be given some higher priority. A possibly relevant merge request was started @ https://invent.kde.org/system/dolphin/-/merge_requests/529 Nice to hear that! A few days ago I discovered this issue also happen with Okular. When you open a pdf with Okular, and Okular is in another Virtual Desktop, it's opened another Okular instance instead of open Okular with a new tab. (In reply to Varaskkar from comment #20) > Nice to hear that! I am glad. > > A few days ago I discovered this issue also happen with Okular. When you > open a pdf with Okular, and Okular is in another Virtual Desktop, it's > opened another Okular instance instead of open Okular with a new tab. Please report open a bug for okular giving thim this Merge Request (MR) as reference: https://invent.kde.org/system/dolphin/-/merge_requests/529 This will pave the way to standardize this fix to more applications supporting mono-instances mode. Unfortunately my fix will work only on X11 for now. (In reply to Méven Car from comment #21) > Unfortunately my fix will work only on X11 for now. It's still a big step and we're grateful for it :) I leave here the link of the new bug created for Okular. Let's hope it reaches the right people and it can be fixed. https://bugs.kde.org/show_bug.cgi?id=468274 Git commit b99f6f50eef395a3ceb88fb3d4b7357cbbc13c85 by Méven Car. Committed on 20/04/2023 at 08:50. Pushed by meven into branch 'master'. Restrict attaching instances to those on the same activity or same virtual desktop M +25 -0 src/dolphinmainwindow.cpp M +3 -0 src/dolphinmainwindow.h M +33 -11 src/global.cpp https://invent.kde.org/system/dolphin/commit/b99f6f50eef395a3ceb88fb3d4b7357cbbc13c85 Git commit d19800c69198b904ae47cb1e53dfe28f74618eb2 by Méven Car, on behalf of Méven Car. Committed on 21/04/2023 at 09:01. Pushed by meven into branch 'release/23.04'. Restrict attaching instances to those on the same activity or same virtual desktop (cherry picked from commit b99f6f50eef395a3ceb88fb3d4b7357cbbc13c85) M +25 -0 src/dolphinmainwindow.cpp M +3 -0 src/dolphinmainwindow.h M +33 -11 src/global.cpp https://invent.kde.org/system/dolphin/commit/d19800c69198b904ae47cb1e53dfe28f74618eb2 (In reply to Méven from comment #24) > Git commit d19800c69198b904ae47cb1e53dfe28f74618eb2 by Méven Car, on behalf > of Méven Car. > Committed on 21/04/2023 at 09:01. > Pushed by meven into branch 'release/23.04'. > > Restrict attaching instances to those on the same activity or same virtual > desktop > (cherry picked from commit b99f6f50eef395a3ceb88fb3d4b7357cbbc13c85) > > M +25 -0 src/dolphinmainwindow.cpp > M +3 -0 src/dolphinmainwindow.h > M +33 -11 src/global.cpp > > https://invent.kde.org/system/dolphin/commit/ > d19800c69198b904ae47cb1e53dfe28f74618eb2 This patch causes +10s delay during dolphin startup when dolphin is compiled without support for acrivities. See https://bugs.gentoo.org/906170. Reverting it fixes the problem. (In reply to Maciej Mrozowski from comment #25) > (In reply to Méven from comment #24) > > Git commit d19800c69198b904ae47cb1e53dfe28f74618eb2 by Méven Car, on behalf > > of Méven Car. > > Committed on 21/04/2023 at 09:01. > > Pushed by meven into branch 'release/23.04'. > > > > Restrict attaching instances to those on the same activity or same virtual > > desktop > > (cherry picked from commit b99f6f50eef395a3ceb88fb3d4b7357cbbc13c85) > > > > M +25 -0 src/dolphinmainwindow.cpp > > M +3 -0 src/dolphinmainwindow.h > > M +33 -11 src/global.cpp > > > > https://invent.kde.org/system/dolphin/commit/ > > d19800c69198b904ae47cb1e53dfe28f74618eb2 > > This patch causes +10s delay during dolphin startup when dolphin is compiled > without support for acrivities. The gentoo issue highlights the line https://invent.kde.org/system/dolphin/-/blob/v23.04.1/src/global.cpp#L169 which is the currentDesktop (aka virtualdesktop) check, it does not concern the activities part of the patch (which are #ifdef). > See https://bugs.gentoo.org/906170. Reverting it fixes the problem. A possibly relevant merge request was started @ https://invent.kde.org/system/dolphin/-/merge_requests/551 A possibly relevant merge request was started @ https://invent.kde.org/system/dolphin/-/merge_requests/551 Git commit ee8b71e5568f5a56b886b877d63fb345c96b2cce by Méven Car, on behalf of Méven Car. Committed on 24/05/2023 at 10:11. Pushed by meven into branch 'master'. Revert "Restrict attaching instances to those on the same activity or same virtual desktop" This reverts commit b99f6f50eef395a3ceb88fb3d4b7357cbbc13c85. Reintroduces: M +0 -25 src/dolphinmainwindow.cpp M +0 -3 src/dolphinmainwindow.h M +11 -33 src/global.cpp https://invent.kde.org/system/dolphin/-/commit/ee8b71e5568f5a56b886b877d63fb345c96b2cce Git commit ee8b71e5568f5a56b886b877d63fb345c96b2cce by Méven Car, on behalf of Méven Car. Committed on 24/05/2023 at 10:11. Pushed by meven into branch 'master'. Revert "Restrict attaching instances to those on the same activity or same virtual desktop" This reverts commit b99f6f50eef395a3ceb88fb3d4b7357cbbc13c85. Reintroduces: M +0 -25 src/dolphinmainwindow.cpp M +0 -3 src/dolphinmainwindow.h M +11 -33 src/global.cpp https://invent.kde.org/system/dolphin/-/commit/ee8b71e5568f5a56b886b877d63fb345c96b2cce Could someone please explain what the actual fix is merely reverting the previous attempt puts us right back where we started. (In reply to michael from comment #31) > Could someone please explain what the actual fix is merely reverting the > previous attempt puts us right back where we started. https://invent.kde.org/system/dolphin/-/merge_requests/551 The virtual desktop case can be fixed again but I will wait after 23.04.2 so people can have a safe version again. But for the KActivities case it may not be possible. A wayland fix should take time, but should be safer. Git commit 70d0154adbae71be40ee6961272a7738ee5c9a9e by Méven Car. Committed on 27/05/2023 at 08:46. Pushed by meven into branch 'release/23.04'. Revert "Restrict attaching instances to those on the same activity or same virtual desktop" This reverts commit b99f6f50eef395a3ceb88fb3d4b7357cbbc13c85. Reintroduces: (cherry picked from commit ee8b71e5568f5a56b886b877d63fb345c96b2cce) M +0 -25 src/dolphinmainwindow.cpp M +0 -3 src/dolphinmainwindow.h M +11 -33 src/global.cpp https://invent.kde.org/system/dolphin/-/commit/70d0154adbae71be40ee6961272a7738ee5c9a9e Git commit 70d0154adbae71be40ee6961272a7738ee5c9a9e by Méven Car. Committed on 27/05/2023 at 08:46. Pushed by meven into branch 'release/23.04'. Revert "Restrict attaching instances to those on the same activity or same virtual desktop" This reverts commit b99f6f50eef395a3ceb88fb3d4b7357cbbc13c85. Reintroduces: (cherry picked from commit ee8b71e5568f5a56b886b877d63fb345c96b2cce) M +0 -25 src/dolphinmainwindow.cpp M +0 -3 src/dolphinmainwindow.h M +11 -33 src/global.cpp https://invent.kde.org/system/dolphin/-/commit/70d0154adbae71be40ee6961272a7738ee5c9a9e bugzila keeps erroneously closing thos. |