| Summary: | Application Launcher won’t add Leave entries to Favorites | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | aelfinn <aelfinn> |
| Component: | Application Launcher (Kickoff) widget | Assignee: | David Edmundson <kde> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | aelfinn, alexander.lohnau, bugseforuns, claudius.ellsel, codestruct, jens.lallensack, kde, nate, plasma-bugs, postix |
| Priority: | NOR | ||
| Version: | 5.14.1 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Kubuntu | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-desktop/commit/59985c6ed75ac9d63aa92785f913fb6943671f03 | Version Fixed In: | 5.21 |
| Sentry Crash Report: | |||
|
Description
aelfinn
2018-06-01 16:45:06 UTC
It's definitely weird that we have the context menu option and it doesn't work. I think that's reminiscent of Kicker's backend, which supports adding Leave options. I tried to fix it once but couldn't find a clean way to do it. This bug persists in KDE Plasma 5.13.3, tested on KDE neon. This annoyingly silly bug is still present in KDE Plasma 5.14.1, tested on KDE neon and kubuntu 18.10. *** Bug 407775 has been marked as a duplicate of this bug. *** *** Bug 408961 has been marked as a duplicate of this bug. *** Still an issue, but works in "Application Menu". But that has different containers for the system actions and apps. A side effect of this can be sen here https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/33/diffs. Also the leave actions in the "Application Menu" have a different context menu which contains just an action to add/remove it from the favorites. (In reply to Alexander Lohnau from comment #7) > Still an issue, but works in "Application Menu". > > But that has different containers for the system actions and apps. A side > effect of this can be sen here > https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/33/diffs. > > Also the leave actions in the "Application Menu" have a different context > menu which contains just an action to add/remove it from the favorites. Hm, so there might be potential to unify stuff in order to fix this? Are you interested in investigating? Currently very busy with exam preparation, so I am doing only minor/very urgent stuff. This will need some more investigation and there are another few improvements I would like to make to the menu, see https://invent.kde.org/plasma/plasma-workspace/-/issues/6 for a bit of brainstorming :) Hopefully I find next month the tome to have a look into it. No problem :) I subscribed to the GitLab issue now to follow up on the future directions. This will be no longer relevant with the new design because these actions will be visible by default no matter what Kickoff id displaying, and not hidden away in a tab. Git commit 59985c6ed75ac9d63aa92785f913fb6943671f03 by Nate Graham, on behalf of Mikel Johnson. Committed on 07/01/2021 at 15:41. Pushed by ngraham into branch 'master'. Kickoff redesign This commit completely overhauls Kickoff's user interface! Original design (UI/UX) discussion ---------------------------------- - https://phabricator.kde.org/T12192 - https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/186 Features / issues ----------------- New: - Double pane UI - Both keyboard and mouse navigation have been overhauled - Power/Session actions are available in the footer - Improved RTL support - Grid view - All applications view - Accessibility Screenshots / Videos -------------------- Apps  Places  Search  Accessibility https://youtu.be/Vqah3yL5h_E Bugs fixed ---------- Related: bug 357379, bug 369159, bug 369405, bug 378815, bug 387510, bug 387797, bug 391383, bug 392005, bug 393401, bug 398234, bug 398279, bug 398349, bug 398350, bug 398352, bug 398353, bug 405674, bug 408313, bug 410018, bug 412090, bug 415392, bug 416423, bug 419169, bug 423160, bug 425970, bug 426329, bug 427846, bug 428297 FIXED-IN: 5.21 @teams/vdg A +7 -0 applets/kickoff/ABOUT DESIGN CHANGES D +0 -71 applets/kickoff/DESIGN-GOALS M +6 -6 applets/kickoff/package/contents/config/config.qml M +45 -39 applets/kickoff/package/contents/config/main.xml M +9 -16 applets/kickoff/package/contents/ui/ActionMenu.qml A +144 -0 applets/kickoff/package/contents/ui/ApplicationsGroupView.qml [License: GPL (v2+)] M +128 -46 applets/kickoff/package/contents/ui/ApplicationsView.qml M +12 -12 applets/kickoff/package/contents/ui/BaseView.qml M +13 -5 applets/kickoff/package/contents/ui/Breadcrumb.qml M +0 -2 applets/kickoff/package/contents/ui/ComputerView.qml D +0 -227 applets/kickoff/package/contents/ui/ConfigButtons.qml M +72 -18 applets/kickoff/package/contents/ui/ConfigGeneral.qml C +29 -43 applets/kickoff/package/contents/ui/FavoritesGridView.qml [from: applets/kickoff/package/contents/ui/FavoritesView.qml - 061% similarity] M +14 -24 applets/kickoff/package/contents/ui/FavoritesView.qml R +2 -3 applets/kickoff/package/contents/ui/FrequentlyUsedView.qml [from: applets/kickoff/package/contents/ui/OftenUsedView.qml - 089% similarity] M +599 -451 applets/kickoff/package/contents/ui/FullRepresentation.qml M +117 -64 applets/kickoff/package/contents/ui/Header.qml M +8 -9 applets/kickoff/package/contents/ui/Kickoff.qml D +0 -67 applets/kickoff/package/contents/ui/KickoffButton.qml D +0 -60 applets/kickoff/package/contents/ui/KickoffConfigurationButton.qml A +106 -0 applets/kickoff/package/contents/ui/KickoffGridItem.qml [License: GPL (v2+)] A +345 -0 applets/kickoff/package/contents/ui/KickoffGridView.qml [License: GPL (v2+)] D +0 -31 applets/kickoff/package/contents/ui/KickoffHighlight.qml M +45 -40 applets/kickoff/package/contents/ui/KickoffItem.qml M +184 -26 applets/kickoff/package/contents/ui/KickoffListView.qml A +145 -0 applets/kickoff/package/contents/ui/LeaveButtons.qml [License: GPL (v2+)] R +13 -11 applets/kickoff/package/contents/ui/PlacesView.qml [from: applets/kickoff/package/contents/ui/LeaveView.qml - 065% similarity] M +0 -1 applets/kickoff/package/contents/ui/RecentlyUsedView.qml M +25 -13 applets/kickoff/package/contents/ui/SearchView.qml M +4 -2 applets/kickoff/package/contents/ui/SectionDelegate.qml M +2 -2 applets/kickoff/package/contents/ui/code/tools.js M +3 -3 applets/kickoff/package/metadata.desktop https://invent.kde.org/plasma/plasma-desktop/commit/59985c6ed75ac9d63aa92785f913fb6943671f03 |