| Summary: | Persistent user confusion regarding pinned apps vs panel launchers | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Nate Graham <nate> |
| Component: | Panel | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | amichai2, bfeber, bugseforuns, claudius.ellsel, d.bass05, enricobe, epost.kde, hein, kde, keharuan, notuxius, postix |
| Priority: | HI | Keywords: | usability |
| Version: | master | ||
| Target Milestone: | 1.0 | ||
| Platform: | Other | ||
| OS: | Linux | ||
| See Also: |
https://bugs.kde.org/show_bug.cgi?id=396539 https://bugs.kde.org/show_bug.cgi?id=368549 https://bugs.kde.org/show_bug.cgi?id=369185 https://bugs.kde.org/show_bug.cgi?id=416927 https://bugs.kde.org/show_bug.cgi?id=441634 https://bugs.kde.org/show_bug.cgi?id=446031 https://bugs.kde.org/show_bug.cgi?id=427550 |
||
| Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/-/commit/62f47a72a1f2d1114d0bb8db978690cf774a6235 | Version Fixed In: | 6.0 |
| Sentry Crash Report: | |||
|
Description
Nate Graham
2018-02-20 21:49:05 UTC
Yeah, the cost of being overly flexible to the point that it's messy. Concept wise, I think that's sensible. Keeping that neat and layered code-wise will be interesting. I think we'll want it so that containments accept all mimedata of child applets and creatable applets - and that it gets processed by existing applets first. Related bug https://bugs.kde.org/show_bug.cgi?id=315039 *** Bug 315039 has been marked as a duplicate of this bug. *** *** Bug 391762 has been marked as a duplicate of this bug. *** Git commit 8d113b09598c0cd0f92d6395c7c7dec8c65fa735 by Nathaniel Graham.
Committed on 21/05/2018 at 12:54.
Pushed by ngraham into branch 'master'.
[Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager
Summary:
Users get confused by the difference between "Pin to Task Manager" and "Add to Panel (Widget)", and we get bugs about this.
This patch resolves that confusion by only showing "Add to Panel (Widget)" when there's no Task Manager widget.
FIXED-IN: 5.14.0
Test Plan:
Dragging-and-dropping an app from Kicker or Kickoff pins it to the Task Manager if there's a Task Manager, or creates a Panel launcher if there's no Task Manager.
Context menu items:
Task Manager, widgets unlocked:
{F5856628}
Task Manager, Widgets locked:
{F5856629}
No Task Manager, Widgets unlocked:
{F5856630}
Task Manager, Widgets unlocked:
{F5856631}
Reviewers: #plasma, davidedmundson, mart
Reviewed By: #plasma, mart
Subscribers: mart, davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D12969
M +4 -4 applets/kicker/plugin/actionlist.cpp
https://commits.kde.org/plasma-desktop/8d113b09598c0cd0f92d6395c7c7dec8c65fa735
This needs some more discussion and has been reverted for now, sorry :) Why was it reverted? (In reply to gamerbrownie2 from comment #7) > Why was it reverted? Oh sorry, I just read why on Phabricator. My current idea is to revive the patch, but narrow the condition so that it only applies when using an Icons-Only Task Manager (not a regular one). The rationale would be that an IOTM user truly has no use for standalone app launchers in the same panel because the entire purpose of an IOTM is to hold app launchers internally. The type of person who wants a panel full of app icons they can click on to launch doesn't want standalone launcher widgets in that same panel. I just haven't gotten around do doing this yet. Feel free to take a crack if you've got the time! As an alternate suggestion, is it possible to re-route that action on Kicker to add the icon to the (icon only) task manager instead, if that is available? I think that would best reflect what the user wants and not lose any functionality. *** Bug 468892 has been marked as a duplicate of this bug. *** *** Bug 474620 has been marked as a duplicate of this bug. *** A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3330 Git commit 62f47a72a1f2d1114d0bb8db978690cf774a6235 by Niccolò Venerandi. Committed on 10/10/2023 at 14:57. Pushed by niccolove into branch 'master'. Only show "Add to Panel" in Kickoff if there is no task manager and make pinned apps behave as launchers on traditional TMs Only show "Add to Panel" in Kickoff if there is no task manager and make pinned apps behave as launchers on traditional TMs FIXED-IN:6.0 M +3 -5 applets/kicker/plugin/actionlist.cpp M +19 -1 libtaskmanager/tasksmodel.cpp M +22 -0 libtaskmanager/tasksmodel.h https://invent.kde.org/plasma/plasma-workspace/-/commit/62f47a72a1f2d1114d0bb8db978690cf774a6235 |