| Summary: | slotTerminalDirectoryChanged can fire before m_activeViewContainer gets assigned | ||
|---|---|---|---|
| Product: | [Applications] dolphin | Reporter: | Thomas Lübking <thomas.luebking> |
| Component: | general | Assignee: | Dolphin Bug Assignee <dolphin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | arjunak234, belamenso, coder53, emmanuelpescosta099, erasmocaponio, jiri.furst, kirona75, leszek.lesner, Lildirt, michael.weyand, sarah.cipullo, wolfgangwayland7 |
| Priority: | NOR | ||
| Version: | 4.14.0 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/kde-baseapps/62c7120acd96f44d5290fa0e16ae071584e8ee68 | Version Fixed In: | 4.14.3 |
| Sentry Crash Report: | |||
| Attachments: | New crash information added by DrKonqi | ||
|
Description
Thomas Lübking
2014-09-29 11:39:36 UTC
Which Dolphin version? I assume 4.14.x? Yes (sorry) *** Bug 340082 has been marked as a duplicate of this bug. *** Instructions from bug 340082: 1. open dolphin and enable terminal panel 2. from konsole run 'kde-open /path/to/directory' I cannot reproduce the crash with these instructions though, neither in KDE/4.14 nor in master. I confirm the crash. Steps I did to reproduce it. 1. Open dolphin and hit f4 to enable the build in konsole 2. Close dolphin 3. Plug in a usb stick 4. Press open in filemanager in the upcoming notification This produces a dr.konqi crash dialog. All tested on debian with 4.14.0 . Also reproducable on Kubuntu 14.04 with 4.14.2 I assume that a Qt::QueuedConnection binding to the slot would be sufficient, but cannot reproduce the crash either. Is anybody running into this able to successfully compile a patch into dolphin? (For my compile-monkey-user who runs into the crash, the konsole part isn't loaded at all in the self-compiled variant. Something I can't reproduce either...) (In reply to Thomas Lübking from comment #6) > I assume that a Qt::QueuedConnection binding to the slot would be > sufficient Yes, you're probably right. Alternatively, we can move the connect statement further down, which has the benefit that bug 340233 is also fixed :-) Git commit 62c7120acd96f44d5290fa0e16ae071584e8ee68 by Frank Reininghaus. Committed on 23/10/2014 at 21:17. Pushed by freininghaus into branch 'KDE/4.14'. Connect to the currentDirectoryChanged signal after the shell setup This fixes the problem that the view URL may be reset to the Home URL when opening the Terminal Panel while browsing a remote URL. Moreover, it fixes crashes that can occur when the signal is received during the shell setup if the DolphinMainWindow does not have a valid m_activeViewContainer yet. Related: bug 340233 REVIEW: 120726 FIXED-IN: 4.14.3 M +2 -2 dolphin/src/panels/terminal/terminalpanel.cpp http://commits.kde.org/kde-baseapps/62c7120acd96f44d5290fa0e16ae071584e8ee68 *** Bug 340926 has been marked as a duplicate of this bug. *** *** Bug 340952 has been marked as a duplicate of this bug. *** *** Bug 344872 has been marked as a duplicate of this bug. *** *** Bug 345415 has been marked as a duplicate of this bug. *** Created attachment 92953 [details]
New crash information added by DrKonqi
dolphin (4.14.2) on KDE Platform 4.14.2 using Qt 4.8.6
I downloaded a file and tried to open it clicking on the folder icon that appears when download is over. It always crashes
-- Backtrace (Reduced):
#6 DolphinViewContainer::setAutoGrabFocus (this=0x0, grab=grab@entry=false) at ../../../dolphin/src/dolphinviewcontainer.cpp:222
#7 0x00007f888ae60837 in DolphinMainWindow::slotTerminalDirectoryChanged (this=0x1e055e0, url=...) at ../../../dolphin/src/dolphinmainwindow.cpp:315
#8 0x00007f888ae61449 in DolphinMainWindow::qt_static_metacall (_o=0x1e055e0, _id=0, _a=0x7fffb31b7200, _c=<optimized out>) at ./dolphinmainwindow.moc:197
[...]
#10 0x00007f888ae9a6d1 in changeUrl (_t1=..., this=0x1e735d0) at ./terminalpanel.moc:119
#11 TerminalPanel::slotKonsolePartCurrentDirectoryChanged (this=0x1e735d0, dir=...) at ../../../dolphin/src/panels/terminal/terminalpanel.cpp:193
(In reply to sarah.cipullo from comment #13) > Created attachment 92953 [details] > New crash information added by DrKonqi > > dolphin (4.14.2) on KDE Platform 4.14.2 using Qt 4.8.6 > > I downloaded a file and tried to open it clicking on the folder icon that > appears when download is over. It always crashes > > -- Backtrace (Reduced): > #6 DolphinViewContainer::setAutoGrabFocus (this=0x0, grab=grab@entry=false) > at ../../../dolphin/src/dolphinviewcontainer.cpp:222 > #7 0x00007f888ae60837 in DolphinMainWindow::slotTerminalDirectoryChanged > (this=0x1e055e0, url=...) at ../../../dolphin/src/dolphinmainwindow.cpp:315 > #8 0x00007f888ae61449 in DolphinMainWindow::qt_static_metacall > (_o=0x1e055e0, _id=0, _a=0x7fffb31b7200, _c=<optimized out>) at > ./dolphinmainwindow.moc:197 > [...] > #10 0x00007f888ae9a6d1 in changeUrl (_t1=..., this=0x1e735d0) at > ./terminalpanel.moc:119 > #11 TerminalPanel::slotKonsolePartCurrentDirectoryChanged (this=0x1e735d0, > dir=...) at ../../../dolphin/src/panels/terminal/terminalpanel.cpp:193 Please upgrade to Dolphin 4.14.3 *** Bug 349502 has been marked as a duplicate of this bug. *** *** Bug 349736 has been marked as a duplicate of this bug. *** *** Bug 365159 has been marked as a duplicate of this bug. *** |