| Summary: | Disabling the notification message for Clear Clipboard History when answering "no" breaks future history clearing | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Bernd Steinhauser <linux> |
| Component: | Clipboard widget & pop-up | Assignee: | Martin Flöser <mgraesslin> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | b.seeya, bharadwaj.raju777, bugseforuns, contact, cyberbeat, daniel-other+kdebug, jonbien, lv215bd5, nate, piotr.mierzwinski, tb29, turboslak, viniciusbrbio |
| Priority: | HI | ||
| Version: | 5.15.3 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Exherbo | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/commit/62f8e352473c307febe83866a9dd1028e17f6526 | Version Fixed In: | 5.22 |
| Sentry Crash Report: | |||
|
Description
Bernd Steinhauser
2014-06-10 16:04:24 UTC
*** Bug 334327 has been marked as a duplicate of this bug. *** *** Bug 356837 has been marked as a duplicate of this bug. *** *** Bug 391549 has been marked as a duplicate of this bug. *** I noticed it too. Removing the really_clear_history=false false from the config file doesn't immediately solve it. I restored original functionality by also removing really_clear_history from .config/plasmashellrc. Just run grep -r "really_clear_history" inside .config *** Bug 424725 has been marked as a duplicate of this bug. *** *** Bug 434183 has been marked as a duplicate of this bug. *** *** Bug 418900 has been marked as a duplicate of this bug. *** *** Bug 426787 has been marked as a duplicate of this bug. *** *** Bug 435722 has been marked as a duplicate of this bug. *** A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/816 Git commit 62f8e352473c307febe83866a9dd1028e17f6526 by Nate Graham, on behalf of Bharadwaj Raju. Committed on 05/05/2021 at 14:34. Pushed by ngraham into branch 'master'. [applets/clipboard] Change clear dialog to warningContinueCancel Previously the "clear clipboard history?" dialog used `KMessageBox::questionYesNo` which if "don't ask again" is ticked then saves the answer even if No was answered. This can cause the user to not be able to ever clear the clipboard ever again. This commit changes it to `KMessageBox::warningContinueCancel` which doesn't do that, and is more appropriate for the kind of question we're asking. FIXED-IN: 5.22 M +5 -5 klipper/klipper.cpp https://invent.kde.org/plasma/plasma-workspace/commit/62f8e352473c307febe83866a9dd1028e17f6526 Git commit c2e1f4897d34fe0f53606a807dc82c81d2fd97e2 by Nate Graham, on behalf of Bharadwaj Raju. Committed on 05/05/2021 at 14:35. Pushed by ngraham into branch 'master'. Add update script for new klipper clear dialog config Previously, Klipper "clear history" dialog used to not ask again even if user answered No. This was changed so that only a Yes answer will lead to no more asking, by using `warningContinueCancel` instead of `questionYesNo`. Now the behaviour of previous config value `really_clear_history` has inverted: true/undefined => ask again; false => don't ask. This update script migrates old configs to use the new config value, renamed to `klipperClearHistoryAskAgain`. Depends on plasma-workspace!816. A +14 -0 desktoppackage/contents/updates/klipper_clear_config.js https://invent.kde.org/plasma/plasma-desktop/commit/c2e1f4897d34fe0f53606a807dc82c81d2fd97e2 I have a question: is there a GUI for this setting, to be able to change it, after "clicking away" some dialog accidentely? My only solution so far was editing some rc file? (In reply to H.H. from comment #14) > I have a question: is there a GUI for this setting, to be able to change it, > after "clicking away" some dialog accidentely? My only solution so far was > editing some rc file? We should probably add a button for this in the applet settings somewhere. For example see Konsole: in its settings it has a "Enable all 'Do not show again' messages" button. |