Bug 59228 - selecting in multi-column view uses a rectangle, not the sequence
Summary: selecting in multi-column view uses a rectangle, not the sequence
Status: RESOLVED FIXED
Alias: None
Product: konqueror
Classification: Applications
Component: file icon view (show other bugs)
Version: unspecified
Platform: openSUSE Linux
: NOR wishlist
Target Milestone: ---
Assignee: Konqueror Developers
URL:
Keywords:
: 70576 87598 (view as bug list)
Depends on:
Blocks:
 
Reported: 2003-06-01 21:29 UTC by Matthias Hofmann
Modified: 2007-11-03 17:18 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
File selection example (39.22 KB, image/jpeg)
2006-04-18 21:30 UTC, Raúl
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Hofmann 2003-06-01 21:29:21 UTC
Version:           3.1.2 (using KDE 3.1.2)
Installed from:    SuSE
Compiler:          gcc version 2.95.3 20010315 (SuSE)
OS:          Linux (i686) release 2.4.18-4GB

In multi-column view, if I click on a file in konqueror and then click on another file while holding down the shift key, I expect the all the files from the first one I clicked to the second one I clicked to be selected. However, this is not the case. Instead konqueror appears to create some kind of a bounding rectangle, with the first file being the upper left and the second one being the lower right corners, and selecting only the files in the bounding rectangle.

This is very annoying because it makes it very difficult to select a range of files in multi column view.
Comment 1 Benoit Walter 2004-04-09 00:12:27 UTC
*** Bug 70576 has been marked as a duplicate of this bug. ***
Comment 2 Benoit Walter 2004-04-09 00:23:09 UTC
I have just checked the code in QIconView and it actually selects icons which are in the rectangle you are talking about. I agree this is not the best behaviour for konqueror.
Unfortunately, it cannot be fixed in KDE because the QIconView function is not virtual... That means it should be fixed in Qt. Using a rectangle was probably what Trolltech developpers wanted to do, so I am not sure they will agree to change the behaviour.

3 possibilities:
- Change the current behaviour and select items in the right order
- Make it configurable (sth like setMultiSelectionBehaviour()) and use the current behaviour by default
- Same as above, but with your proposal as default

I will file a bug to trolltech and create a patch if they agree with the change.
Comment 3 usa 2004-04-09 07:50:16 UTC
Keyboard selection in Multi-Column-View shows further buggy behaviour.
If pressing shift and extending the selection with the arrow keys sometimes a file isn't selected as expected. Seems that some selections are lost depending on file name lengths. Try it out with the down arrow starting from a selected file and you'll see the bug.

And choose the one and only correct behaviour (no 1 or 3) as default. The current behaviour is stupid.
Comment 4 Christoph Wiesen 2004-06-27 19:26:03 UTC
This is one of the most distracting behaviors to Windows converts... and let's face it many many people come from there and shouldn't be ashamed of that ;) maybe there is a possibility of Trolltech fixing this in the 3.x QT?! I guess you KDE developers have a better understanding of how all things QT work and how to talk to Trolltech than any user.
Comment 5 Janis Blechert 2004-07-27 17:07:25 UTC
"This is one of the most distracting behaviors to Windows converts..."
The behavior is just plain logic, it's a view with collums, so the first file in the second collum is logically the one after the last file in the first collum, so if I select from some file in the first collum to some file in the second collum, all files from wherever the first file down to the last in the first collum and all files from the first file in the second collum to whereever the last file should be selected...
I hope that's logical to everyone and i didn't say something everybody knows anyways...so..well..have a nice time :)
Comment 6 Christoph Wiesen 2004-07-27 19:06:26 UTC
Yes, such a behavior is just plain logic _and_ it's the behavior Windows Explorer uses - which doesn't make it any more logical but this way it's logical and known behavior (to the converts). Ah I hope you get what i mean.

Anyway I hope even more someone finds the time to look into this.
Comment 7 Michael Brade 2004-08-24 15:16:17 UTC
Yes, it seems to have happened already. Using the mouse, the bounding 
rectangle is still used. I'd say that's fine. But using the Keyboard you
can now select all files starting from one (the current) file to a second
file. Works fine here, therefore I'd say close this report.

Cheers,
  Michael
Comment 8 Janis Blechert 2004-08-24 18:54:15 UTC
In konqueror (kde 3.3) it doesn't work
Comment 9 Christoph Wiesen 2004-08-24 20:35:51 UTC
With the mouse it doesn't work 'right' for me either. Using the Keyboard it's ok - if i select one file and then go to the right with the arrow keys while holding shift _all_ files in between are marked.
That's on Debian Unstable's KDE3.3
Comment 10 Frank Brandt 2004-09-28 01:36:53 UTC
It doesn't work with the keyboard nor with the mouse for me. Try to start the selection process on a 3 letter filename .. the keyboard selection process does includes some but not all filenames. It always works, if the first selected filename consist around 10 letters. Sounds wired - I know, but thats how it is here on Gentoo with KDE3.3.0-r1. So I'm getting the same behavior then "usa" in Comment #3.
Comment 11 Alex Radu 2005-01-18 03:23:50 UTC
This has always greatly annoyed me. Hopefully it will be fixed in 3.4.
Comment 12 Raúl 2006-04-18 21:30:46 UTC
Created attachment 15676 [details]
File selection example

2 uncontiguous block selection example.
Comment 13 Raúl 2006-04-18 21:41:46 UTC
Unfortunately it isn't solved even in 3.5.2.

The problem for me is that when you are on the detailed list view you can't select discontinuous blocks of files, since once you have chose the first block, there is no way to select a second one for the following this instructions:
1-Select a contiguous block by doing a rectangle with the mouse. (left click, then drag and release). Now you have some files chosen.
2-We want now to select another block, but the block is not contiguous (see example picture attached). We have the following ways to proceed now:
  a) press ctrl and left click one by one the files.
  b) press ctrl, left click the file that is the begginning of the next block and before releasing the LB, drag the mouse pointer. FAILURE.
  c) press ctrl, left click the blank part of the filed corresponding to the row of the begging file and the file name column. Then drag the mouse before releasing the click. FAILURE.

 On the 2b case, we fail because when we drag the file we are indeed dragging the file (for an eventual drop), not the selection block. This could be considered anyway a desired behaviour.

 On the 2c case, we fail because when we click the blank part of the field the first selection is erased. A success in this case (not erasing the already selected block, would lead to the W$ way).

 So we only have a successful approximation which is the 2a. It works but it is heavily uncomfortable.

  I have find this works in the "icon view". Hope I have explained properly.
Comment 14 Dominik Haumann 2006-04-18 21:55:31 UTC
2c works for me, KDE 3.5.2-r gentoo. Tested with detailed and tree view.
Comment 15 Christoph Wiesen 2006-04-18 22:06:17 UTC
Kubuntu Dapper KDE 3.5.2.
For me 2c does not work. As soon as I click the whitespace to the right of the files I want to add to the already selected bunch the first selection is erased (as described by #13).

This works in MultiColumn / Icon View, but not in the mentioned detailed list and tree views.

Additionally in MultiColum View 2c can be used to add more files to a selection, but it is not possible to de-select files this way (like in windows).

Keep in mind though that this is actually another matter than what the original bug is about. The original bug deals with files that are to be selected consecutively within MultiColumn / Icon view (still present in KDE 3.5.2 as well).

You might want to open another bug report about this.
Comment 16 Stephan Binner 2006-04-19 17:05:51 UTC
*** Bug 87598 has been marked as a duplicate of this bug. ***
Comment 17 Raúl 2006-04-22 11:26:09 UTC
As #16 says this was reported on bug #87598, but I was told that this latter was a duplicate of this one.

Afterwards, I detailed the problem here, even tough I've found #87598 more coincident with the problem I explain.

Do you find neccessary to open a new bug?.
Comment 18 Christoph Wiesen 2006-04-22 11:35:48 UTC
That's how I see it:
87598 is a duplicate of 59228 (the bug here).
Both describe the same problem - selecting files in MultiColumView with the mouse results in a "square" selection instead of the expected "list" selection.
The bug Raúl reported in #13 is a different one. It's about selecting multiple blocks of files and deals with another problem - it's not the "square" selection that's the issue, it's the inability to add more than one block of files to a selection.
I think this bug is well described in #13 and should just be reopened as a new bug.

Maybe the solution to both is even the same piece of code, but the effect both bugs talk about is different. So if a dev gets the time to solve those we should present them with as good information as we can.
Comment 19 Raúl 2006-04-22 12:35:36 UTC
FYI, I've just created new bug report for this, bug #126065.
Comment 20 Stefan Monov 2007-11-03 15:35:53 UTC
Fixed in KDE4.
Comment 21 Jakob Petsovits 2007-11-03 17:18:02 UTC
Whoo! Thanks so much for fixing this :)