Bug 464536 - After clicking the hamburger button to open the menu and then closing it again, sometimes clicks on other things open the menu again
Summary: After clicking the hamburger button to open the menu and then closing it agai...
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: sidebarview (show other bugs)
Version: 5.26.90
Platform: Neon Linux
: HI normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords: regression, wayland-only
: 464687 (view as bug list)
Depends on:
Blocks:
 
Reported: 2023-01-20 06:31 UTC by Raif Coonjah
Modified: 2023-02-07 16:49 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.27
Sentry Crash Report:


Attachments
A screenshot of the "Drop down" menu become some sort of Menu in itself? (570.49 KB, image/png)
2023-01-20 06:31 UTC, Raif Coonjah
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Raif Coonjah 2023-01-20 06:31:51 UTC
Created attachment 155447 [details]
A screenshot of the "Drop down" menu become some sort of Menu in itself?

SUMMARY
***
NOTE: If you are reporting a crash, please try to attach a backtrace with debug symbols.
See https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports
***


STEPS TO REPRODUCE
1. Switch to Wayland
2. Open system settings
3. Toggle "Highlight changed settings" option on 
4. Click on any of the settings options

OBSERVED RESULT
It prevents you from clicking on anything unless you click outside of the Window and click back. 
Also sometimes it opens another smaller window for you to choose your options. [See attached]

EXPECTED RESULT
The drop down menu should close and let you do your thing. 

SOFTWARE/OS VERSIONS
Windows: N/A
macOS: N/A
Linux/KDE Plasma: KDE Neon Testing Edition
(available in About System)
KDE Plasma Version: 5.26.90
KDE Frameworks Version: 5.103.0
Qt Version: 5.15.8

ADDITIONAL INFORMATION
Sorry for any mistakes, this is my first bug report D:
Comment 1 Patrick Silva 2023-01-21 13:19:01 UTC
Can reproduce.

Operating System: Arch Linux 
KDE Plasma Version: 5.26.90
KDE Frameworks Version: 5.102.0
Qt Version: 5.15.8
Graphics Platform: Wayland
Comment 2 Nate Graham 2023-01-23 22:55:08 UTC
This is that wayland bug where pop-up menus get drawn as windows when the button you clicked on to activate the menu is located in an inactive window. We already have a bug report about this somewhere...
Comment 3 Nate Graham 2023-01-23 22:58:07 UTC
There's another issue here too, though, which is that after you click on the hamburger button once, sometimes when you click on other things, the menu opens again, as though the thing you had clicked on was the hamburger menu.

Possibly introduced by https://invent.kde.org/plasma/systemsettings/-/commit/ee6ba5e817e741a073fc59558865194fa2f8f593 or https://invent.kde.org/plasma/systemsettings/-/commit/3fe962232d3f954437d9c2b5cf6489fe3d2c0077.

Let's use this bug report to track that.
Comment 4 Patrick Silva 2023-01-24 00:43:20 UTC
*** Bug 464687 has been marked as a duplicate of this bug. ***
Comment 5 ratijas 2023-01-24 16:46:05 UTC Comment hidden (spam)
Comment 6 Bug Janitor Service 2023-02-02 11:18:46 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/systemsettings/-/merge_requests/193
Comment 7 Arjen Hiemstra 2023-02-07 16:49:19 UTC
Git commit 6e086d2b836592db7096209c68ce346cb3b885c6 by Arjen Hiemstra.
Committed on 07/02/2023 at 11:43.
Pushed by ngraham into branch 'master'.

sidebar: Use a proper checked state for the menu button

We don't generally override down for setting the pressed state of menu
buttons, instead we use the checked state, which is subtly different
visually.

Moreover, using onPressed here causes a weird behaviour where any
subsequent press after clicking the "highlight changed settings" menu
item will re-open the menu on wayland, probably caused by the same
source as https://bugs.kde.org/show_bug.cgi?id=464855 . Using onToggled
instead will prevent this.

M  +6    -2    sidebar/package/contents/ui/HamburgerMenuButton.qml

https://invent.kde.org/plasma/systemsettings/commit/6e086d2b836592db7096209c68ce346cb3b885c6
Comment 8 Nate Graham 2023-02-07 16:49:40 UTC
Git commit a9116045f325d68b29ebff4425ec61a4b85ee06c by Nate Graham, on behalf of Arjen Hiemstra.
Committed on 07/02/2023 at 16:49.
Pushed by ngraham into branch 'Plasma/5.27'.

sidebar: Use a proper checked state for the menu button

We don't generally override down for setting the pressed state of menu
buttons, instead we use the checked state, which is subtly different
visually.

Moreover, using onPressed here causes a weird behaviour where any
subsequent press after clicking the "highlight changed settings" menu
item will re-open the menu on wayland, probably caused by the same
source as https://bugs.kde.org/show_bug.cgi?id=464855 . Using onToggled
instead will prevent this.


(cherry picked from commit 6e086d2b836592db7096209c68ce346cb3b885c6)

M  +6    -2    sidebar/package/contents/ui/HamburgerMenuButton.qml

https://invent.kde.org/plasma/systemsettings/commit/a9116045f325d68b29ebff4425ec61a4b85ee06c