Bug 459201 - Systray's "back" animation should be sliding instead of crossfade
Summary: Systray's "back" animation should be sliding instead of crossfade
Status: CONFIRMED
Alias: None
Product: plasmashell
Classification: Plasma
Component: System Tray widget (other bugs)
Version First Reported In: 5.25.5
Platform: Arch Linux Linux
: NOR wishlist
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-09-16 04:06 UTC by Jin Liu
Modified: 2023-04-10 03:32 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
screencast of the bug (1.28 MB, video/x-matroska)
2022-09-16 04:07 UTC, Jin Liu
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jin Liu 2022-09-16 04:06:44 UTC
SUMMARY
When clicking on an item in systray, the animation is slide-in-from-right. However, when clicking on the "back" arrow in the top-left corner, the animation is crossfade, instead of the reverse slide-out-to-right. This feels inconsistent.

And systray does use slide-to-right animation when switching between items, e.g. between wifi and audio. So why not using it in "back" animation too?

STEPS TO REPRODUCE
1. Click on the "expand" arrow in systray.
2. Click on the "notifition" icon.
3. Click on the "back" arrow in the top-left corner.

OBSERVED RESULT
Crossfade animation

EXPECTED RESULT
Slide-to-right animation

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 5.25.90
KDE Frameworks Version: 5.98.0
Qt Version: 5.15.6

ADDITIONAL INFORMATION
BTW, there is another bug with animation:
1. Click on wifi.
2. Click on arrow to close popup.
3. Click on arrow to expand popup.
4. Click on notification.
5. The animation is slide-to-right. Should be slide-to-left.
Comment 1 Jin Liu 2022-09-16 04:07:16 UTC
Created attachment 152092 [details]
screencast of the bug
Comment 2 Nate Graham 2022-09-16 21:12:23 UTC
As you've observed, it does slide on a horizontal panel. The current state of affairs is actually intentional for a vertical panel. This was the result of many discussions, but we eventually settled on it because:
- a horizontal slide didn't look right given that the direction of motion was clearly supposed to be up-and-down, rather than side-to-side.
- a vertical slide didn't look right either since it resulted in the applets' toolbars also coming along for the ride. This happens with a horizontal slide too, but you don't notice it since all applets generally have the same toolbar height, and when they differ, there's an animation. But doing a vertical slide just felt really weird with the toolbars moving up and down.
Comment 3 Jin Liu 2022-09-17 00:22:32 UTC
(In reply to Nate Graham from comment #2)
> As you've observed, it does slide on a horizontal panel. The current state
> of affairs is actually intentional for a vertical panel. This was the result
> of many discussions, but we eventually settled on it because:

The behavior is the same, horizontal or vertical panel, here in my 5.26beta:
1. Clicking on a hidden tray icon: horizontal slide animation.
2. The animation is generally right-to-left. But if you expanded an visible icon before, it will be left-to-right, which is a bit unexpected.
3. Clicking on "back" arrow of an expanded item: crossfade animation. I think sliding back (opposite of point #1) is a better match, at least in a horizontal panel.

Another small problem is the direction of the horizontal slide. Besides point #2 above, it seems on a horizontal panel, hidden icons are considered to the left of visible icons in animation (despite visually they are to the right):
1. Expand the systray.
2. Click on Notifications (hidden).
3. Click on Network (visible).
The slide animation is right-to-left, as if Notifications is in the left side of Network.
Comment 4 Nate Graham 2022-09-19 19:04:07 UTC
You're right, that's interesting. I didn't realize we had moved to a slide for vertical panels too. I wonder if that was intentional, or it's a bug. But I see what you mean now about the back animation. That should probably always be a slide, you're right.

Also can you file new bug reports about the individual examples of the sliding animation not going in the right direction?
Comment 5 Jin Liu 2022-09-20 01:24:15 UTC
(In reply to Nate Graham from comment #4)
> Also can you file new bug reports about the individual examples of the
> sliding animation not going in the right direction?

OK.
https://bugs.kde.org/show_bug.cgi?id=459419
https://bugs.kde.org/show_bug.cgi?id=459421
Comment 6 Jin Liu 2022-09-20 02:51:49 UTC
BTW, seems the screenshot hotkey (actually, all hotkeys) doesn't work in Overview effect. Is this intentional?
Comment 7 Nate Graham 2022-09-20 19:34:19 UTC
That's expected and essentially unfixable on X11, and already works on Wayland.