Bug 459419 - The transition animation from systray's hidden Notifications icon to visible icons goes in the wrong direction
Summary: The transition animation from systray's hidden Notifications icon to visible ...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: System Tray widget (other bugs)
Version First Reported In: 5.25.90
Platform: Arch Linux Linux
: NOR minor
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2022-09-20 01:08 UTC by Jin Liu
Modified: 2022-09-21 05:06 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.26
Sentry Crash Report:


Attachments
screencast of the bug (439.08 KB, video/x-matroska)
2022-09-20 01:08 UTC, Jin Liu
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jin Liu 2022-09-20 01:08:44 UTC
Created attachment 152240 [details]
screencast of the bug

SUMMARY
When I click between systray's visible icons, or from a hidden icon to a visible one, the new item "slides in", and the direction of the animation is consistent with the order of icons. I.e. if the new item is to the left of the current item, it slides in from left, and vice versa.

However, Notifications, when hidden, is inconsistent. Switching from a hidden Notifications to visible items, the new item slides in from right, despite hidden icons are in the rightmost in systray.

STEPS TO REPRODUCE
1. Expand systray to show hidden icons.
2. Click on Notification.
3. Click on a visible icon. E.g. Network.
4. Watch the transition animation.

OBSERVED RESULT
New items slides in from right to left.

EXPECTED RESULT
New items slides in from left to right.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 5.25.90
KDE Frameworks Version: 5.98.0
Qt Version: 5.15.6
Comment 1 Fushan Wen 2022-09-21 05:03:26 UTC
Git commit cb93c92bd557b04bd02967ec30afa5d6d326a0e4 by Fushan Wen.
Committed on 21/09/2022 at 05:00.
Pushed by fusionfuture into branch 'master'.

applets/systray: fix flip direction from hidden view to visible icons
Related: bug 459421
FIXED-IN: 5.26

M  +1    -1    applets/systemtray/package/contents/ui/SystemTrayState.qml

https://invent.kde.org/plasma/plasma-workspace/commit/cb93c92bd557b04bd02967ec30afa5d6d326a0e4
Comment 2 Fushan Wen 2022-09-21 05:05:47 UTC
Git commit 22e03887a1fbf118e63f865013f7d9303c77a322 by Fushan Wen.
Committed on 21/09/2022 at 05:04.
Pushed by fusionfuture into branch 'Plasma/5.26'.

applets/systray: don't clear old applet before transition

Instead, set opacity:0 and x:0 to avoid invisible applets, because
during a transition the two properties will be changed by the animation.
Related: bug 459421

(cherry picked from commit f7fe49f34458ac0e28d7960cf03b835cefa91976)

M  +5    -6    applets/systemtray/package/contents/ui/PlasmoidPopupsContainer.qml

https://invent.kde.org/plasma/plasma-workspace/commit/22e03887a1fbf118e63f865013f7d9303c77a322
Comment 3 Fushan Wen 2022-09-21 05:06:03 UTC
Git commit ff77ec4f2eea93706e2d86d786b10531e5f1c4fb by Fushan Wen.
Committed on 21/09/2022 at 05:05.
Pushed by fusionfuture into branch 'Plasma/5.26'.

applets/systray: fix flip direction from hidden view to visible icons
Related: bug 459421
FIXED-IN: 5.26
(cherry picked from commit cb93c92bd557b04bd02967ec30afa5d6d326a0e4)

M  +1    -1    applets/systemtray/package/contents/ui/SystemTrayState.qml

https://invent.kde.org/plasma/plasma-workspace/commit/ff77ec4f2eea93706e2d86d786b10531e5f1c4fb