Bug 459421 - The transition animation when clicking on systray's hidden Notifications icon changes direction depending on previous actions
Summary: The transition animation when clicking on systray's hidden Notifications icon...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: System Tray (show other bugs)
Version: 5.25.90
Platform: Arch Linux Linux
: NOR minor
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2022-09-20 01:23 UTC by Jin Liu
Modified: 2022-09-21 05:06 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.26


Attachments
screencast of the bug (594.14 KB, video/x-matroska)
2022-09-20 01:23 UTC, Jin Liu
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jin Liu 2022-09-20 01:23:37 UTC
Created attachment 152242 [details]
screencast of the bug

SUMMARY
When clicking on the hidden Notifications icon, it can slide in from either left or right, depending on my previous actions with systray.

STEPS TO REPRODUCE
1. Click on a visible Network icon.
2. Click on Network again to close it.
3. Expand the systray and click on the hidden Notifications icon.
4. Note the direction of the transition animation.
5. Click on a visible Network icon.
6. Click on the "back" arrow at the top-left corner of Network.
7. Click on the hidden Notifications icon.
8. Note the direction of the transition animation.

OBSERVED RESULT
left-to-right
right-to-left

EXPECTED RESULT
left-to-right
left-to-right

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 5.25.90
KDE Frameworks Version: 5.98.0
Qt Version: 5.15.6
Comment 1 Jin Liu 2022-09-20 02:53:32 UTC
Sorry, the expected result was meant to be:
right-to-left
right-to-left
Comment 2 Fushan Wen 2022-09-20 10:24:15 UTC
Caused by the QQC2 porting
Comment 3 Fushan Wen 2022-09-21 04:46:24 UTC
Git commit b45660f2b84af38393afc1ed5e5af7649d04fcb4 by Fushan Wen.
Committed on 21/09/2022 at 04:43.
Pushed by fusionfuture into branch 'master'.

applets/systray: reset index history in hidden view
FIXED-IN: 5.26

M  +1    -0    applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

https://invent.kde.org/plasma/plasma-workspace/commit/b45660f2b84af38393afc1ed5e5af7649d04fcb4
Comment 4 Fushan Wen 2022-09-21 05:03:34 UTC
Git commit cb93c92bd557b04bd02967ec30afa5d6d326a0e4 by Fushan Wen.
Committed on 21/09/2022 at 05:00.
Pushed by fusionfuture into branch 'master'.

applets/systray: fix flip direction from hidden view to visible icons
Related: bug 459419
FIXED-IN: 5.26

M  +1    -1    applets/systemtray/package/contents/ui/SystemTrayState.qml

https://invent.kde.org/plasma/plasma-workspace/commit/cb93c92bd557b04bd02967ec30afa5d6d326a0e4
Comment 5 Fushan Wen 2022-09-21 05:05:39 UTC
Git commit 22e03887a1fbf118e63f865013f7d9303c77a322 by Fushan Wen.
Committed on 21/09/2022 at 05:04.
Pushed by fusionfuture into branch 'Plasma/5.26'.

applets/systray: don't clear old applet before transition

Instead, set opacity:0 and x:0 to avoid invisible applets, because
during a transition the two properties will be changed by the animation.
Related: bug 459419

(cherry picked from commit f7fe49f34458ac0e28d7960cf03b835cefa91976)

M  +5    -6    applets/systemtray/package/contents/ui/PlasmoidPopupsContainer.qml

https://invent.kde.org/plasma/plasma-workspace/commit/22e03887a1fbf118e63f865013f7d9303c77a322
Comment 6 Fushan Wen 2022-09-21 05:05:55 UTC
Git commit 1fe3c586d61879d48cbeb3f1efad752ef183f8ad by Fushan Wen.
Committed on 21/09/2022 at 05:05.
Pushed by fusionfuture into branch 'Plasma/5.26'.

applets/systray: reset index history in hidden view
FIXED-IN: 5.26
(cherry picked from commit b45660f2b84af38393afc1ed5e5af7649d04fcb4)

M  +1    -0    applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

https://invent.kde.org/plasma/plasma-workspace/commit/1fe3c586d61879d48cbeb3f1efad752ef183f8ad
Comment 7 Fushan Wen 2022-09-21 05:06:11 UTC
Git commit ff77ec4f2eea93706e2d86d786b10531e5f1c4fb by Fushan Wen.
Committed on 21/09/2022 at 05:05.
Pushed by fusionfuture into branch 'Plasma/5.26'.

applets/systray: fix flip direction from hidden view to visible icons
Related: bug 459419
FIXED-IN: 5.26
(cherry picked from commit cb93c92bd557b04bd02967ec30afa5d6d326a0e4)

M  +1    -1    applets/systemtray/package/contents/ui/SystemTrayState.qml

https://invent.kde.org/plasma/plasma-workspace/commit/ff77ec4f2eea93706e2d86d786b10531e5f1c4fb