Bug 450223 - Screenshare dialog doesn't react to Enter
Summary: Screenshare dialog doesn't react to Enter
Status: RESOLVED FIXED
Alias: None
Product: xdg-desktop-portal-kde
Classification: Plasma
Component: general (show other bugs)
Version: 5.24.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
: 464744 (view as bug list)
Depends on:
Blocks:
 
Reported: 2022-02-14 14:55 UTC by Nicolas Fella
Modified: 2023-01-24 19:19 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.24.3
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Fella 2022-02-14 14:55:50 UTC
STEPS TO REPRODUCE
1. Start screensharing
2. Dialog with list of monitors open, one entry is selected
3. Press enter

OBSERVED RESULT
Nothing happens

EXPECTED RESULT
The currently selected monitor is shared

SOFTWARE/OS VERSIONS
KDE Plasma Version: master
KDE Frameworks Version: master
Qt Version: 5.15-kde
Comment 1 Nate Graham 2022-02-15 21:02:48 UTC
Derp
Comment 2 Nate Graham 2022-02-16 20:19:19 UTC
Looks like the whole list view doesn't get keyboard focus and I can't figure out how to do it.
Comment 3 Bug Janitor Service 2022-02-28 16:32:13 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1494
Comment 4 Aleix Pol 2022-02-28 16:36:42 UTC
*** Bug 450931 has been marked as a duplicate of this bug. ***
Comment 5 Nate Graham 2022-02-28 17:28:46 UTC
Git commit a667b99dee26eb3cfd195ec09dbc04502ecb8cff by Nate Graham, on behalf of Aleix Pol Gonzalez.
Committed on 28/02/2022 at 17:28.
Pushed by ngraham into branch 'master'.

SystemDialog: Allow accepting the dialogs with the keyboard

If there's an enabled Ok button, it will accept the dialog when Enter is
pressed as it reaches the dialog.
FIXED-IN: 5.24.3

M  +10   -1    components/dialogs/SystemDialog.qml

https://invent.kde.org/plasma/plasma-workspace/commit/a667b99dee26eb3cfd195ec09dbc04502ecb8cff
Comment 6 Nate Graham 2022-02-28 17:29:27 UTC
Git commit b1577e100136e5b3446fcfc74d76c61c674ceaca by Nate Graham, on behalf of Aleix Pol Gonzalez.
Committed on 28/02/2022 at 17:29.
Pushed by ngraham into branch 'Plasma/5.24'.

SystemDialog: Allow accepting the dialogs with the keyboard

If there's an enabled Ok button, it will accept the dialog when Enter is
pressed as it reaches the dialog.
FIXED-IN: 5.24.3


(cherry picked from commit a667b99dee26eb3cfd195ec09dbc04502ecb8cff)

M  +10   -1    components/dialogs/SystemDialog.qml

https://invent.kde.org/plasma/plasma-workspace/commit/b1577e100136e5b3446fcfc74d76c61c674ceaca
Comment 7 Aleix Pol 2023-01-24 19:19:11 UTC
*** Bug 464744 has been marked as a duplicate of this bug. ***