447948 – Lift gamma gain

Bug 447948 - Lift gamma gain

Summary: Lift gamma gain

Status:	RESOLVED FIXED

Alias:	None

Product:	kdenlive
Classification:	Applications
Component:	Video Effects & Transitions (show other bugs)
Version:	unspecified
Platform:	Other All

Importance:	NOR normal
Target Milestone:	---
Assignee:	Vincent PINON

URL:
Keywords:

Depends on:
Blocks:

Reported:	2022-01-04 22:01 UTC by diekuhrannte@web.de
Modified:	2023-10-03 13:24 UTC (History)
CC List:	4 users (show)

See Also:
Latest Commit:	https://invent.kde.org/multimedia/kdenlive/-/commit/b096aed4e93ca44cdd2d8c3f1072baf881780048
Version Fixed In:	23.08.0
Sentry Crash Report:

Flags:	fritzibaby: Brainstorm+

Attachments
Lift Gamma Gain effect behavior (2.74 MB, video/mp4) 2022-01-04 22:54 UTC, Bernd	Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.

Description diekuhrannte@web.de 2022-01-04 22:01:38 UTC

SUMMARY
***
When moving the dot in the color wheel of Lift, nothing happens. 
***


STEPS TO REPRODUCE
1.  Open Lift/gamma/gain
2.  using Lift color whell
3.  nothing happens

OBSERVED RESULT


EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: 10
Linux Manjaro 

everything up to date

ADDITIONAL INFORMATION
Please forgive me, my English is so bad and I hardly understand what I have to enter here. But the error is with all Kdenlive versions, as well as with the AppImage and on Linux and Windows. With Shotcut, the almost same tool is perfectly fine.
Thanks

Comment 1 Bernd 2022-01-04 22:54:31 UTC

Created attachment 145117 [details]
Lift Gamma Gain effect behavior

Comment 2 Bernd 2022-01-04 22:56:39 UTC

Confirm behavior as described (kdenlive 21.12, Windows 11). See attached screen recording. Besides the described errors there is additional weird behavior present. See also my comments in the kdenlive forum (https://forum.kde.org/viewtopic.php?f=265&t=162853#p451794)

Comment 3 emohr 2022-02-23 15:34:36 UTC

I can confirm this behavior. If you only move the lift "dot" nothing happen. Adjust RGB numbers, nothing happen. Only when you move the slider then the color start to change and you can adjust lift with the "dot" or RGB number as expected.

Comment 4 Andrew Buck 2023-02-02 00:14:30 UTC

A quick summary of what the video shows.  Changing the slider bars up/down on the lift/gamma/gain effect causes the color selected on the color wheel associated with that slider to wander around to random colors as the slider moves up and down.

I experienced the same thing when running the flatpack version of kdenlive, but if I run the native installed version (from the ppa) I don't experience this effect.

Comment 5 diekuhrannte@web.de 2023-07-10 15:43:59 UTC

This is the same bug as here: https://bugs.kde.org/show_bug.cgi?id=436762
Maybe you could combine the two?

Comment 6 emohr 2023-07-12 17:36:15 UTC

Added to the tracker: https://invent.kde.org/multimedia/kdenlive/-/issues/1628

Comment 7 Jean-Baptiste Mardelle 2023-07-27 11:17:49 UTC

Git commit 248fa19000aceae1eccdef569a7aed2334c20997 by Jean-Baptiste Mardelle.
Committed on 27/07/2023 at 13:17.
Pushed by mardelle into branch 'release/23.08'.

Fix Lift Gamma Gain not updating when lift slider was moved, and color reset when slider was moved to 0.
Fixes #1405
Related: bug 470005
FIXED-IN: 23.08.0

M  +36   -11   src/assets/view/widgets/colorwheel.cpp

https://invent.kde.org/multimedia/kdenlive/-/commit/248fa19000aceae1eccdef569a7aed2334c20997

Comment 8 diekuhrannte@web.de 2023-08-28 17:38:41 UTC

Wonderful - the bug is gone. However, you have to reinsert the filter and best start a new project, otherwise there is still (sometimes) this discoloration to light-yellow or dark-blue.
Thank you very much.

Comment 9 diekuhrannte@web.de 2023-08-29 15:48:20 UTC

Unfortunately, I see that the problem is still not solved. When I open an old project, Lift/gamma/gain still behaves exactly as it used to. After moving the slider and "reset effect" and moving it again, the image becomes either light and yellow or dark and blue. Because still the blue is not changed then.
Even if I delete the effect in the old project and insert it again - the same.
Also with a newly inserted clilp the same problem.
See the screenshot.
Kdenlive Version 23.08.0 at Manjaro Linux,  updated today.
https://tube.tchncs.de/w/kobkBQaCYBQ7gkSuG6BiGi
Also with a newly inserted clip the same problem.

Comment 10 Jean-Baptiste Mardelle 2023-09-26 08:49:39 UTC

Git commit cda16f42b0e6991e368cf39b144d10a6cc10432f by Jean-Baptiste Mardelle.
Committed on 26/09/2023 at 10:49.
Pushed by mardelle into branch 'master'.

Make Lift work as expected by most users
Related: bug 436762

M  +4    -7    src/assets/view/widgets/colorwheel.cpp
M  +1    -0    src/assets/view/widgets/colorwheel.h
M  +14   -13   src/assets/view/widgets/lumaliftgainparam.cpp

https://invent.kde.org/multimedia/kdenlive/-/commit/cda16f42b0e6991e368cf39b144d10a6cc10432f

Comment 11 Jean-Baptiste Mardelle 2023-10-03 13:24:07 UTC

Git commit b096aed4e93ca44cdd2d8c3f1072baf881780048 by Jean-Baptiste Mardelle.
Committed on 03/10/2023 at 11:28.
Pushed by mardelle into branch 'release/23.08'.

Make Lift work as expected by most users
Related: bug 436762

M  +4    -7    src/assets/view/widgets/colorwheel.cpp
M  +1    -0    src/assets/view/widgets/colorwheel.h
M  +14   -13   src/assets/view/widgets/lumaliftgainparam.cpp

https://invent.kde.org/multimedia/kdenlive/-/commit/b096aed4e93ca44cdd2d8c3f1072baf881780048