Bug 470005 - Lift/Gamma/Gain bugs (slider resets color wheel & color jumps around)
Summary: Lift/Gamma/Gain bugs (slider resets color wheel & color jumps around)
Status: RESOLVED FIXED
Alias: None
Product: kdenlive
Classification: Applications
Component: Effects & Transitions (show other bugs)
Version: 23.04.1
Platform: Flatpak Linux
: NOR normal
Target Milestone: ---
Assignee: Jean-Baptiste Mardelle
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-05-19 15:32 UTC by Hyuri
Modified: 2023-07-27 11:17 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 23.08.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Hyuri 2023-05-19 15:32:36 UTC
SUMMARY
Hi!

Firstly, thank you very much for the recent (23.04.1) fixes and improvements to the Lift/Gamma/Gain effect! It's a joy to use now!

Only issue is: I'm still experiencing a bug (1) I was experiencing before, and found a new one (2).
They seem related, so I bundled them together in this report, but let me know if I should break them down into individual reports.

BUG #1
Sometimes the dot in the color wheel randomly jumps around when I move its slider up and down. The color changes randomly, accordingly. I tried to reproduce it again but it only happens sometimes. I don't know how to reproduce it. I guess simply using it for long enough, pasting the effect onto other clips, tweaking, adding other effects before and/or after, moving effects around, perhaps.

I'm guessing it might have something to do with having one or — somehow — more than one of the RGB values highlighted and being changed at the same time as the slider when I scroll it.

STEPS TO REPRODUCE BUG #1
I can't reliably reproduce it. All I did was:
1. Add a Lift/Gamma/Gain effect to a clip
2. Move the Gain's slider up and down using Ctrl + Scroll
3. You should see the dot in the color wheel jumping around to random points

BUG #2
After shifting the colors (hue & saturation) in the color wheel, Ctrl + Scrolling or Shift + Scrolling the luma slider to zero (0.000) resets the color wheel. Happens to all three — Lift, Gamma or Gain. Resetting (Right Clicking) the Lift's slider resets its color wheel as well (because Lift's default is 0.000, while Gamma and Gain's defaults are 1.000). Doesn't happen when I bring the slider to zero by grabbing it with Left Click and moving it with the mouse.

STEPS TO REPRODUCE BUG #2'S GAMMA OR GAIN ISSUE
1. Add Lift/Gamma/Gain effect to a clip
2. Shift the colors in the Gamma or Gain's color wheels
3. Using Ctrl + Scroll, lower the Gamma or Gain's luma slider all the way down to zero (0.000)
4. See how the color wheel has reset itself

STEPS TO REPRODUCE BUG #2'S LIFT SLIDER SCROLL ISSUE
1. Add Lift/Gamma/Gain effect to a clip
2. Shift the colors in the Lift's color wheel
3. Move the Lift's luma slider up or down any amount
4. Shift + Scroll the Lift's luma slider to zero (0.0000)
5. See how the color wheel has reset itself

STEPS TO REPRODUCE BUG #2'S LIFT SLIDER RESET ISSUE
1. Add Lift/Gamma/Gain effect to a clip
2. Shift the colors in the Lift's color wheel
3. Move the Lift's luma slider up or down any amount
4. Reset the Lift's slider by Right Clicking on it
5. See how the color wheel has reset itself as well

OBSERVED RESULT BUG #2
The color wheel resets itself when you bring the luma slider to zero (0.000). The Lift's color wheel also resets itself when you reset the slider associated with it.

The hue and saturation adjustments the user made are lost.

EXPECTED RESULT BUG #2
The color wheel (hue and saturation) should not be affected by its associated luma slider.

The luma adjustment should be decoupled from the hue and saturation adjustment so that we don't lose hue and saturation adjustments while changing luma.

SOFTWARE/OS VERSIONS
Linux / DE: Pop!_OS 22.04 / Gnome 42.5
KDE Frameworks Version: 5.106.0
Qt Version: 5.15.19
Comment 1 Hyuri 2023-05-19 15:42:39 UTC
I found a bug in the tracker that is the same issue as BUG #1 but, in my case, I couldn't reproduce it by resetting the effect. It might be the same issue but only happening sometimes, under certain conditions in my case.
https://bugs.kde.org/show_bug.cgi?id=448467

Video that shows what BUG #1 looks like:
https://disk.yandex.ru/i/qO-fKzGbbGdXqQ
Comment 2 Jean-Baptiste Mardelle 2023-05-19 19:18:46 UTC
Git commit e1e8641c61cadb5709ce43c874a03166a750f0cf by Jean-Baptiste Mardelle.
Committed on 19/05/2023 at 19:18.
Pushed by mardelle into branch 'release/23.04'.

Fix color wheel resetting color on mouse wheel.

M  +19   -3    src/assets/view/widgets/colorwheel.cpp

https://invent.kde.org/multimedia/kdenlive/commit/e1e8641c61cadb5709ce43c874a03166a750f0cf
Comment 3 Jean-Baptiste Mardelle 2023-07-27 11:17:41 UTC
Git commit 248fa19000aceae1eccdef569a7aed2334c20997 by Jean-Baptiste Mardelle.
Committed on 27/07/2023 at 13:17.
Pushed by mardelle into branch 'release/23.08'.

Fix Lift Gamma Gain not updating when lift slider was moved, and color reset when slider was moved to 0.
Fixes #1405
Related: bug 447948
FIXED-IN: 23.08.0

M  +36   -11   src/assets/view/widgets/colorwheel.cpp

https://invent.kde.org/multimedia/kdenlive/-/commit/248fa19000aceae1eccdef569a7aed2334c20997