SUMMARY the tool: Lift/gamma/gain: The choice of a color in "lift" has no effect on the image, unless in B a value other than 0 is chosen. If you choose a negative value in B, the colors will change in a different way than expected. Is this intentional? With gamma and gain, the color wheel behaves normally. Thanks in advance STEPS TO REPRODUCE 1. 2. 3. OBSERVED RESULT EXPECTED RESULT SOFTWARE/OS VERSIONS Linux/Manjaro XFCE: (available in About System) KDE Plasma Version: KDE Frameworks Version: Qt Version: ADDITIONAL INFORMATION
Thank you for reporting. I can confirm this behavior. Lift in general doesn't change the value when you move the point in the color circle. added to https://invent.kde.org/multimedia/kdenlive/-/issues/973
Title updated. Lift does not respond to moving the colors as long as slider B is set to 0.00
Thanks for your report! It is true that the color is not changed for as long as the sliders value is zero (btw no matter for which of the three), but that is somehow expected, because if the sliders value is zero all color values (r,g,b) are always zero too so why should these values change if you move the point on the color wheel…?
Bei Gamma und bei Verstärken kann man die Farbe so wunderbar verändern, indem man den Punkt in dem Farbrad mit der Maus in die gewünschte Richtung verschiebt. (So funktioniert es auch bei Shotcut und allen anderen Anwendungen.) Bei Anheben geht das leider nicht, da muss man direkt die Werte für R, G oder B anwählen und verstellen. With Gamma and Gain, you can change the color wonderfully by moving the point in the color wheel in the desired direction with the mouse. (This is also how it works with Shotcut and all other applications.) Unfortunately, this does not work with lift, where you have to directly select the values for R, G or B and adjust them.
Reopening. You can see the issue if you compare it to shortcut. I am not sure about what the right behavior is, but something is wrong
Hello Julius, this age-old error is easily explained: When adjusting the colors in Lift, the color wheel cannot be used correctly unless a numerical value other than 0.000 is already set. But even then the shifting in the color wheel is not correct, but only very weak. Everything works very nicely with Gamma and Gain. There the default values are 1.000, with Lift it is 0.000 - probably the error can be found there.
See: https://invent.kde.org/multimedia/kdenlive/-/commit/99e80f993f1aceb21228713399976d9079d174e5 https://invent.kde.org/multimedia/kdenlive/-/commit/6568db0f23dc2bea08c64c8fd95b66debd88bc30 https://invent.kde.org/multimedia/kdenlive/-/commit/aa43937b827d9c7cec0c34ec6d928af073ec6351
I would like to point out again how important LGG is for color correction. And it is yes the color wheel only faulty at Lift. And there, strangely enough, the default value is always 0.000, in contrast to the values for Gamma and Gain. Wouldn't it be helpful to have a closer look at Shotcut? The filter is called Color Grading, but the default values there are all at 0%. What can I do to correct this bug? I can't program, but I can test a lot.
And there is another bug with lift/gamma/gain: If you change the brightness with the slider at Lift, reset this action with "Reset Effect" and then move it again, the image becomes yellowish if you increase the brightness and bluish if you decrease it, because the value for B remains and is not changed anymore. Then the controls for Gamma and Gain still work normally. Unless you also shift the brightness here and then do Rest Effect, then there is the same error. This error can only be corrected by deleting the effect and then reinserting it.
Here is a screenshot of this bug https://tube.tchncs.de/w/ceX9u6peDPfX8Y7bCUp363
Some bugs may have been fixed. But the main problem remains: 1st bug: If you move the center of the color circle of Lift, nothing happens, unless the default value 0,0 was changed with the slider. Then the color changes. The intensity depends on how much the slider is moved. This is most likely not intentional but an error. Especially since this is not the case with gamma and gain. Not even with shotcut and other video editors. 2nd error: If you change the brightness with one of the three sliders and then reset the effect with "Reset Effect", then blue remains unchanged when you move it further. I.e. the slider makes everything only light-yellow or dark-blue. https://tube.tchncs.de/w/8nHxmiUeoZpZjywZTmjcDw
Git commit cda16f42b0e6991e368cf39b144d10a6cc10432f by Jean-Baptiste Mardelle. Committed on 26/09/2023 at 10:49. Pushed by mardelle into branch 'master'. Make Lift work as expected by most users Related: bug 447948 M +4 -7 src/assets/view/widgets/colorwheel.cpp M +1 -0 src/assets/view/widgets/colorwheel.h M +14 -13 src/assets/view/widgets/lumaliftgainparam.cpp https://invent.kde.org/multimedia/kdenlive/-/commit/cda16f42b0e6991e368cf39b144d10a6cc10432f
Git commit b096aed4e93ca44cdd2d8c3f1072baf881780048 by Jean-Baptiste Mardelle. Committed on 03/10/2023 at 11:28. Pushed by mardelle into branch 'release/23.08'. Make Lift work as expected by most users Related: bug 447948 M +4 -7 src/assets/view/widgets/colorwheel.cpp M +1 -0 src/assets/view/widgets/colorwheel.h M +14 -13 src/assets/view/widgets/lumaliftgainparam.cpp https://invent.kde.org/multimedia/kdenlive/-/commit/b096aed4e93ca44cdd2d8c3f1072baf881780048