Created attachment 144208 [details] Selected folder icon becomes white For non hidden and those with no preview the icon of the selected folder becomes white folder, see attached image for more info.
Can confirm in Dolphin's Compact and Details view in both Dolphin and the file dialog; seems to work fine in both of their Icons views. This suggests that the issue is in Breeze Icons or KIconLoader. Moving to Breeze Icons to start.
This is a duplicate of https://bugs.kde.org/show_bug.cgi?id=445087
*** Bug 445087 has been marked as a duplicate of this bug. ***
No solution for this?
Is there any update? Saw in Nate's post that Dolphin 22.04 will have full line selection. Maybe it solves also this bug.
Unsure what to do about this one. It turns white because *everything* using the highlight color turns white when its list item is highlighted. So if we didn't do this, the icon would be very difficult to distinguish from the selection background. Which it was before. On the other hand, I agree that it looks rather ugly right now. So apparently people preferred the old state that was technically more buggy.
(In reply to Nate Graham from comment #6) > Unsure what to do about this one. I'm not a designer but from a user point of view there are 3 choices : First, for the user eyes the selection is primarily marked by the blue highlighting color that includes the whole icon + FileName, so changing the icon color for a selection has no great signification to selection process, but letting it blue really blends badly the whole highlighting and icon colors. Second which I consider to be more consistent is to include all other icons whether they are hidden or containing previews, the only small annoyance that can be seen is that selected hidden items will have the same icon color as non hidden and if any preview has white color it will be difficult to see. Third, From my point of view the real problem is the mistake of choosing the same color for icons and highlighting selected items. A more solid solution would require whole change of Plasma UI colors by changing selection color (see attached image).
Created attachment 146036 [details] Change selection color
In reply to Nate: maybe a good solution is to draw a white or black shadowed border on the icon to not have it merged with the selection
(In reply to Nate Graham from comment #6) > Unsure what to do about this one. > > It turns white because *everything* using the highlight color turns white > when its list item is highlighted. So if we didn't do this, the icon would > be very difficult to distinguish from the selection background. Which it was > before. > > On the other hand, I agree that it looks rather ugly right now. So > apparently people preferred the old state that was technically more buggy. Well, calling it "more buggy" implies that it makes sense for the folder icons to follow the selection/accent color... But it doesn't, because of the current design of the icon itself, which is only distinguishable from the background by its color. Also, accent colors are very nice, but also "stronger" than the default blue selection: I feel that imposing them to folders (which are by far the most common icons on the screen) is "too much" and less easy on the eye. At least in the absence of a real solution, I'd rather not change the folders' color at all.
In fact the problem is already solved on desktop by drawing dark shadow behind icons, so why not apply same solution and add dark shadow behind the icons of selected items.
Created attachment 146158 [details] Dark shadow behind selected icons
Created attachment 146683 [details] Example of only putting selection background behind name of file, but not icon Is there a temporary workaround for that? I find this really ugly, and it’s not a recolor because it changes the icon (e.g. folder-download) to a normal folder icon, which «looks» particularly buggy to me. Another possibility to fix this is to only color the file(/folder) name and not the icon. It would be more coherent with the other views, and avoid other contrast issues between selection color and other blue icons e.g. HTML file icon; or with any other selection color and Breeze icons that. I tried to mockup how it would look but it would need tweaking to accommodate very short file name so that we can still see that they are selected.
Created attachment 146747 [details] Workaround for disabling folder colorization upon selection
So, here's what I understood: #3daee9 is the default selection color in Breeze and Breeze Dark themes, so the new accent color feature works by replacing this color with another one of user's choice. Also, what's colored with the accent color becomes white upon selection. And, because what's black also becomes white upon selection (which includes not only text, but also the folder's decals), here's why the entire folders icons become white (most definitely a bug). For the ones seeking for a workaround: - I've made a copy of all folder icons and used inkscape for just altering the folder's standard blue shade, "#3daee9" to "#47b8f3" (the two colors are almost indistinguishable to the eye); - put the altered folder icons into "$HOME/.local/icons/breeze/places". That's ugly, but simple and effective. You can see what this looks like in the attachment here above; if you want you can download it from https://www.pling.com/p/1709570
I think that the best solution is to dralw a dark shadow around the folder icon. It is definitely more consistent with the desktop behaviour. Do you agree?
(In reply to medin from comment #12) > Created attachment 146158 [details] > Dark shadow behind selected icons Definitely the best solution
Created attachment 148067 [details] Icons view with accent colour and folder darkening on selection So I was looking at the icon view mode. When I use an accent colour (as apposed to the default for the colour scheme) and select a folder, the folder iself is darkened and only the text is highlighted would this not work well if made universal for all modes and as default?
If it's possible to do that, I'm all for it. However I think it would be very technically challenging. This issue happens in the first place because we made folder colors respect the color scheme. We don't currently have the ability to say, "respect the color scheme when unselected, but apply this other appearance when selected".
*** Bug 457197 has been marked as a duplicate of this bug. ***
Another side effect of the bug is that when you are editing a line in dolphin, all the other fields become white on white ie invisible.
Any progress on this? Or can an expert point to the code where the code is implemented? Thanks
to me different approaches like not having the highlight over the icon or adding a shadow (which would have to be reimplemented separatedly over and over again in dolphin, open dialogs and many other apps as item delegates are often custom code, so consistency would suffer) look significantly worse. whether the white folder is a thing good or bad, to me is largely a matter of taste (personally i do like this look and behavior a lot, and i find much more pleasing than different options such added borders or shadows) And is indeed more readable than before. It may be an actual thing that many people tend to not like coloring the folders with the highlight color in the first place. The very same thing was actually done once already in the early 5.x lifecycle, and was quickly reverted due to backlash, most people being ok with it but those that weren't were VERY vocal. I'm wondering if this should be configurable. The only way we would have to configure it would actually be a different icon theme with *only* the folder icons which would have non themeable colors, that would fallback to normal breeze for everything else.
Yeah that may be a good idea indeed. So we would have a highlight/accent-color-respecting icon theme and a fixed-color icon theme. Or maybe we could even simplify this to a checkbox in the KCM: "use highlight/accent color for Folder backgrounds"
(In reply to Marco Martin from comment #23) > personally i do like this look and behavior a lot, and i find much > more pleasing than different options such added borders or shadows The current solution is inconsistent because that white color is applied only to non hidden folders that have no thumbnails. > It may be an actual thing that many people tend to not like coloring the > folders with the highlight color in the first place From Windows to other Linux desktops, it seems that only KDE suffers from it, so it's normal to be spotted people.
I solved as suggested here by creating a local icon set slightly darker for the folders, which by the way is even more awesome. After all why to have selection and folder color the same?
*** Bug 463811 has been marked as a duplicate of this bug. ***
Is there any update on this issue? If you could point me in the good code byte I could spend some time trying to fix it. Thanks
I had the Folder icon (default Breeze) turn completely black when I selected the blue accent color from the palette in system settings. It looks a bit broken then.
Hello all, Will the new ocean breeze theme have the same white select folder? Btw if a folder is hidden it does not get white. So it is an inconsistent behavior. Thanks for an update Gianluca
*** Bug 482186 has been marked as a duplicate of this bug. ***
Still an issue in Plasma 6.0.2.
O Plasma 6.0.3 I am now getting black icons instead of white.
The color it changes to will depend on your color scheme and/or accent color.
I still believe it is inconsistent because the selection behaves differently if the folder icon is of a regular folder or a hidden folder.